Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: bazel-buildtools-5.1.0
@ 2022-08-21 18:47 n1c00o
  2022-08-21 22:43 ` [PR REVIEW] " classabbyamp
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: n1c00o @ 2022-08-21 18:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

There is a new pull request by n1c00o against master on the void-packages repository

https://github.com/n1c00o/void-packages feat/bazel-buildtools
https://github.com/void-linux/void-packages/pull/38813

New package: bazel-buildtools-5.1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - Should support cross compilation using the Go standard toolchain 

> Note: As I specified a few weeks ago in <https://github.com/void-linux/void-packages/pull/38207>, I decided to release the different Bazel buildtools into a single package to avoid polluting the repository, since these tools are often installed together.

> Note: The package is named `bazel-buildtools` to be clear that it is for Bazel, since a lot of ecosystems do have tools under the name "buildtools".

> Note: This is not a subpackage of `bazel` (unpublished yet) since they do not directly require Bazel and building Bazel from source is very long, which could be annoying for people which only needs the buildtools (since a subpackage is only executed after the main package's installation phase.

A patch file from https://github.com/void-linux/void-packages/pull/38813.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feat/bazel-buildtools-38813.patch --]
[-- Type: text/x-diff, Size: 1807 bytes --]

From bf67a2384a4a890fa6d5e3cba70e1c1b46b5f26c Mon Sep 17 00:00:00 2001
From: n1c00o <git.n1c00o@gmail.com>
Date: Sun, 21 Aug 2022 20:41:18 +0200
Subject: [PATCH] New package: bazel-buildtools-5.1.0

added common bazel tool such as buildifier and buildozer into a single package ready to be shipped
---
 srcpkgs/bazel-buildtools/template | 35 +++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 srcpkgs/bazel-buildtools/template

diff --git a/srcpkgs/bazel-buildtools/template b/srcpkgs/bazel-buildtools/template
new file mode 100644
index 000000000000..36ae3535c112
--- /dev/null
+++ b/srcpkgs/bazel-buildtools/template
@@ -0,0 +1,35 @@
+# Template file for 'bazel-buildtools'
+pkgname=bazel-buildtools
+version=5.1.0
+revision=1
+wrksrc="buildtools-${version}"
+hostmakedepends="go"
+short_desc="Bazel BUILD file formatter and editor"
+maintainer="n1c00o <git.n1c00o@gmail.com>"
+license="Apache-2.0"
+homepage="https://github.com/bazelbuild/buidtools"
+distfiles="https://github.com/bazelbuild/buildtools/archive/refs/tags/${version}.tar.gz"
+checksum="e3bb0dc8b0274ea1aca75f1f8c0c835adbe589708ea89bf698069d0790701ea3"
+
+do_build() {
+	mkdir _output
+
+	# A command line tool to determine any unused dependencies in java_library targets.
+	# Standard formatting and linting tool for Bazel BUILD files.
+	# Standard tool to apply bulk actions on Bazel BUILD files.
+	for t in "unused_deps" "buildifier" "buildozer"; do
+		go build -p "$XBPS_MAKEJOBS" -o "_output/$t" ./"$t"
+	done
+}
+
+do_install() {
+	vbin _output/unused_deps unused_deps
+	vdoc ./unused_deps/README.md unused_deps.md
+
+	vbin _output/buildifier buildifier
+	vdoc ./buildifier/README.md buildifier.md
+	vdoc WARNINGS.md
+
+	vbin _output/buildozer buildozer
+	vdoc ./buildozer/README.md buildozer.md
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
  2022-08-21 22:43 ` [PR REVIEW] " classabbyamp
  2022-08-21 22:43 ` classabbyamp
@ 2022-08-21 22:43 ` classabbyamp
  2022-08-22 10:20 ` n1c00o
                   ` (8 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: classabbyamp @ 2022-08-21 22:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#discussion_r950909840

Comment:
```suggestion
build_style=go
go_import_path="github.com/bazelbuild/buildtools"
go_package="${go_import_path}/unused_deps ${go_import_path}/buildifier
 ${go_import_path}/buildozer"
```

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
  2022-08-21 22:43 ` [PR REVIEW] " classabbyamp
@ 2022-08-21 22:43 ` classabbyamp
  2022-08-21 22:43 ` classabbyamp
                   ` (9 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: classabbyamp @ 2022-08-21 22:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#discussion_r950908976

Comment:
404 (missing an `l` I think)

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
@ 2022-08-21 22:43 ` classabbyamp
  2022-08-21 22:43 ` classabbyamp
                   ` (10 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: classabbyamp @ 2022-08-21 22:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#discussion_r950909796

Comment:
```suggestion
post_install() {
	vdoc unused_deps/README.md unused_deps.md
	vdoc buildifier/README.md buildifier.md
	vdoc buildozer/README.md buildozer.md
	vdoc WARNINGS.md
}
```

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (2 preceding siblings ...)
  2022-08-21 22:43 ` classabbyamp
@ 2022-08-22 10:20 ` n1c00o
  2022-08-22 10:20 ` n1c00o
                   ` (7 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: n1c00o @ 2022-08-22 10:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by n1c00o on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#discussion_r951265505

Comment:
Oh I was not able to make it works properly at first because I did not use go_package, let me try!

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (3 preceding siblings ...)
  2022-08-22 10:20 ` n1c00o
@ 2022-08-22 10:20 ` n1c00o
  2022-08-22 10:28 ` [PR PATCH] [Updated] " n1c00o
                   ` (6 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: n1c00o @ 2022-08-22 10:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New review comment by n1c00o on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#discussion_r951265689

Comment:
Yes

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (4 preceding siblings ...)
  2022-08-22 10:20 ` n1c00o
@ 2022-08-22 10:28 ` n1c00o
  2022-08-22 10:29 ` [PR REVIEW] " n1c00o
                   ` (5 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: n1c00o @ 2022-08-22 10:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

There is an updated pull request by n1c00o against master on the void-packages repository

https://github.com/n1c00o/void-packages feat/bazel-buildtools
https://github.com/void-linux/void-packages/pull/38813

New package: bazel-buildtools-5.1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - Should support cross compilation using the Go standard toolchain 

> Note: As I specified a few weeks ago in <https://github.com/void-linux/void-packages/pull/38207>, I decided to release the different Bazel buildtools into a single package to avoid polluting the repository, since these tools are often installed together.

> Note: The package is named `bazel-buildtools` to be clear that it is for Bazel, since a lot of ecosystems do have tools under the name "buildtools".

> Note: This is not a sub-package of `bazel` (unpublished yet) since they do not directly require Bazel and building Bazel from source is very long, which could be annoying for those who only needs the build tools (a sub-package is only executed after the main package's installation phase.

A patch file from https://github.com/void-linux/void-packages/pull/38813.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feat/bazel-buildtools-38813.patch --]
[-- Type: text/x-diff, Size: 1468 bytes --]

From 5667475c06f581693f5238d25dda5d78ff21b864 Mon Sep 17 00:00:00 2001
From: n1c00o <git.n1c00o@gmail.com>
Date: Sun, 21 Aug 2022 20:41:18 +0200
Subject: [PATCH] New package: bazel-buildtools-5.1.0

added common bazel tool such as buildifier and buildozer into a single package ready to be shipped
---
 srcpkgs/bazel-buildtools/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/bazel-buildtools/template

diff --git a/srcpkgs/bazel-buildtools/template b/srcpkgs/bazel-buildtools/template
new file mode 100644
index 000000000000..d1b05ecc1680
--- /dev/null
+++ b/srcpkgs/bazel-buildtools/template
@@ -0,0 +1,21 @@
+# Template file for 'bazel-buildtools'
+pkgname=bazel-buildtools
+version=5.1.0
+revision=1
+wrksrc="buildtools-${version}"
+build_style="go"
+go_import_path="github.com/bazelbuild/buildtools"
+go_package="${go_import_path}/unused_deps ${go_import_path}/buildifier ${go_import_path}/buildozer"
+short_desc="Bazel BUILD file formatter and editor"
+maintainer="n1c00o <git.n1c00o@gmail.com>"
+license="Apache-2.0"
+homepage="https://github.com/bazelbuild/buildtools"
+distfiles="https://github.com/bazelbuild/buildtools/archive/refs/tags/${version}.tar.gz"
+checksum="e3bb0dc8b0274ea1aca75f1f8c0c835adbe589708ea89bf698069d0790701ea3"
+
+post_install() {
+	vdoc ./unused_deps/README.md unused_deps.md
+	vdoc ./buildifier/README.md buildifier.md
+	vdoc WARNINGS.md
+	vdoc ./buildozer/README.md buildozer.md
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR REVIEW] New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (5 preceding siblings ...)
  2022-08-22 10:28 ` [PR PATCH] [Updated] " n1c00o
@ 2022-08-22 10:29 ` n1c00o
  2022-08-23 12:06 ` [PR PATCH] [Updated] " n1c00o
                   ` (4 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: n1c00o @ 2022-08-22 10:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New review comment by n1c00o on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#discussion_r951273397

Comment:
This works fine! I tested the change on the same platforms as stated in the original message

thanks

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Updated] New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (6 preceding siblings ...)
  2022-08-22 10:29 ` [PR REVIEW] " n1c00o
@ 2022-08-23 12:06 ` n1c00o
  2022-08-23 12:06 ` n1c00o
                   ` (3 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: n1c00o @ 2022-08-23 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]

There is an updated pull request by n1c00o against master on the void-packages repository

https://github.com/n1c00o/void-packages feat/bazel-buildtools
https://github.com/void-linux/void-packages/pull/38813

New package: bazel-buildtools-5.1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - Should support cross compilation using the Go standard toolchain 

> Note: As I specified a few weeks ago in <https://github.com/void-linux/void-packages/pull/38207>, I decided to release the different Bazel buildtools into a single package to avoid polluting the repository, since these tools are often installed together.

> Note: The package is named `bazel-buildtools` to be clear that it is for Bazel, since a lot of ecosystems do have tools under the name "buildtools".

> Note: This is not a sub-package of `bazel` (unpublished yet) since they do not directly require Bazel and building Bazel from source is very long, which could be annoying for those who only needs the build tools (a sub-package is only executed after the main package's installation phase.

A patch file from https://github.com/void-linux/void-packages/pull/38813.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feat/bazel-buildtools-38813.patch --]
[-- Type: text/x-diff, Size: 1369 bytes --]

From 987b950286e01180164538f456feac921c7c54b4 Mon Sep 17 00:00:00 2001
From: n1c00o <git.n1c00o@gmail.com>
Date: Sun, 21 Aug 2022 20:41:18 +0200
Subject: [PATCH] New package: bazel-buildtools-5.1.0

---
 srcpkgs/bazel-buildtools/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/bazel-buildtools/template

diff --git a/srcpkgs/bazel-buildtools/template b/srcpkgs/bazel-buildtools/template
new file mode 100644
index 000000000000..d1b05ecc1680
--- /dev/null
+++ b/srcpkgs/bazel-buildtools/template
@@ -0,0 +1,21 @@
+# Template file for 'bazel-buildtools'
+pkgname=bazel-buildtools
+version=5.1.0
+revision=1
+wrksrc="buildtools-${version}"
+build_style="go"
+go_import_path="github.com/bazelbuild/buildtools"
+go_package="${go_import_path}/unused_deps ${go_import_path}/buildifier ${go_import_path}/buildozer"
+short_desc="Bazel BUILD file formatter and editor"
+maintainer="n1c00o <git.n1c00o@gmail.com>"
+license="Apache-2.0"
+homepage="https://github.com/bazelbuild/buildtools"
+distfiles="https://github.com/bazelbuild/buildtools/archive/refs/tags/${version}.tar.gz"
+checksum="e3bb0dc8b0274ea1aca75f1f8c0c835adbe589708ea89bf698069d0790701ea3"
+
+post_install() {
+	vdoc ./unused_deps/README.md unused_deps.md
+	vdoc ./buildifier/README.md buildifier.md
+	vdoc WARNINGS.md
+	vdoc ./buildozer/README.md buildozer.md
+}

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (7 preceding siblings ...)
  2022-08-23 12:06 ` [PR PATCH] [Updated] " n1c00o
@ 2022-08-23 12:06 ` n1c00o
  2022-11-28  2:04 ` github-actions
                   ` (2 subsequent siblings)
  11 siblings, 0 replies; 13+ messages in thread
From: n1c00o @ 2022-08-23 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by n1c00o on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#issuecomment-1223975750

Comment:
I removed the additional comment in the commit message since it was the source of the xlint job error

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (8 preceding siblings ...)
  2022-08-23 12:06 ` n1c00o
@ 2022-11-28  2:04 ` github-actions
  2022-11-29 15:53 ` n1c00o
  2022-11-29 15:53 ` [PR PATCH] [Closed]: " n1c00o
  11 siblings, 0 replies; 13+ messages in thread
From: github-actions @ 2022-11-28  2:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#issuecomment-1328431790

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (9 preceding siblings ...)
  2022-11-28  2:04 ` github-actions
@ 2022-11-29 15:53 ` n1c00o
  2022-11-29 15:53 ` [PR PATCH] [Closed]: " n1c00o
  11 siblings, 0 replies; 13+ messages in thread
From: n1c00o @ 2022-11-29 15:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by n1c00o on void-packages repository

https://github.com/void-linux/void-packages/pull/38813#issuecomment-1330863434

Comment:
Closing the issue due to the lack of answer or any news.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PR PATCH] [Closed]: New package: bazel-buildtools-5.1.0
  2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
                   ` (10 preceding siblings ...)
  2022-11-29 15:53 ` n1c00o
@ 2022-11-29 15:53 ` n1c00o
  11 siblings, 0 replies; 13+ messages in thread
From: n1c00o @ 2022-11-29 15:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

There's a closed pull request on the void-packages repository

New package: bazel-buildtools-5.1.0
https://github.com/void-linux/void-packages/pull/38813

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - Should support cross compilation using the Go standard toolchain 

> Note: As I specified a few weeks ago in <https://github.com/void-linux/void-packages/pull/38207>, I decided to release the different Bazel buildtools into a single package to avoid polluting the repository, since these tools are often installed together.

> Note: The package is named `bazel-buildtools` to be clear that it is for Bazel, since a lot of ecosystems do have tools under the name "buildtools".

> Note: This is not a sub-package of `bazel` (unpublished yet) since they do not directly require Bazel and building Bazel from source is very long, which could be annoying for those who only needs the build tools (a sub-package is only executed after the main package's installation phase.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-11-29 15:53 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-21 18:47 [PR PATCH] New package: bazel-buildtools-5.1.0 n1c00o
2022-08-21 22:43 ` [PR REVIEW] " classabbyamp
2022-08-21 22:43 ` classabbyamp
2022-08-21 22:43 ` classabbyamp
2022-08-22 10:20 ` n1c00o
2022-08-22 10:20 ` n1c00o
2022-08-22 10:28 ` [PR PATCH] [Updated] " n1c00o
2022-08-22 10:29 ` [PR REVIEW] " n1c00o
2022-08-23 12:06 ` [PR PATCH] [Updated] " n1c00o
2022-08-23 12:06 ` n1c00o
2022-11-28  2:04 ` github-actions
2022-11-29 15:53 ` n1c00o
2022-11-29 15:53 ` [PR PATCH] [Closed]: " n1c00o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).