From: averycoolbean <averycoolbean@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] webkit2gtk: add patch to resolve unintended gst-plugins-bad1 dependency
Date: Fri, 09 Sep 2022 07:29:24 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39180@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1590 bytes --]
There is a new pull request by averycoolbean against master on the void-packages repository
https://github.com/averycoolbean/void-packages master
https://github.com/void-linux/void-packages/pull/39180
webkit2gtk: add patch to resolve unintended gst-plugins-bad1 dependency
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR:**NO**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (amd64-glibc)
this would properly resolve issue [#34781](https://github.com/void-linux/void-packages/issues/34781) by applying the final fix already included in webkitgtk versions 2.36.4 and up
full credit for the fix goes to Philippe Normand [here](https://bugs.webkit.org/attachment.cgi?id=451364&action=diff), i just copy-pasted it onto this older version to generate a fitting patch
@q66 you asked to be pinged before touching this package
A patch file from https://github.com/void-linux/void-packages/pull/39180.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-39180.patch --]
[-- Type: text/x-diff, Size: 2449 bytes --]
From 79bcff3f012204c3f36705875bc025751b4e1e51 Mon Sep 17 00:00:00 2001
From: coolbean <thecoolestofbeans@protonmail.com>
Date: Fri, 9 Sep 2022 06:34:26 +0200
Subject: [PATCH 1/2] add no gstreamer plugin dependency patch
---
srcpkgs/webkit2gtk/patches/nogstbad.patch | 29 +++++++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 srcpkgs/webkit2gtk/patches/nogstbad.patch
diff --git a/srcpkgs/webkit2gtk/patches/nogstbad.patch b/srcpkgs/webkit2gtk/patches/nogstbad.patch
new file mode 100644
index 000000000000..d5a69ddba9e6
--- /dev/null
+++ b/srcpkgs/webkit2gtk/patches/nogstbad.patch
@@ -0,0 +1,29 @@
+From c9fa538715b7a40a24ed187d14995ee67a04b718 Mon Sep 17 00:00:00 2001
+From: coolbean <thecoolestofbeans@protonmail.com>
+Date: Fri, 9 Sep 2022 05:22:55 +0200
+Subject: [PATCH] apply patch
+
+---
+ .../graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
+index 3237520e..d612c10a 100644
+--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
++++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
+@@ -3402,6 +3402,12 @@ GstElement* MediaPlayerPrivateGStreamer::createVideoSink()
+
+ if (!m_player->isVideoPlayer()) {
+ m_videoSink = makeGStreamerElement("fakevideosink", nullptr);
++ if (!m_videoSink) {
++ GST_DEBUG_OBJECT(m_pipeline.get(), "Falling back to fakesink for video rendering");
++ m_videoSink = gst_element_factory_make("fakesink", nullptr);
++ g_object_set(m_videoSink.get(), "sync", TRUE, nullptr);
++ }
++
+ return m_videoSink.get();
+ }
+
+--
+2.37.3
+
From cecbeb50f76ea035f0b4044419822c291c53f5a7 Mon Sep 17 00:00:00 2001
From: coolbean <thecoolestofbeans@protonmail.com>
Date: Fri, 9 Sep 2022 06:54:40 +0200
Subject: [PATCH 2/2] bump revision number
---
srcpkgs/webkit2gtk/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/webkit2gtk/template b/srcpkgs/webkit2gtk/template
index e103f2ce06c8..3dd8e1255916 100644
--- a/srcpkgs/webkit2gtk/template
+++ b/srcpkgs/webkit2gtk/template
@@ -2,7 +2,7 @@
# ping q66 before touching this
pkgname=webkit2gtk
version=2.34.6
-revision=2
+revision=3
wrksrc="webkitgtk-${version}"
build_style=cmake
build_helper="gir"
next reply other threads:[~2022-09-09 5:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 5:29 averycoolbean [this message]
2022-09-09 5:44 ` averycoolbean
2022-09-09 6:25 ` [PR PATCH] [Updated] " averycoolbean
2022-09-09 11:40 ` q66
2022-09-09 11:40 ` [PR PATCH] [Closed]: " q66
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-39180@inbox.vuxu.org \
--to=averycoolbean@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).