Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] nnn: add build options
@ 2022-09-19  8:48 freddylist
  2022-09-19 10:32 ` [PR REVIEW] " classabbyamp
                   ` (40 more replies)
  0 siblings, 41 replies; 42+ messages in thread
From: freddylist @ 2022-09-19  8:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

There is a new pull request by freddylist against master on the void-packages repository

https://github.com/freddylist/void-packages nnn-buildopts
https://github.com/void-linux/void-packages/pull/39360

nnn: add build options
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc

---

`xlint` doesn't like my string on multiple lines.

A patch file from https://github.com/void-linux/void-packages/pull/39360.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-buildopts-39360.patch --]
[-- Type: text/x-diff, Size: 3990 bytes --]

From 282edd04c8fd26c938f9a2b673e5757ec1d3765a Mon Sep 17 00:00:00 2001
From: Freddy List <github@freddylist.xyz>
Date: Mon, 19 Sep 2022 10:33:34 +0200
Subject: [PATCH] nnn: add build options

---
 srcpkgs/nnn/template | 85 +++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 84 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index cea82d368152..63752e4d6383 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,7 +1,7 @@
 # Template file for 'nnn'
 pkgname=nnn
 version=4.6
-revision=1
+revision=2
 build_style=gnu-makefile
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
@@ -14,6 +14,84 @@ changelog="https://raw.githubusercontent.com/jarun/nnn/master/CHANGELOG"
 distfiles="https://github.com/jarun/nnn/archive/v${version}.tar.gz"
 checksum=15acaf9a88cfb5a2a640d3ef55a48af644fba92b46aac0768efe94c4addf7e3f
 
+# Package build options
+build_options="readline \
+pcre \
+mouse \
+batch \
+fifo \
+session \
+details \
+icons \
+nerdfont \
+emojis \
+locale \
+x11 \
+qsort \
+bench \
+ctx8 \
+matchfilter \
+sort \
+colemak \
+gitstatus \
+namefirst \
+restorepreview \
+static"
+build_options_default="readline mouse batch fifo session details locale x11 sort"
+
+# See https://github.com/jarun/nnn/wiki/Developer-guides#make-options
+desc_option_pcre="Link with PCRE library"
+desc_option_mouse="Mouse support"
+desc_option_batch="Built-in feature-limited batch renamer"
+#desc_option_fifo=""
+#desc_option_session=""
+desc_option_details="User, group details in status bar"
+desc_option_icons="icons-in-terminal support, not compatible with set nerdfont or emojis or unset locale"
+desc_option_nerdfont="Nerdfont icons, not compatible with set icons or emojis or unset locale"
+desc_option_emojis="Emoji icons, not compatible with set nerdfont or icons or unset locale"
+desc_option_locale="Locale support, unsupported characters in filenames will be replaced with '?' when unset"
+desc_option_qsort="Alexey Tourbin's QSORT"
+desc_option_bench="Benchmark mode"
+desc_option_ctx8="Enable 8 contexts, however, saved sessions may no longer be usable"
+desc_option_matchfilter="Matching filters only, discard filter key when there's no match"
+desc_option_sort="Load directories sorted, unsetting requires xterm 256 colors"
+
+# See https://github.com/jarun/nnn/tree/master/patches#user-patch-framework
+desc_option_colemak="Key bindings for Colemak-DH keyboard layout"
+desc_option_gitstatus="Add git status column to the detail view"
+desc_option_namefirst="Print filenames first in the detail view"
+desc_option_restorepreview="Add pipe to close and restore preview-tui for internal undetached edits (e key)"
+
+# Following are mutually exclusive
+vopt_conflict icons nerdfont
+vopt_conflict nerdfont emojis
+vopt_conflict emojis icons
+
+make_build_args="O_NORL=$(vopt_if readline 0 1) \
+O_PCRE=$(vopt_if pcre 1 0) \
+O_NOLC=$(vopt_if locale 0 1) \
+O_NOMOUSE=$(vopt_if mouse 0 1) \
+O_NOBATCH=$(vopt_if batch 0 1) \
+O_NOFIFO=$(vopt_if fifo 0 1) \
+O_CTX8=$(vopt_if ctx8 1 0) \
+O_ICONS=$(vopt_if icons 1 0) \
+O_NERD=$(vopt_if nerdfont 1 0) \
+O_EMOJI=$(vopt_if emojis 1 0) \
+O_QSORT=$(vopt_if qsort 1 0) \
+O_BENCH=$(vopt_if bench 1 0) \
+O_NOSSN=$(vopt_if session 0 1) \
+O_NOUG=$(vopt_if details 0 1) \
+O_NOX11=$(vopt_if x11 0 1) \
+O_MATCHFLTR=$(vopt_if matchfilter 1 0) \
+O_NOSORT=$(vopt_if sort 0 1) \
+O_COLEMAK=$(vopt_if colemak 1 0) \
+O_GITSTATUS=$(vopt_if gitstatus 1 0) \
+O_NAMEFIRST=$(vopt_if namefirst 1 0) \
+O_RESTOREPREVIEW=$(vopt_if restorepreview 1 0) \
+O_STATIC=$(vopt_if static 1 0)"
+
+makedepends+=$(vopt_if static " gpm-devel")
+
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 	makedepends+=" musl-fts-devel"
 fi
@@ -24,6 +102,11 @@ pre_build() {
 	fi
 }
 
+# See https://github.com/jarun/nnn/issues/1493
+pre_install() {
+	touch nnn
+}
+
 post_install() {
 	vinstall misc/auto-completion/bash/nnn-completion.bash 644 \
 		usr/share/bash-completion/completions nnn

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR REVIEW] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
@ 2022-09-19 10:32 ` classabbyamp
  2022-09-19 10:34 ` classabbyamp
                   ` (39 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: classabbyamp @ 2022-09-19 10:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#discussion_r974098003

Comment:
#36693

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR REVIEW] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
  2022-09-19 10:32 ` [PR REVIEW] " classabbyamp
@ 2022-09-19 10:34 ` classabbyamp
  2022-09-19 10:38 ` classabbyamp
                   ` (38 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: classabbyamp @ 2022-09-19 10:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#discussion_r974099869

Comment:
the style for multi-line strings is just:
```sh
var_name="line one here
 line two here
 line three here"
```
(note the space starting each line and the lack of backlashes)

you also don't need to put each one on its own line

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
  2022-09-19 10:32 ` [PR REVIEW] " classabbyamp
  2022-09-19 10:34 ` classabbyamp
@ 2022-09-19 10:38 ` classabbyamp
  2022-09-19 10:39 ` [PR REVIEW] " classabbyamp
                   ` (37 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: classabbyamp @ 2022-09-19 10:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250852095

Comment:
I'm not sure what the point of this change is and I don't think the plethora of build options is necessary, the default ones should just be the default `make_build_args` without options defined, if anything.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR REVIEW] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (2 preceding siblings ...)
  2022-09-19 10:38 ` classabbyamp
@ 2022-09-19 10:39 ` classabbyamp
  2022-09-19 10:40 ` freddylist
                   ` (36 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: classabbyamp @ 2022-09-19 10:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#discussion_r974103326

Comment:
this should be just after `build_style`

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR REVIEW] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (3 preceding siblings ...)
  2022-09-19 10:39 ` [PR REVIEW] " classabbyamp
@ 2022-09-19 10:40 ` freddylist
  2022-09-19 10:43 ` freddylist
                   ` (35 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 10:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#discussion_r974103777

Comment:
Oh thanks! I'll update the PR when I am home again. 😄 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (4 preceding siblings ...)
  2022-09-19 10:40 ` freddylist
@ 2022-09-19 10:43 ` freddylist
  2022-09-19 10:46 ` freddylist
                   ` (34 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 10:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250855948

Comment:
> I'm not sure what the point of this change is and I don't think the plethora of build options is necessary, the default ones should just be the default `make_build_args` without options defined, if anything.

I tried "generalizing" the build options. If you take a look at `nnn`'s [build options](https://github.com/jarun/nnn/wiki/Developer-guides#make-options), most of them are reversed like `O_NOMOUSE`. The build options in `build_options_default` are `nnn`'s default options reversed.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (5 preceding siblings ...)
  2022-09-19 10:43 ` freddylist
@ 2022-09-19 10:46 ` freddylist
  2022-09-19 10:48 ` freddylist
                   ` (33 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 10:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250855948

Comment:
> I'm not sure what the point of this change is and I don't think the plethora of build options is necessary, the default ones should just be the default `make_build_args` without options defined, if anything.

I tried "generalizing" the build options. If you take a look at `nnn`'s [build options](https://github.com/jarun/nnn/wiki/Developer-guides#make-options), most of them are reversed like `O_NOMOUSE` to compile *out* mouse support. The build options in `build_options_default` are `nnn`'s default options reversed.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (6 preceding siblings ...)
  2022-09-19 10:46 ` freddylist
@ 2022-09-19 10:48 ` freddylist
  2022-09-19 10:53 ` freddylist
                   ` (32 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 10:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250855948

Comment:
> I'm not sure what the point of this change is and I don't think the plethora of build options is necessary, the default ones should just be the default `make_build_args` without options defined, if anything.

I tried "generalizing" the build options. If you take a look at `nnn`'s [build options](https://github.com/jarun/nnn/wiki/Developer-guides#make-options), most of them are reversed like `O_NOMOUSE` to compile *out* mouse support. The build options in `build_options_default` are `nnn`'s default options reversed.

The point of this change is to be able to manage `nnn` with custom build options like [`O_NERD`](https://github.com/jarun/nnn/wiki/Developer-guides#make-options) and [user patches](https://github.com/jarun/nnn/tree/master/patches#user-patch-framework) like `O_GITSTATUS` with `xbps-src`.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (7 preceding siblings ...)
  2022-09-19 10:48 ` freddylist
@ 2022-09-19 10:53 ` freddylist
  2022-09-19 10:54 ` sgn
                   ` (31 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 10:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250855948

Comment:
> I'm not sure what the point of this change is and I don't think the plethora of build options is necessary, the default ones should just be the default `make_build_args` without options defined, if anything.

I tried "generalizing" the build options. If you take a look at `nnn`'s [build options](https://github.com/jarun/nnn/wiki/Developer-guides#make-options), most of them are reversed like `O_NOMOUSE` to compile *out* mouse support. The build options in `build_options_default` are `nnn`'s default options.

The point of this change is to be able to manage `nnn` with custom build options like [`O_NERD`](https://github.com/jarun/nnn/wiki/Developer-guides#make-options) and [user patches](https://github.com/jarun/nnn/tree/master/patches#user-patch-framework) like `O_GITSTATUS` with `xbps-src`.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (8 preceding siblings ...)
  2022-09-19 10:53 ` freddylist
@ 2022-09-19 10:54 ` sgn
  2022-09-19 10:57 ` freddylist
                   ` (30 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-09-19 10:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250865376

Comment:
We ain't Gentoo.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (9 preceding siblings ...)
  2022-09-19 10:54 ` sgn
@ 2022-09-19 10:57 ` freddylist
  2022-09-19 10:58 ` sgn
                   ` (29 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 10:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250867300

Comment:
> We ain't Gentoo.

Then what's the point of `xbps-src -o option1,option2,...`?

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (10 preceding siblings ...)
  2022-09-19 10:57 ` freddylist
@ 2022-09-19 10:58 ` sgn
  2022-09-19 11:00 ` sgn
                   ` (28 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-09-19 10:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250865376

Comment:
We ain't Gentoo. I don't think a hundred of build option is a good idea. `nnn` is fast to be built.
I think it's better to patch their `Makefile` to have let's say `-include config.mk` and put the option there. Whoever want some custom option could put the config into files directory.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (11 preceding siblings ...)
  2022-09-19 10:58 ` sgn
@ 2022-09-19 11:00 ` sgn
  2022-09-19 11:32 ` paper42
                   ` (27 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-09-19 11:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250865376

Comment:
We ain't Gentoo. I don't think a hundred of build option is a good idea. `nnn` is fast to be built.
I think it's better to patch their `Makefile` to have let's say `-include config.mk` and put the option there. Whoever want some custom option could put the config into files directory. With that approach, we won't need to care for nnn's change in build option whatsoever.
As for build dependencies, just add them all. `nnn` is always a leaf (as in graph) packages.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (12 preceding siblings ...)
  2022-09-19 11:00 ` sgn
@ 2022-09-19 11:32 ` paper42
  2022-09-19 11:59 ` freddylist
                   ` (26 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: paper42 @ 2022-09-19 11:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250899629

Comment:
> > We ain't Gentoo.
> 
> Then what's the point of `xbps-src -o option1,option2,...`?

When disabling an option makes sense - (sometimes) when a feature should only be enabled in certain situations (only on some archs), when it makes sense that some people might want to disable an option (minimalism is not a reason).
Applying patches in minimalist software should be left to the user, I don't think we should wrap that in xbps-src options and keep it up to date.

Sometimes it makes sense to have an option to avoid a big dependency, but then it's usually better to split part of the package to a subpackage (ffmpeg, ffplay).

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (13 preceding siblings ...)
  2022-09-19 11:32 ` paper42
@ 2022-09-19 11:59 ` freddylist
  2022-09-19 12:33 ` [PR PATCH] [Updated] " freddylist
                   ` (25 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 11:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250923712

Comment:
> Applying patches in minimalist software should be left to the user, I don't think we should wrap that in xbps-src options and keep it up to date.

I agree. Now that I think about it, I'm actually not sure why I included the build options for the patches, I think I just shoved them in there. :p 

I still think we should add at least the 3 build options to add icon support (`icons`/`O_ICONS`, `nerdfont`/`O_NERD`, `emojis`/`O_EMOJI`) as that seems to be a fairly common thing people want. Maybe we should also add the few other options that compile *in* features.

Users who want patches should just download them from [here](https://github.com/jarun/nnn/tree/master/patches) and add them to the `nnn/patches/` directory.

Anyone who wants to compile *out* features is on their own I guess.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR PATCH] [Updated] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (14 preceding siblings ...)
  2022-09-19 11:59 ` freddylist
@ 2022-09-19 12:33 ` freddylist
  2022-09-19 12:39 ` freddylist
                   ` (24 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 12:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

There is an updated pull request by freddylist against master on the void-packages repository

https://github.com/freddylist/void-packages nnn-buildopts
https://github.com/void-linux/void-packages/pull/39360

nnn: add build options
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc

---

`xlint` doesn't like my string on multiple lines.

A patch file from https://github.com/void-linux/void-packages/pull/39360.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-buildopts-39360.patch --]
[-- Type: text/x-diff, Size: 2182 bytes --]

From fd4f83aee9711ecc795fd3f4987dd186de44d486 Mon Sep 17 00:00:00 2001
From: Freddy List <github@freddylist.xyz>
Date: Mon, 19 Sep 2022 10:33:34 +0200
Subject: [PATCH] nnn: add build options

---
 srcpkgs/nnn/template | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index cea82d368152..d8f1c0f56770 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,7 +1,7 @@
 # Template file for 'nnn'
 pkgname=nnn
 version=4.6
-revision=1
+revision=2
 build_style=gnu-makefile
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
@@ -14,6 +14,41 @@ changelog="https://raw.githubusercontent.com/jarun/nnn/master/CHANGELOG"
 distfiles="https://github.com/jarun/nnn/archive/v${version}.tar.gz"
 checksum=15acaf9a88cfb5a2a640d3ef55a48af644fba92b46aac0768efe94c4addf7e3f
 
+# Package build options
+build_options="pcre
+ icons
+ nerdfont
+ emojis
+ qsort
+ ctx8
+ matchfilter
+ static"
+
+# See https://github.com/jarun/nnn/wiki/Developer-guides#make-options
+desc_option_pcre="PCRE instead of POSIX regex"
+desc_option_icons="icons-in-terminal support, not compatible with set nerdfont or emojis or unset locale"
+desc_option_nerdfont="Nerdfont icons, not compatible with set icons or emojis or unset locale"
+desc_option_emojis="Emoji icons, not compatible with set nerdfont or icons or unset locale"
+desc_option_qsort="Alexey Tourbin's QSORT"
+desc_option_ctx8="Enable 8 contexts, however, saved sessions may no longer be usable"
+desc_option_matchfilter="Matching filters only, discard filter key when there's no match"
+
+# Following are mutually exclusive
+vopt_conflict icons nerdfont
+vopt_conflict nerdfont emojis
+vopt_conflict emojis icons
+
+make_build_args="O_PCRE=$(vopt_if pcre 1 0)
+ O_CTX8=$(vopt_if ctx8 1 0)
+ O_ICONS=$(vopt_if icons 1 0)
+ O_NERD=$(vopt_if nerdfont 1 0)
+ O_EMOJI=$(vopt_if emojis 1 0)
+ O_QSORT=$(vopt_if qsort 1 0)
+ O_MATCHFLTR=$(vopt_if matchfilter 1 0)
+ O_STATIC=$(vopt_if static 1 0)"
+
+makedepends+=$(vopt_if static " gpm-devel")
+
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 	makedepends+=" musl-fts-devel"
 fi

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (15 preceding siblings ...)
  2022-09-19 12:33 ` [PR PATCH] [Updated] " freddylist
@ 2022-09-19 12:39 ` freddylist
  2022-09-19 12:40 ` paper42
                   ` (23 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 12:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250966089

Comment:
I've slimmed it down to just the build options that compile in features, as well as the build option that compiles `nnn` with static linking, but maybe it's still too much?

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (16 preceding siblings ...)
  2022-09-19 12:39 ` freddylist
@ 2022-09-19 12:40 ` paper42
  2022-09-19 12:49 ` sgn
                   ` (22 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: paper42 @ 2022-09-19 12:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250967259

Comment:
Is there a reason why we can't just unconditionally enable the features?

> as well as the build option that compiles nnn with static linking, but maybe it's still too much?

remove that, there is no reason to have it  in void-packages

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (17 preceding siblings ...)
  2022-09-19 12:40 ` paper42
@ 2022-09-19 12:49 ` sgn
  2022-09-19 12:51 ` sgn
                   ` (21 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-09-19 12:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250975908

Comment:

I think it's better to patch their Makefile to have let's say -include config.mk and put the option there. Whoever want some custom option could put the config into files directory. With that approach, we won't need to care for nnn's change in build option whatsoever.
As for build dependencies, just add them all. nnn is always a leaf (as in graph) packages.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (18 preceding siblings ...)
  2022-09-19 12:49 ` sgn
@ 2022-09-19 12:51 ` sgn
  2022-09-19 12:54 ` [PR PATCH] [Updated] " freddylist
                   ` (20 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-09-19 12:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250978582

Comment:
> Is there a reason why we can't just unconditionally enable the features?
> 

User's patches, with questionable quality and/or minimalism ;)


^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR PATCH] [Updated] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (19 preceding siblings ...)
  2022-09-19 12:51 ` sgn
@ 2022-09-19 12:54 ` freddylist
  2022-09-19 13:06 ` freddylist
                   ` (19 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 12:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

There is an updated pull request by freddylist against master on the void-packages repository

https://github.com/freddylist/void-packages nnn-buildopts
https://github.com/void-linux/void-packages/pull/39360

nnn: add build options
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc

---

`xlint` doesn't like my string on multiple lines.

A patch file from https://github.com/void-linux/void-packages/pull/39360.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-buildopts-39360.patch --]
[-- Type: text/x-diff, Size: 2371 bytes --]

From f6114f43b7c5c556273a520c43d20bf7baad32e6 Mon Sep 17 00:00:00 2001
From: Freddy List <github@freddylist.xyz>
Date: Mon, 19 Sep 2022 10:33:34 +0200
Subject: [PATCH] nnn: add build options

---
 srcpkgs/nnn/template | 35 +++++++++++++++++++++++++++++++++--
 1 file changed, 33 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index cea82d368152..8b8e2d9a406d 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,11 +1,19 @@
 # Template file for 'nnn'
 pkgname=nnn
 version=4.6
-revision=1
+revision=2
 build_style=gnu-makefile
+make_build_args="O_PCRE=$(vopt_if pcre 1 0)
+ O_CTX8=$(vopt_if ctx8 1 0)
+ O_ICONS=$(vopt_if icons 1 0)
+ O_NERD=$(vopt_if nerdfont 1 0)
+ O_EMOJI=$(vopt_if emojis 1 0)
+ O_QSORT=$(vopt_if qsort 1 0)
+ O_MATCHFLTR=$(vopt_if matchfilter 1 0)
+ O_STATIC=$(vopt_if static 1 0)"
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
-makedepends="ncurses-devel readline-devel"
+makedepends="ncurses-devel readline-devel $(vopt_if static gpm-devel) $(vopt_if pcre pcre-devel)"
 short_desc="Missing terminal file browser for X"
 maintainer="Dennis Kraus <kraus@posteo.de>"
 license="BSD-2-Clause"
@@ -14,6 +22,29 @@ changelog="https://raw.githubusercontent.com/jarun/nnn/master/CHANGELOG"
 distfiles="https://github.com/jarun/nnn/archive/v${version}.tar.gz"
 checksum=15acaf9a88cfb5a2a640d3ef55a48af644fba92b46aac0768efe94c4addf7e3f
 
+build_options="ecre
+ icons
+ nerdfont
+ emojis
+ qsort
+ ctx8
+ matchfilter
+ static"
+
+# See https://github.com/jarun/nnn/wiki/Developer-guides#make-options
+desc_option_pcre="PCRE instead of POSIX regex"
+desc_option_icons="icons-in-terminal support, not compatible with set nerdfont or emojis or unset locale"
+desc_option_nerdfont="Nerdfont icons, not compatible with set icons or emojis or unset locale"
+desc_option_emojis="Emoji icons, not compatible with set nerdfont or icons or unset locale"
+desc_option_qsort="Alexey Tourbin's QSORT"
+desc_option_ctx8="Enable 8 contexts, however, saved sessions may no longer be usable"
+desc_option_matchfilter="Matching filters only, discard filter key when there's no match"
+
+# Following are mutually exclusive
+vopt_conflict icons nerdfont
+vopt_conflict nerdfont emojis
+vopt_conflict emojis icons
+
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 	makedepends+=" musl-fts-devel"
 fi

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (20 preceding siblings ...)
  2022-09-19 12:54 ` [PR PATCH] [Updated] " freddylist
@ 2022-09-19 13:06 ` freddylist
  2022-09-19 13:10 ` freddylist
                   ` (18 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 13:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250994509

Comment:
> Is there a reason why we can't just unconditionally enable the features?

You have to choose between [icons-in-terminal](https://github.com/sebastiencs/icons-in-terminal), nerd font icons, or emojis.

The build option that enables 8 contexts (as opposed to 4) might break sessions according to [this](https://github.com/jarun/nnn/wiki/Developer-guides#compile-in-8-contexts).

> > as well as the build option that compiles nnn with static linking, but maybe it's still too much?
>
> remove that, there is no reason to have it in void-packages

I just saw this, will remove. 👍 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (21 preceding siblings ...)
  2022-09-19 13:06 ` freddylist
@ 2022-09-19 13:10 ` freddylist
  2022-09-19 13:12 ` sgn
                   ` (17 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 13:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251000214

Comment:
> I think it's better to patch their Makefile to have let's say -include config.mk and put the option there. Whoever want some custom option could put the config into files directory. With that approach, we won't need to care for nnn's change in build option whatsoever. As for build dependencies, just add them all. nnn is always a leaf (as in graph) packages.

Sorry if this is a dumb question, but where would that be documented? Shouldn't users just place patch files in the `nnn` template's `patches/` directory?

As for build options, if I was trying to manage `nnn` with `xbps-src`, I would at least except the options to enable icon support to be present in `xbps-src --show-options nnn`, as it is a popular thing to compile `nnn` with.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (22 preceding siblings ...)
  2022-09-19 13:10 ` freddylist
@ 2022-09-19 13:12 ` sgn
  2022-09-19 13:12 ` sgn
                   ` (16 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-09-19 13:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2036 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251001665

Comment:
> I think it's better to patch their Makefile to have let's say -include config.mk and put the option there. Whoever want some custom option could put the config into files directory. With that approach, we won't need to care for nnn's change in build option whatsoever. As for build dependencies, just add them all. nnn is always a leaf (as in graph) packages.

Here is possible implementation:
```diff
 srcpkgs/nnn/patches/config.patch | 11 +++++++++++
 srcpkgs/nnn/template             |  5 ++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nnn/patches/config.patch b/srcpkgs/nnn/patches/config.patch
new file mode 100644
index 0000000000..e7d7238276
--- /dev/null
+++ b/srcpkgs/nnn/patches/config.patch
@@ -0,0 +1,11 @@
+--- a/Makefile
++++ b/Makefile
+@@ -36,6 +36,8 @@ O_GITSTATUS := 0 # add git status to det
+ O_NAMEFIRST := 0 # print file name first, add uid and guid to detail view
+ O_RESTOREPREVIEW := 0 # add preview pipe to close and restore preview pane
+ 
++-include config.mk
++
+ # convert targets to flags for backwards compatibility
+ ifneq ($(filter debug,$(MAKECMDGOALS)),)
+ 	O_DEBUG := 1
diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index cea82d3681..32f5fec3c1 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -5,7 +5,7 @@ revision=1
 build_style=gnu-makefile
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
-makedepends="ncurses-devel readline-devel"
+makedepends="ncurses-devel readline-devel gpm-devel pcre-devel"
 short_desc="Missing terminal file browser for X"
 maintainer="Dennis Kraus <kraus@posteo.de>"
 license="BSD-2-Clause"
@@ -22,6 +22,9 @@ pre_build() {
 	if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 		export LDLIBS=-lfts
 	fi
+	if [ -f "$FILESDIR/config.mk" ]; then
+		cp "$FILESDIR/config.mk" .
+	fi
 }
 
 post_install() {
```

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (23 preceding siblings ...)
  2022-09-19 13:12 ` sgn
@ 2022-09-19 13:12 ` sgn
  2022-09-19 13:13 ` freddylist
                   ` (15 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-09-19 13:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2063 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251001665

Comment:
> I think it's better to patch their Makefile to have let's say -include config.mk and put the option there. Whoever want some custom option could put the config into files directory. With that approach, we won't need to care for nnn's change in build option whatsoever. As for build dependencies, just add them all. nnn is always a leaf (as in graph) packages.

Here is possible implementation, no build options required:
```diff
 srcpkgs/nnn/patches/config.patch | 11 +++++++++++
 srcpkgs/nnn/template             |  5 ++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nnn/patches/config.patch b/srcpkgs/nnn/patches/config.patch
new file mode 100644
index 0000000000..e7d7238276
--- /dev/null
+++ b/srcpkgs/nnn/patches/config.patch
@@ -0,0 +1,11 @@
+--- a/Makefile
++++ b/Makefile
+@@ -36,6 +36,8 @@ O_GITSTATUS := 0 # add git status to det
+ O_NAMEFIRST := 0 # print file name first, add uid and guid to detail view
+ O_RESTOREPREVIEW := 0 # add preview pipe to close and restore preview pane
+ 
++-include config.mk
++
+ # convert targets to flags for backwards compatibility
+ ifneq ($(filter debug,$(MAKECMDGOALS)),)
+ 	O_DEBUG := 1
diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index cea82d3681..32f5fec3c1 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -5,7 +5,7 @@ revision=1
 build_style=gnu-makefile
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
-makedepends="ncurses-devel readline-devel"
+makedepends="ncurses-devel readline-devel gpm-devel pcre-devel"
 short_desc="Missing terminal file browser for X"
 maintainer="Dennis Kraus <kraus@posteo.de>"
 license="BSD-2-Clause"
@@ -22,6 +22,9 @@ pre_build() {
 	if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 		export LDLIBS=-lfts
 	fi
+	if [ -f "$FILESDIR/config.mk" ]; then
+		cp "$FILESDIR/config.mk" .
+	fi
 }
 
 post_install() {
```

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (24 preceding siblings ...)
  2022-09-19 13:12 ` sgn
@ 2022-09-19 13:13 ` freddylist
  2022-09-19 13:14 ` sgn
                   ` (14 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 13:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251000214

Comment:
> I think it's better to patch their Makefile to have let's say -include config.mk and put the option there. Whoever want some custom option could put the config into files directory. With that approach, we won't need to care for nnn's change in build option whatsoever. As for build dependencies, just add them all. nnn is always a leaf (as in graph) packages.

Sorry if this is a dumb question, but where would that be documented? Shouldn't users just place patch files in the `nnn` template's `patches/` directory?

As for build options, if I was trying to manage `nnn` with `xbps-src`, I would at least except the options to enable icon support to be present in `xbps-src show-options nnn`, as it is a popular thing to compile `nnn` with.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (25 preceding siblings ...)
  2022-09-19 13:13 ` freddylist
@ 2022-09-19 13:14 ` sgn
  2022-09-19 13:16 ` [PR PATCH] [Updated] " freddylist
                   ` (13 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-09-19 13:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2172 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251001665

Comment:
> I think it's better to patch their Makefile to have let's say -include config.mk and put the option there. Whoever want some custom option could put the config into files directory. With that approach, we won't need to care for nnn's change in build option whatsoever. As for build dependencies, just add them all. nnn is always a leaf (as in graph) packages.

Here is possible implementation, no build options required:
```diff
 srcpkgs/nnn/patches/config.patch | 11 +++++++++++
 srcpkgs/nnn/template             |  5 ++++-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/nnn/patches/config.patch b/srcpkgs/nnn/patches/config.patch
new file mode 100644
index 0000000000..e7d7238276
--- /dev/null
+++ b/srcpkgs/nnn/patches/config.patch
@@ -0,0 +1,11 @@
+--- a/Makefile
++++ b/Makefile
+@@ -36,6 +36,8 @@ O_GITSTATUS := 0 # add git status to det
+ O_NAMEFIRST := 0 # print file name first, add uid and guid to detail view
+ O_RESTOREPREVIEW := 0 # add preview pipe to close and restore preview pane
+ 
++-include config.mk
++
+ # convert targets to flags for backwards compatibility
+ ifneq ($(filter debug,$(MAKECMDGOALS)),)
+ 	O_DEBUG := 1
diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index cea82d3681..32f5fec3c1 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -5,7 +5,7 @@ revision=1
 build_style=gnu-makefile
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
-makedepends="ncurses-devel readline-devel"
+makedepends="ncurses-devel readline-devel gpm-devel pcre-devel"
 short_desc="Missing terminal file browser for X"
 maintainer="Dennis Kraus <kraus@posteo.de>"
 license="BSD-2-Clause"
@@ -22,6 +22,9 @@ pre_build() {
 	if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 		export LDLIBS=-lfts
 	fi
+	if [ -f "$FILESDIR/config.mk" ]; then
+		cp "$FILESDIR/config.mk" .
+	fi
 }
 
 post_install() {
```

Then:
```sh
mkdir -p srcpkgs/nnn/files
cat <<-EOF >srcpkgs/nnn/files/config.mk
O_ICONS := 1
EOF
```

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR PATCH] [Updated] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (26 preceding siblings ...)
  2022-09-19 13:14 ` sgn
@ 2022-09-19 13:16 ` freddylist
  2022-09-19 13:57 ` freddylist
                   ` (12 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 13:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

There is an updated pull request by freddylist against master on the void-packages repository

https://github.com/freddylist/void-packages nnn-buildopts
https://github.com/void-linux/void-packages/pull/39360

nnn: add build options
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc

---

`xlint` doesn't like my string on multiple lines.

A patch file from https://github.com/void-linux/void-packages/pull/39360.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-buildopts-39360.patch --]
[-- Type: text/x-diff, Size: 2299 bytes --]

From 1ae8e27e93539db9bb0a11a5b8de7a7b7ae8527a Mon Sep 17 00:00:00 2001
From: Freddy List <github@freddylist.xyz>
Date: Mon, 19 Sep 2022 10:33:34 +0200
Subject: [PATCH] nnn: add build options

---
 srcpkgs/nnn/template | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index cea82d368152..1cc0fa1e2cb4 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,11 +1,18 @@
 # Template file for 'nnn'
 pkgname=nnn
 version=4.6
-revision=1
+revision=2
 build_style=gnu-makefile
+make_build_args="O_PCRE=$(vopt_if pcre 1 0)
+ O_CTX8=$(vopt_if ctx8 1 0)
+ O_ICONS=$(vopt_if icons 1 0)
+ O_NERD=$(vopt_if nerdfont 1 0)
+ O_EMOJI=$(vopt_if emojis 1 0)
+ O_QSORT=$(vopt_if qsort 1 0)
+ O_MATCHFLTR=$(vopt_if matchfilter 1 0)"
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
-makedepends="ncurses-devel readline-devel"
+makedepends="ncurses-devel readline-devel $(vopt_if pcre pcre-devel)"
 short_desc="Missing terminal file browser for X"
 maintainer="Dennis Kraus <kraus@posteo.de>"
 license="BSD-2-Clause"
@@ -14,6 +21,28 @@ changelog="https://raw.githubusercontent.com/jarun/nnn/master/CHANGELOG"
 distfiles="https://github.com/jarun/nnn/archive/v${version}.tar.gz"
 checksum=15acaf9a88cfb5a2a640d3ef55a48af644fba92b46aac0768efe94c4addf7e3f
 
+build_options="pcre
+ icons
+ nerdfont
+ emojis
+ qsort
+ ctx8
+ matchfilter"
+
+# See https://github.com/jarun/nnn/wiki/Developer-guides#make-options
+desc_option_pcre="PCRE instead of POSIX regex"
+desc_option_icons="icons-in-terminal support, not compatible with set nerdfont or emojis or unset locale"
+desc_option_nerdfont="Nerdfont icons, not compatible with set icons or emojis or unset locale"
+desc_option_emojis="Emoji icons, not compatible with set nerdfont or icons or unset locale"
+desc_option_qsort="Alexey Tourbin's QSORT"
+desc_option_ctx8="Enable 8 contexts, however, saved sessions may no longer be usable"
+desc_option_matchfilter="Matching filters only, discard filter key when there's no match"
+
+# Following are mutually exclusive
+vopt_conflict icons nerdfont
+vopt_conflict nerdfont emojis
+vopt_conflict emojis icons
+
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 	makedepends+=" musl-fts-devel"
 fi

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (27 preceding siblings ...)
  2022-09-19 13:16 ` [PR PATCH] [Updated] " freddylist
@ 2022-09-19 13:57 ` freddylist
  2022-09-19 13:58 ` freddylist
                   ` (11 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 13:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251057088

Comment:
I've removed the option for static linking.

I also tried to cross-compile for x86_64-musl, but the makefile fails here:

https://github.com/jarun/nnn/blob/0988268a61b4b4f040756821e2992ead7c6a01cf/Makefile#L210-L213

with this:

```
/bin/sh: line 1: ./src/icons-hash-gen: No such file or directory
make: *** [Makefile:211: src/icons-generated.h] Error 127
```

But if I look in the builddir for `nnn`, the `src/icons-hash-gen` file is there (with necessary permissions)...

If I try again without cleaning, I get different errors because of whacky definitions.

I will just hope this is just a problem with cross-compiling for me. 😁 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (28 preceding siblings ...)
  2022-09-19 13:57 ` freddylist
@ 2022-09-19 13:58 ` freddylist
  2022-09-19 13:59 ` freddylist
                   ` (10 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 13:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251057088

Comment:
I've removed the option for static linking.

I also tried to cross-compile for x86_64-musl, but the makefile fails [here](https://github.com/jarun/nnn/blob/0988268a61b4b4f040756821e2992ead7c6a01cf/Makefile#L210-L213) with this:

```
/bin/sh: line 1: ./src/icons-hash-gen: No such file or directory
make: *** [Makefile:211: src/icons-generated.h] Error 127
```

But if I look in the builddir for `nnn`, the `src/icons-hash-gen` file is there (with necessary permissions)...

If I try again without cleaning, I get different errors because of whacky definitions.

I will just hope this is just a problem with cross-compiling for me. 😁 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (29 preceding siblings ...)
  2022-09-19 13:58 ` freddylist
@ 2022-09-19 13:59 ` freddylist
  2022-09-19 14:08 ` freddylist
                   ` (9 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 13:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251057088

Comment:
I've removed the option for static linking.

I also tried to cross-compile for x86_64-musl with icon support, but the makefile fails [here](https://github.com/jarun/nnn/blob/0988268a61b4b4f040756821e2992ead7c6a01cf/Makefile#L210-L213) with this:

```
/bin/sh: line 1: ./src/icons-hash-gen: No such file or directory
make: *** [Makefile:211: src/icons-generated.h] Error 127
```

However, if I look in the builddir for `nnn`, the `src/icons-hash-gen` file is there (with necessary permissions)...

If I try again without cleaning, I get different errors because of whacky definitions.

Cross-compiling without icon support works fine.

I will just hope this is just a problem with cross-compiling for me. 😁 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (30 preceding siblings ...)
  2022-09-19 13:59 ` freddylist
@ 2022-09-19 14:08 ` freddylist
  2022-09-19 16:26 ` freddylist
                   ` (8 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 14:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1250994509

Comment:
> Is there a reason why we can't just unconditionally enable the features?

You have to choose between [icons-in-terminal](https://github.com/sebastiencs/icons-in-terminal), nerd font icons, or emojis. They are mutually exclusive, according to [this](https://github.com/jarun/nnn/wiki/Developer-guides#compile-in-icons-in-terminal).

The build option that enables 8 contexts (as opposed to 4) might break sessions according to [this](https://github.com/jarun/nnn/wiki/Developer-guides#compile-in-8-contexts).

> > as well as the build option that compiles nnn with static linking, but maybe it's still too much?
>
> remove that, there is no reason to have it in void-packages

I just saw this, will remove. 👍 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (31 preceding siblings ...)
  2022-09-19 14:08 ` freddylist
@ 2022-09-19 16:26 ` freddylist
  2022-09-19 19:12 ` freddylist
                   ` (7 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 16:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251057088

Comment:
I've removed the option for static linking.

<strike>

I also tried to cross-compile for x86_64-musl with icon support, but the makefile fails [here](https://github.com/jarun/nnn/blob/0988268a61b4b4f040756821e2992ead7c6a01cf/Makefile#L210-L213) with this:

```
/bin/sh: line 1: ./src/icons-hash-gen: No such file or directory
make: *** [Makefile:211: src/icons-generated.h] Error 127
```

However, if I look in the builddir for `nnn`, the `src/icons-hash-gen` file is there (with necessary permissions)...

If I try again without cleaning, I get different errors because of whacky definitions.

Cross-compiling without icon support works fine.

I will just hope this is just a problem with cross-compiling for me. 😁

</strike>

Looks like it builds on for other platforms. 🤷 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (32 preceding siblings ...)
  2022-09-19 16:26 ` freddylist
@ 2022-09-19 19:12 ` freddylist
  2022-09-20  8:24 ` freddylist
                   ` (6 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-19 19:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1251057088

Comment:
I've removed the option for static linking.

<strike>

I also tried to cross-compile for x86_64-musl with icon support, but the makefile fails [here](https://github.com/jarun/nnn/blob/0988268a61b4b4f040756821e2992ead7c6a01cf/Makefile#L210-L213) with this:

```
/bin/sh: line 1: ./src/icons-hash-gen: No such file or directory
make: *** [Makefile:211: src/icons-generated.h] Error 127
```

However, if I look in the builddir for `nnn`, the `src/icons-hash-gen` file is there (with necessary permissions)...

If I try again without cleaning, I get different errors because of whacky definitions.

Cross-compiling without icon support works fine.

I will just hope this is just a problem with cross-compiling for me. 😁

</strike>

Looks like it builds for other platforms. 🤷 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (33 preceding siblings ...)
  2022-09-19 19:12 ` freddylist
@ 2022-09-20  8:24 ` freddylist
  2022-09-20  8:31 ` freddylist
                   ` (5 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-20  8:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1252010633

Comment:
> Just want to show that I'm opposing to build_options.

Do any other Void packages do what you're proposing? And again, where is or would it be documented? `xbps-src` may be simple enough so that you can document it as a comment in the template file and users can just inspect the template file, but that goes a little too far in my opinion.

As for user submitted patches, again, users can just download the correct patches for their `nnn` version and drop them into the `patches/` directory.

Also, this might have to be maintained *more* than build options; the makefile [changes](https://github.com/jarun/nnn/commits/master/Makefile), but the few build options that compile in features are more-or-less permanent.

For users who want more build options, maybe there should be a link back to the makefile patch in the template?

All I want are my delicious `nnn` icons. 🤤 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (34 preceding siblings ...)
  2022-09-20  8:24 ` freddylist
@ 2022-09-20  8:31 ` freddylist
  2022-09-20  8:32 ` freddylist
                   ` (4 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-20  8:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1252010633

Comment:
> Just want to show that I'm opposing to build_options.

Do any other Void packages do what you're proposing? And again, where is or would it be documented? `xbps-src` may be simple enough so that you can document it as a comment in the template file and users can just inspect the template file, but that goes a little too far in my opinion. If we do this for `nnn`, should we do something like this for other similarly minimal software?

As for user submitted patches, again, users can just download the correct patches for their `nnn` version and drop them into the `patches/` directory.

Also, this might have to be maintained *more* than build options; makefiles [changes](https://github.com/jarun/nnn/commits/master/Makefile), but build options are more-or-less permanent.

For users who want more build options, maybe there should be a link back to the makefile patch in the template?

All I want are my delicious `nnn` icons. 🤤 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (35 preceding siblings ...)
  2022-09-20  8:31 ` freddylist
@ 2022-09-20  8:32 ` freddylist
  2022-09-20  8:37 ` [PR REVIEW] " freddylist
                   ` (3 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-20  8:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

New comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1252010633

Comment:
> Just want to show that I'm opposing to build_options.

Do any other Void packages do what you're proposing? And again, where is or would it be documented? `xbps-src` may be simple enough so that you can document it as a comment in the template file and users can just inspect the template file, but that goes a little too far in my opinion. If we do this for `nnn`, should we do something like this for other similarly minimal software?

As for user submitted patches, again, users can just download the correct patches for their `nnn` version and drop them into the `patches/` directory.

Also, this might have to be maintained *more* than build options; makefiles [change](https://github.com/jarun/nnn/commits/master/Makefile), but build options are more-or-less permanent.

For users who want more build options, maybe there should be a link back to the makefile patch in the template?

All I want are my delicious `nnn` icons. 🤤 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR REVIEW] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (36 preceding siblings ...)
  2022-09-20  8:32 ` freddylist
@ 2022-09-20  8:37 ` freddylist
  2022-09-30 13:03 ` [PR PATCH] [Updated] " freddylist
                   ` (2 subsequent siblings)
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-20  8:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by freddylist on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#discussion_r975053352

Comment:
Not anymore...

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR PATCH] [Updated] nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (37 preceding siblings ...)
  2022-09-20  8:37 ` [PR REVIEW] " freddylist
@ 2022-09-30 13:03 ` freddylist
  2022-12-05 19:47 ` [PR PATCH] [Closed]: " freddylist
  2022-12-06  0:01 ` sgn
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-09-30 13:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

There is an updated pull request by freddylist against master on the void-packages repository

https://github.com/freddylist/void-packages nnn-buildopts
https://github.com/void-linux/void-packages/pull/39360

nnn: add build options
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc

---

~~`xlint` doesn't like my string on multiple lines.~~

A patch file from https://github.com/void-linux/void-packages/pull/39360.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nnn-buildopts-39360.patch --]
[-- Type: text/x-diff, Size: 2299 bytes --]

From 1ae8e27e93539db9bb0a11a5b8de7a7b7ae8527a Mon Sep 17 00:00:00 2001
From: Freddy List <github@freddylist.xyz>
Date: Mon, 19 Sep 2022 10:33:34 +0200
Subject: [PATCH] nnn: add build options

---
 srcpkgs/nnn/template | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nnn/template b/srcpkgs/nnn/template
index cea82d368152..1cc0fa1e2cb4 100644
--- a/srcpkgs/nnn/template
+++ b/srcpkgs/nnn/template
@@ -1,11 +1,18 @@
 # Template file for 'nnn'
 pkgname=nnn
 version=4.6
-revision=1
+revision=2
 build_style=gnu-makefile
+make_build_args="O_PCRE=$(vopt_if pcre 1 0)
+ O_CTX8=$(vopt_if ctx8 1 0)
+ O_ICONS=$(vopt_if icons 1 0)
+ O_NERD=$(vopt_if nerdfont 1 0)
+ O_EMOJI=$(vopt_if emojis 1 0)
+ O_QSORT=$(vopt_if qsort 1 0)
+ O_MATCHFLTR=$(vopt_if matchfilter 1 0)"
 make_install_target="install install-desktop"
 hostmakedepends="pkg-config"
-makedepends="ncurses-devel readline-devel"
+makedepends="ncurses-devel readline-devel $(vopt_if pcre pcre-devel)"
 short_desc="Missing terminal file browser for X"
 maintainer="Dennis Kraus <kraus@posteo.de>"
 license="BSD-2-Clause"
@@ -14,6 +21,28 @@ changelog="https://raw.githubusercontent.com/jarun/nnn/master/CHANGELOG"
 distfiles="https://github.com/jarun/nnn/archive/v${version}.tar.gz"
 checksum=15acaf9a88cfb5a2a640d3ef55a48af644fba92b46aac0768efe94c4addf7e3f
 
+build_options="pcre
+ icons
+ nerdfont
+ emojis
+ qsort
+ ctx8
+ matchfilter"
+
+# See https://github.com/jarun/nnn/wiki/Developer-guides#make-options
+desc_option_pcre="PCRE instead of POSIX regex"
+desc_option_icons="icons-in-terminal support, not compatible with set nerdfont or emojis or unset locale"
+desc_option_nerdfont="Nerdfont icons, not compatible with set icons or emojis or unset locale"
+desc_option_emojis="Emoji icons, not compatible with set nerdfont or icons or unset locale"
+desc_option_qsort="Alexey Tourbin's QSORT"
+desc_option_ctx8="Enable 8 contexts, however, saved sessions may no longer be usable"
+desc_option_matchfilter="Matching filters only, discard filter key when there's no match"
+
+# Following are mutually exclusive
+vopt_conflict icons nerdfont
+vopt_conflict nerdfont emojis
+vopt_conflict emojis icons
+
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 	makedepends+=" musl-fts-devel"
 fi

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [PR PATCH] [Closed]: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (38 preceding siblings ...)
  2022-09-30 13:03 ` [PR PATCH] [Updated] " freddylist
@ 2022-12-05 19:47 ` freddylist
  2022-12-06  0:01 ` sgn
  40 siblings, 0 replies; 42+ messages in thread
From: freddylist @ 2022-12-05 19:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

There's a closed pull request on the void-packages repository

nnn: add build options
https://github.com/void-linux/void-packages/pull/39360

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc

---

~~`xlint` doesn't like my string on multiple lines.~~

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: nnn: add build options
  2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
                   ` (39 preceding siblings ...)
  2022-12-05 19:47 ` [PR PATCH] [Closed]: " freddylist
@ 2022-12-06  0:01 ` sgn
  40 siblings, 0 replies; 42+ messages in thread
From: sgn @ 2022-12-06  0:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39360#issuecomment-1338386029

Comment:
See st, dwm

^ permalink raw reply	[flat|nested] 42+ messages in thread

end of thread, other threads:[~2022-12-06  0:01 UTC | newest]

Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19  8:48 [PR PATCH] nnn: add build options freddylist
2022-09-19 10:32 ` [PR REVIEW] " classabbyamp
2022-09-19 10:34 ` classabbyamp
2022-09-19 10:38 ` classabbyamp
2022-09-19 10:39 ` [PR REVIEW] " classabbyamp
2022-09-19 10:40 ` freddylist
2022-09-19 10:43 ` freddylist
2022-09-19 10:46 ` freddylist
2022-09-19 10:48 ` freddylist
2022-09-19 10:53 ` freddylist
2022-09-19 10:54 ` sgn
2022-09-19 10:57 ` freddylist
2022-09-19 10:58 ` sgn
2022-09-19 11:00 ` sgn
2022-09-19 11:32 ` paper42
2022-09-19 11:59 ` freddylist
2022-09-19 12:33 ` [PR PATCH] [Updated] " freddylist
2022-09-19 12:39 ` freddylist
2022-09-19 12:40 ` paper42
2022-09-19 12:49 ` sgn
2022-09-19 12:51 ` sgn
2022-09-19 12:54 ` [PR PATCH] [Updated] " freddylist
2022-09-19 13:06 ` freddylist
2022-09-19 13:10 ` freddylist
2022-09-19 13:12 ` sgn
2022-09-19 13:12 ` sgn
2022-09-19 13:13 ` freddylist
2022-09-19 13:14 ` sgn
2022-09-19 13:16 ` [PR PATCH] [Updated] " freddylist
2022-09-19 13:57 ` freddylist
2022-09-19 13:58 ` freddylist
2022-09-19 13:59 ` freddylist
2022-09-19 14:08 ` freddylist
2022-09-19 16:26 ` freddylist
2022-09-19 19:12 ` freddylist
2022-09-20  8:24 ` freddylist
2022-09-20  8:31 ` freddylist
2022-09-20  8:32 ` freddylist
2022-09-20  8:37 ` [PR REVIEW] " freddylist
2022-09-30 13:03 ` [PR PATCH] [Updated] " freddylist
2022-12-05 19:47 ` [PR PATCH] [Closed]: " freddylist
2022-12-06  0:01 ` sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).