Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [WIP] New package: dooble-2022.06.15
@ 2022-09-21 18:17 Eloitor
  2022-09-21 18:21 ` [PR PATCH] [Updated] " Eloitor
                   ` (13 more replies)
  0 siblings, 14 replies; 15+ messages in thread
From: Eloitor @ 2022-09-21 18:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

There is a new pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/39405

[WIP] New package: dooble-2022.06.15
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/39405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-39405.patch --]
[-- Type: text/x-diff, Size: 1197 bytes --]

From 82c9f09a8b42c0e898606eaeda18f2a399c1cca5 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <elotor@disroot.org>
Date: Mon, 19 Sep 2022 10:49:24 +0200
Subject: [PATCH] New package: dooble-2022.06.15

dooble: update to 2022.06.15.
---
 srcpkgs/dooble/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/dooble/template

diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
new file mode 100644
index 000000000000..129351a16d53
--- /dev/null
+++ b/srcpkgs/dooble/template
@@ -0,0 +1,18 @@
+# Template file for 'dooble'
+pkgname=dooble
+version=2022.06.15
+revision=1
+build_style=qmake
+configure_args="dooble.pro"
+hostmakedepends="qt5-qmake"
+makedepends="qt5-charts-devel qt5-webengine-devel qt5-webchannel-devel qt5-location-devel"
+short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
+maintainer="Eloi Torrents <elotor@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://textbrowser.github.io/dooble/"
+distfiles="https://github.com/textbrowser/dooble/archive/refs/tags/${version}.tar.gz"
+checksum=3af9a06c477f9317cf279389bd66237109fa205fb5526f4df7909250dc2c8e41
+
+do_install() {
+    vbin Dooble
+  }

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
@ 2022-09-21 18:21 ` Eloitor
  2022-09-21 18:37 ` Eloitor
                   ` (12 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Eloitor @ 2022-09-21 18:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/39405

[WIP] New package: dooble-2022.06.15
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/39405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-39405.patch --]
[-- Type: text/x-diff, Size: 1192 bytes --]

From 75aab4f077d38ac293a3bbaa2ce7628d4f17d0e7 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <elotor@disroot.org>
Date: Mon, 19 Sep 2022 10:49:24 +0200
Subject: [PATCH] New package: dooble-2022.06.15

dooble: update to 2022.06.15.
---
 srcpkgs/dooble/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/dooble/template

diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
new file mode 100644
index 000000000000..11fcfdc44519
--- /dev/null
+++ b/srcpkgs/dooble/template
@@ -0,0 +1,18 @@
+# Template file for 'dooble'
+pkgname=dooble
+version=2022.06.15
+revision=1
+build_style=qmake
+configure_args="dooble.pro"
+hostmakedepends="qt5-qmake"
+makedepends="qt5-charts-devel qt5-webengine-devel qt5-webchannel-devel qt5-location-devel"
+short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
+maintainer="Eloi Torrents <elotor@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://textbrowser.github.io/dooble/"
+distfiles="https://github.com/textbrowser/dooble/archive/refs/tags/${version}.tar.gz"
+checksum=3af9a06c477f9317cf279389bd66237109fa205fb5526f4df7909250dc2c8e41
+
+do_install() {
+	vbin Dooble
+}

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
  2022-09-21 18:21 ` [PR PATCH] [Updated] " Eloitor
@ 2022-09-21 18:37 ` Eloitor
  2022-09-21 23:03 ` [PR REVIEW] " classabbyamp
                   ` (11 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Eloitor @ 2022-09-21 18:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/39405

[WIP] New package: dooble-2022.06.15
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/39405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-39405.patch --]
[-- Type: text/x-diff, Size: 1192 bytes --]

From d2f8ee3187b5249278018e6e970daa12a1ee0a44 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <elotor@disroot.org>
Date: Mon, 19 Sep 2022 10:49:24 +0200
Subject: [PATCH] New package: dooble-2022.06.15

dooble: update to 2022.06.15.
---
 srcpkgs/dooble/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/dooble/template

diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
new file mode 100644
index 000000000000..11fcfdc44519
--- /dev/null
+++ b/srcpkgs/dooble/template
@@ -0,0 +1,18 @@
+# Template file for 'dooble'
+pkgname=dooble
+version=2022.06.15
+revision=1
+build_style=qmake
+configure_args="dooble.pro"
+hostmakedepends="qt5-qmake"
+makedepends="qt5-charts-devel qt5-webengine-devel qt5-webchannel-devel qt5-location-devel"
+short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
+maintainer="Eloi Torrents <elotor@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://textbrowser.github.io/dooble/"
+distfiles="https://github.com/textbrowser/dooble/archive/refs/tags/${version}.tar.gz"
+checksum=3af9a06c477f9317cf279389bd66237109fa205fb5526f4df7909250dc2c8e41
+
+do_install() {
+	vbin Dooble
+}

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (2 preceding siblings ...)
  2022-09-21 23:03 ` [PR REVIEW] " classabbyamp
@ 2022-09-21 23:03 ` classabbyamp
  2022-09-22 14:02 ` [PR PATCH] [Updated] " Eloitor
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-09-21 23:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r977037211

Comment:
[BSD-3-Clause](https://github.com/textbrowser/dooble/blob/master/LICENSE)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
  2022-09-21 18:21 ` [PR PATCH] [Updated] " Eloitor
  2022-09-21 18:37 ` Eloitor
@ 2022-09-21 23:03 ` classabbyamp
  2022-09-21 23:03 ` classabbyamp
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-09-21 23:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r977051797

Comment:
based on the [AUR package](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=dooble):
```suggestion
	vbin Dooble dooble
	vinstall dooble.desktop 644 usr/share/applications
	vinstall Icons/Logo/dooble.png 644 usr/share/pixmaps
	vlicense LICENSE
```
(renamed the bin file so it plays nice with the desktop file)

would be nice to also add the translations, but it seems to assume they're in `$PWD/Translations`. might be something to bring up with the upstream.
```
	vmkdir usr/share/dooble/Translations
	vcopy "Translations/dooble_*.qm" usr/share/dooble/Translations
```

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (3 preceding siblings ...)
  2022-09-21 23:03 ` classabbyamp
@ 2022-09-22 14:02 ` Eloitor
  2022-09-22 14:04 ` [PR REVIEW] " Eloitor
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Eloitor @ 2022-09-22 14:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/39405

[WIP] New package: dooble-2022.06.15
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/39405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-39405.patch --]
[-- Type: text/x-diff, Size: 1325 bytes --]

From 8c9ab49bee0b7158aba2062ac6c211b1987e9840 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <elotor@disroot.org>
Date: Mon, 19 Sep 2022 10:49:24 +0200
Subject: [PATCH] New package: dooble-2022.06.15

dooble: update to 2022.06.15.
---
 srcpkgs/dooble/template | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 srcpkgs/dooble/template

diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
new file mode 100644
index 000000000000..e715b633af67
--- /dev/null
+++ b/srcpkgs/dooble/template
@@ -0,0 +1,21 @@
+# Template file for 'dooble'
+pkgname=dooble
+version=2022.06.15
+revision=1
+build_style=qmake
+configure_args="dooble.pro"
+hostmakedepends="qt5-qmake"
+makedepends="qt5-charts-devel qt5-webengine-devel qt5-webchannel-devel qt5-location-devel"
+short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
+maintainer="Eloi Torrents <elotor@disroot.org>"
+license="BSD-3-Clause"
+homepage="https://textbrowser.github.io/dooble/"
+distfiles="https://github.com/textbrowser/dooble/archive/refs/tags/${version}.tar.gz"
+checksum=3af9a06c477f9317cf279389bd66237109fa205fb5526f4df7909250dc2c8e41
+
+do_install() {
+	vbin Dooble dooble
+	vinstall dooble.desktop 644 usr/share/applications
+	vinstall Icons/Logo/dooble.png 644 usr/share/pixmaps
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (4 preceding siblings ...)
  2022-09-22 14:02 ` [PR PATCH] [Updated] " Eloitor
@ 2022-09-22 14:04 ` Eloitor
  2022-09-23 11:58 ` sgn
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Eloitor @ 2022-09-22 14:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r977699839

Comment:
Thank you I'll take a look at it and open an issue upstream

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (5 preceding siblings ...)
  2022-09-22 14:04 ` [PR REVIEW] " Eloitor
@ 2022-09-23 11:58 ` sgn
  2022-09-23 13:17 ` sgn
                   ` (6 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: sgn @ 2022-09-23 11:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r978558514

Comment:
Patch this file: https://github.com/textbrowser/dooble/blob/94498e29d616de51287e752c57e287dcdccdc578/Source/dooble_application.cc#L81

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (6 preceding siblings ...)
  2022-09-23 11:58 ` sgn
@ 2022-09-23 13:17 ` sgn
  2022-09-23 21:17 ` [PR PATCH] [Updated] " Eloitor
                   ` (5 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: sgn @ 2022-09-23 13:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r978648524

Comment:
Here is the patch:
```diff
--- dooble_application.cc.orig	2022-09-23 20:15:31.021472658 +0700
+++ dooble_application.cc	2022-09-23 20:16:49.754946070 +0700
@@ -81,9 +81,7 @@
 
       if(path.isEmpty())
 	ok = m_translator->load("dooble_" + QLocale::system().name(),
-				QDir::currentPath() +
-				QDir::separator() +
-				"Translations");
+				"/usr/share/dooble/translations");
       else
 	ok = m_translator->load("dooble_" + QLocale::system().name(), path);
 

```

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (7 preceding siblings ...)
  2022-09-23 13:17 ` sgn
@ 2022-09-23 21:17 ` Eloitor
  2022-09-23 21:28 ` [PR REVIEW] " Eloitor
                   ` (4 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Eloitor @ 2022-09-23 21:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/39405

[WIP] New package: dooble-2022.06.15
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/39405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-39405.patch --]
[-- Type: text/x-diff, Size: 2130 bytes --]

From 68315e822b1a32d5334246fc950918dce9208639 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <elotor@disroot.org>
Date: Mon, 19 Sep 2022 10:49:24 +0200
Subject: [PATCH] New package: dooble-2022.06.15

dooble: update to 2022.06.15.

dooble: update to 2022.06.15.
---
 srcpkgs/dooble/template           | 21 +++++++++++++++++++++
 srcpkgs/dooble/translations.patch | 12 ++++++++++++
 2 files changed, 33 insertions(+)
 create mode 100644 srcpkgs/dooble/template
 create mode 100644 srcpkgs/dooble/translations.patch

diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
new file mode 100644
index 000000000000..e715b633af67
--- /dev/null
+++ b/srcpkgs/dooble/template
@@ -0,0 +1,21 @@
+# Template file for 'dooble'
+pkgname=dooble
+version=2022.06.15
+revision=1
+build_style=qmake
+configure_args="dooble.pro"
+hostmakedepends="qt5-qmake"
+makedepends="qt5-charts-devel qt5-webengine-devel qt5-webchannel-devel qt5-location-devel"
+short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
+maintainer="Eloi Torrents <elotor@disroot.org>"
+license="BSD-3-Clause"
+homepage="https://textbrowser.github.io/dooble/"
+distfiles="https://github.com/textbrowser/dooble/archive/refs/tags/${version}.tar.gz"
+checksum=3af9a06c477f9317cf279389bd66237109fa205fb5526f4df7909250dc2c8e41
+
+do_install() {
+	vbin Dooble dooble
+	vinstall dooble.desktop 644 usr/share/applications
+	vinstall Icons/Logo/dooble.png 644 usr/share/pixmaps
+	vlicense LICENSE
+}
diff --git a/srcpkgs/dooble/translations.patch b/srcpkgs/dooble/translations.patch
new file mode 100644
index 000000000000..d10c51bfdc73
--- /dev/null
+++ b/srcpkgs/dooble/translations.patch
@@ -0,0 +1,12 @@
+--- dooble_application.cc.orig	2022-09-23 20:15:31.021472658 +0700
++++ dooble_application.cc	2022-09-23 20:16:49.754946070 +0700
+@@ -81,9 +81,7 @@
+ 
+       if(path.isEmpty())
+ 	ok = m_translator->load("dooble_" + QLocale::system().name(),
+-				QDir::currentPath() +
+-				QDir::separator() +
+-				"Translations");
++				"/usr/share/dooble/translations");
+       else
+ 	ok = m_translator->load("dooble_" + QLocale::system().name(), path);

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (8 preceding siblings ...)
  2022-09-23 21:17 ` [PR PATCH] [Updated] " Eloitor
@ 2022-09-23 21:28 ` Eloitor
  2022-09-23 21:35 ` classabbyamp
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: Eloitor @ 2022-09-23 21:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by Eloitor on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r979075318

Comment:
Thank you!!!!!!!

Now only the aarch64 builds give problems...

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (9 preceding siblings ...)
  2022-09-23 21:28 ` [PR REVIEW] " Eloitor
@ 2022-09-23 21:35 ` classabbyamp
  2022-09-23 21:36 ` classabbyamp
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-09-23 21:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r979078366

Comment:
don't forget to install the translations too
```
	vmkdir usr/share/dooble/Translations
	vcopy "Translations/dooble_*.qm" usr/share/dooble/translations
```

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (10 preceding siblings ...)
  2022-09-23 21:35 ` classabbyamp
@ 2022-09-23 21:36 ` classabbyamp
  2022-09-23 21:40 ` [PR PATCH] [Updated] " Eloitor
  2022-09-24  9:53 ` [PR REVIEW] " sgn
  13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-09-23 21:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r979078890

Comment:
> Now only the aarch64 builds give problems...

add qt5-host-tools to hostmakedepends

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR PATCH] [Updated] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (11 preceding siblings ...)
  2022-09-23 21:36 ` classabbyamp
@ 2022-09-23 21:40 ` Eloitor
  2022-09-24  9:53 ` [PR REVIEW] " sgn
  13 siblings, 0 replies; 15+ messages in thread
From: Eloitor @ 2022-09-23 21:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is an updated pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages dooble
https://github.com/void-linux/void-packages/pull/39405

[WIP] New package: dooble-2022.06.15
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/39405.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dooble-39405.patch --]
[-- Type: text/x-diff, Size: 2282 bytes --]

From bee2460424b3d3aae2a91efe6562e698d795a1d7 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <elotor@disroot.org>
Date: Mon, 19 Sep 2022 10:49:24 +0200
Subject: [PATCH] New package: dooble-2022.06.15

dooble: update to 2022.06.15.

dooble: update to 2022.06.15.

dooble: update to 2022.06.15.
---
 srcpkgs/dooble/template           | 23 +++++++++++++++++++++++
 srcpkgs/dooble/translations.patch | 12 ++++++++++++
 2 files changed, 35 insertions(+)
 create mode 100644 srcpkgs/dooble/template
 create mode 100644 srcpkgs/dooble/translations.patch

diff --git a/srcpkgs/dooble/template b/srcpkgs/dooble/template
new file mode 100644
index 000000000000..fdedd028dafb
--- /dev/null
+++ b/srcpkgs/dooble/template
@@ -0,0 +1,23 @@
+# Template file for 'dooble'
+pkgname=dooble
+version=2022.06.15
+revision=1
+build_style=qmake
+configure_args="dooble.pro"
+hostmakedepends="qt5-qmake qt5-host-tools"
+makedepends="qt5-charts-devel qt5-webengine-devel qt5-webchannel-devel qt5-location-devel"
+short_desc="Dooble, the scientific browser. Minimal, cute, and unusually stable"
+maintainer="Eloi Torrents <elotor@disroot.org>"
+license="BSD-3-Clause"
+homepage="https://textbrowser.github.io/dooble/"
+distfiles="https://github.com/textbrowser/dooble/archive/refs/tags/${version}.tar.gz"
+checksum=3af9a06c477f9317cf279389bd66237109fa205fb5526f4df7909250dc2c8e41
+
+do_install() {
+	vbin Dooble dooble
+	vinstall dooble.desktop 644 usr/share/applications
+	vinstall Icons/Logo/dooble.png 644 usr/share/pixmaps
+	vlicense LICENSE
+	vmkdir usr/share/dooble/Translations
+	vcopy "Translations/dooble_*.qm" usr/share/dooble/translations
+}
diff --git a/srcpkgs/dooble/translations.patch b/srcpkgs/dooble/translations.patch
new file mode 100644
index 000000000000..d10c51bfdc73
--- /dev/null
+++ b/srcpkgs/dooble/translations.patch
@@ -0,0 +1,12 @@
+--- dooble_application.cc.orig	2022-09-23 20:15:31.021472658 +0700
++++ dooble_application.cc	2022-09-23 20:16:49.754946070 +0700
+@@ -81,9 +81,7 @@
+ 
+       if(path.isEmpty())
+ 	ok = m_translator->load("dooble_" + QLocale::system().name(),
+-				QDir::currentPath() +
+-				QDir::separator() +
+-				"Translations");
++				"/usr/share/dooble/translations");
+       else
+ 	ok = m_translator->load("dooble_" + QLocale::system().name(), path);

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PR REVIEW] [WIP] New package: dooble-2022.06.15
  2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
                   ` (12 preceding siblings ...)
  2022-09-23 21:40 ` [PR PATCH] [Updated] " Eloitor
@ 2022-09-24  9:53 ` sgn
  13 siblings, 0 replies; 15+ messages in thread
From: sgn @ 2022-09-24  9:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/39405#discussion_r979215111

Comment:
Add `qt5-webengine` to `hostmakedepends`

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2022-09-24  9:53 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-21 18:17 [PR PATCH] [WIP] New package: dooble-2022.06.15 Eloitor
2022-09-21 18:21 ` [PR PATCH] [Updated] " Eloitor
2022-09-21 18:37 ` Eloitor
2022-09-21 23:03 ` [PR REVIEW] " classabbyamp
2022-09-21 23:03 ` classabbyamp
2022-09-22 14:02 ` [PR PATCH] [Updated] " Eloitor
2022-09-22 14:04 ` [PR REVIEW] " Eloitor
2022-09-23 11:58 ` sgn
2022-09-23 13:17 ` sgn
2022-09-23 21:17 ` [PR PATCH] [Updated] " Eloitor
2022-09-23 21:28 ` [PR REVIEW] " Eloitor
2022-09-23 21:35 ` classabbyamp
2022-09-23 21:36 ` classabbyamp
2022-09-23 21:40 ` [PR PATCH] [Updated] " Eloitor
2022-09-24  9:53 ` [PR REVIEW] " sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).