* Re: [PR REVIEW] libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
2022-09-30 19:41 [PR PATCH] libnvidia-container, nvidia-container-toolkit: update to 1.11.0 quentin-z80
@ 2022-09-30 19:42 ` classabbyamp
2022-09-30 19:56 ` [PR PATCH] [Updated] " quentin-z80
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-09-30 19:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39551#discussion_r984900836
Comment:
if the soname didn't change, this should not be bumped (it's the minimum version that provides the shlib)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Updated] libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
2022-09-30 19:41 [PR PATCH] libnvidia-container, nvidia-container-toolkit: update to 1.11.0 quentin-z80
2022-09-30 19:42 ` [PR REVIEW] " classabbyamp
@ 2022-09-30 19:56 ` quentin-z80
2022-09-30 19:57 ` [PR REVIEW] " quentin-z80
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: quentin-z80 @ 2022-09-30 19:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
There is an updated pull request by quentin-z80 against master on the void-packages repository
https://github.com/quentin-z80/void-packages nvidia-docker
https://github.com/void-linux/void-packages/pull/39551
libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
#### Local build testing
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39551.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nvidia-docker-39551.patch --]
[-- Type: text/x-diff, Size: 3164 bytes --]
From a6aab9c8e92412b338b3841ef536b1951d3e9af7 Mon Sep 17 00:00:00 2001
From: Quentin Freimanis <quentinfreimanis@gmail.com>
Date: Fri, 30 Sep 2022 12:37:40 -0700
Subject: [PATCH 1/2] libnvidia-container: update to 1.11.0.
---
srcpkgs/libnvidia-container/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/libnvidia-container/template b/srcpkgs/libnvidia-container/template
index 29cca16981f6..663482559ee4 100644
--- a/srcpkgs/libnvidia-container/template
+++ b/srcpkgs/libnvidia-container/template
@@ -1,6 +1,6 @@
# Template file for 'libnvidia-container'
pkgname=libnvidia-container
-version=1.10.0
+version=1.11.0
revision=1
archs="x86_64"
hostmakedepends="tar xz curl bmake groff m4 pkg-config which go"
@@ -10,7 +10,7 @@ maintainer="Quentin Freimanis <quentinfreimanis@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/NVIDIA/libnvidia-container"
distfiles="https://github.com/NVIDIA/libnvidia-container/archive/v${version}.tar.gz"
-checksum=418bdfa14d6339e21a401b945967945ff0b1e99a319783f84ee59a032ff7759d
+checksum=ff09fa96615d26b2484588bbd5a8e435fa9c2d931838c3de48c990892960d6b7
do_build() {
make dist prefix=/usr REVISION=${version}
From cf11907dd0876ffa4ef5f16ffc5246a9b9514fa5 Mon Sep 17 00:00:00 2001
From: Quentin Freimanis <quentinfreimanis@gmail.com>
Date: Fri, 30 Sep 2022 12:37:48 -0700
Subject: [PATCH 2/2] nvidia-container-toolkit: update to 1.11.0.
---
srcpkgs/nvidia-container-toolkit/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/nvidia-container-toolkit/template b/srcpkgs/nvidia-container-toolkit/template
index 99d6afdfb11c..caf694678ed0 100644
--- a/srcpkgs/nvidia-container-toolkit/template
+++ b/srcpkgs/nvidia-container-toolkit/template
@@ -1,11 +1,11 @@
# Template file for 'nvidia-container-toolkit'
pkgname=nvidia-container-toolkit
-version=1.10.0
+version=1.11.0
revision=1
archs="x86_64"
build_style=go
go_import_path=github.com/NVIDIA/nvidia-container-toolkit
-go_package="${go_import_path}/cmd/nvidia-container-toolkit
+go_package="${go_import_path}/cmd/nvidia-container-runtime-hook
${go_import_path}/cmd/nvidia-container-runtime
${go_import_path}/cmd/nvidia-ctk"
depends="libnvidia-container"
@@ -14,11 +14,11 @@ maintainer="Quentin Freimanis <quentinfreimanis@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/NVIDIA/nvidia-container-toolkit/"
distfiles="https://github.com/NVIDIA/nvidia-container-toolkit/archive/v${version}.tar.gz"
-checksum=7c88e6b16df92feac9a14f7ca7f2960409c71760b2563fea29c57c8799930db3
+checksum=016e20b3a1a59409da131817d84b9fc56eab72d3f69a9797bbf960f73c9e5262
post_install() {
- ln -sf /usr/bin/nvidia-container-toolkit ${DESTDIR}/usr/bin/nvidia-container-runtime-hook
+ ln -sf /usr/bin/nvidia-container-runtime-hook ${DESTDIR}/usr/bin/${pkgname}
vmkdir /etc/nvidia-container-runtime 755
- vinstall config/config.toml.centos 644 /etc/nvidia-container-runtime config.toml
+ vinstall config/config.toml.rpm-yum 644 /etc/nvidia-container-runtime config.toml
vinstall oci-nvidia-hook.json 644 /usr/share/containers/oci/hooks.d 00-oci-nvidia-hook.json
}
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR REVIEW] libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
2022-09-30 19:41 [PR PATCH] libnvidia-container, nvidia-container-toolkit: update to 1.11.0 quentin-z80
2022-09-30 19:42 ` [PR REVIEW] " classabbyamp
2022-09-30 19:56 ` [PR PATCH] [Updated] " quentin-z80
@ 2022-09-30 19:57 ` quentin-z80
2022-12-30 1:58 ` github-actions
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: quentin-z80 @ 2022-09-30 19:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 164 bytes --]
New review comment by quentin-z80 on void-packages repository
https://github.com/void-linux/void-packages/pull/39551#discussion_r984909687
Comment:
thanks, fixed
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
2022-09-30 19:41 [PR PATCH] libnvidia-container, nvidia-container-toolkit: update to 1.11.0 quentin-z80
` (2 preceding siblings ...)
2022-09-30 19:57 ` [PR REVIEW] " quentin-z80
@ 2022-12-30 1:58 ` github-actions
2023-01-07 14:21 ` classabbyamp
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2022-12-30 1:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/39551#issuecomment-1367681466
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
2022-09-30 19:41 [PR PATCH] libnvidia-container, nvidia-container-toolkit: update to 1.11.0 quentin-z80
` (3 preceding siblings ...)
2022-12-30 1:58 ` github-actions
@ 2023-01-07 14:21 ` classabbyamp
2023-01-08 3:26 ` [PR PATCH] [Updated] " quentin-z80
2023-01-08 16:13 ` [PR PATCH] [Merged]: " classabbyamp
6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2023-01-07 14:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39551#issuecomment-1374497105
Comment:
can you rebase on master for ci to run?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Updated] libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
2022-09-30 19:41 [PR PATCH] libnvidia-container, nvidia-container-toolkit: update to 1.11.0 quentin-z80
` (4 preceding siblings ...)
2023-01-07 14:21 ` classabbyamp
@ 2023-01-08 3:26 ` quentin-z80
2023-01-08 16:13 ` [PR PATCH] [Merged]: " classabbyamp
6 siblings, 0 replies; 8+ messages in thread
From: quentin-z80 @ 2023-01-08 3:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
There is an updated pull request by quentin-z80 against master on the void-packages repository
https://github.com/quentin-z80/void-packages nvidia-docker
https://github.com/void-linux/void-packages/pull/39551
libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
#### Local build testing
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39551.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nvidia-docker-39551.patch --]
[-- Type: text/x-diff, Size: 3164 bytes --]
From a4a535d45fb96e50ee63425a6bc14f692b8ee766 Mon Sep 17 00:00:00 2001
From: Quentin Freimanis <quentinfreimanis@gmail.com>
Date: Fri, 30 Sep 2022 12:37:40 -0700
Subject: [PATCH 1/2] libnvidia-container: update to 1.11.0.
---
srcpkgs/libnvidia-container/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/libnvidia-container/template b/srcpkgs/libnvidia-container/template
index 29cca16981f6..663482559ee4 100644
--- a/srcpkgs/libnvidia-container/template
+++ b/srcpkgs/libnvidia-container/template
@@ -1,6 +1,6 @@
# Template file for 'libnvidia-container'
pkgname=libnvidia-container
-version=1.10.0
+version=1.11.0
revision=1
archs="x86_64"
hostmakedepends="tar xz curl bmake groff m4 pkg-config which go"
@@ -10,7 +10,7 @@ maintainer="Quentin Freimanis <quentinfreimanis@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/NVIDIA/libnvidia-container"
distfiles="https://github.com/NVIDIA/libnvidia-container/archive/v${version}.tar.gz"
-checksum=418bdfa14d6339e21a401b945967945ff0b1e99a319783f84ee59a032ff7759d
+checksum=ff09fa96615d26b2484588bbd5a8e435fa9c2d931838c3de48c990892960d6b7
do_build() {
make dist prefix=/usr REVISION=${version}
From e64e5cc49ce9b41e9c6d6fd39cb61159e3c98fa9 Mon Sep 17 00:00:00 2001
From: Quentin Freimanis <quentinfreimanis@gmail.com>
Date: Fri, 30 Sep 2022 12:37:48 -0700
Subject: [PATCH 2/2] nvidia-container-toolkit: update to 1.11.0.
---
srcpkgs/nvidia-container-toolkit/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/nvidia-container-toolkit/template b/srcpkgs/nvidia-container-toolkit/template
index 99d6afdfb11c..caf694678ed0 100644
--- a/srcpkgs/nvidia-container-toolkit/template
+++ b/srcpkgs/nvidia-container-toolkit/template
@@ -1,11 +1,11 @@
# Template file for 'nvidia-container-toolkit'
pkgname=nvidia-container-toolkit
-version=1.10.0
+version=1.11.0
revision=1
archs="x86_64"
build_style=go
go_import_path=github.com/NVIDIA/nvidia-container-toolkit
-go_package="${go_import_path}/cmd/nvidia-container-toolkit
+go_package="${go_import_path}/cmd/nvidia-container-runtime-hook
${go_import_path}/cmd/nvidia-container-runtime
${go_import_path}/cmd/nvidia-ctk"
depends="libnvidia-container"
@@ -14,11 +14,11 @@ maintainer="Quentin Freimanis <quentinfreimanis@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/NVIDIA/nvidia-container-toolkit/"
distfiles="https://github.com/NVIDIA/nvidia-container-toolkit/archive/v${version}.tar.gz"
-checksum=7c88e6b16df92feac9a14f7ca7f2960409c71760b2563fea29c57c8799930db3
+checksum=016e20b3a1a59409da131817d84b9fc56eab72d3f69a9797bbf960f73c9e5262
post_install() {
- ln -sf /usr/bin/nvidia-container-toolkit ${DESTDIR}/usr/bin/nvidia-container-runtime-hook
+ ln -sf /usr/bin/nvidia-container-runtime-hook ${DESTDIR}/usr/bin/${pkgname}
vmkdir /etc/nvidia-container-runtime 755
- vinstall config/config.toml.centos 644 /etc/nvidia-container-runtime config.toml
+ vinstall config/config.toml.rpm-yum 644 /etc/nvidia-container-runtime config.toml
vinstall oci-nvidia-hook.json 644 /usr/share/containers/oci/hooks.d 00-oci-nvidia-hook.json
}
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Merged]: libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
2022-09-30 19:41 [PR PATCH] libnvidia-container, nvidia-container-toolkit: update to 1.11.0 quentin-z80
` (5 preceding siblings ...)
2023-01-08 3:26 ` [PR PATCH] [Updated] " quentin-z80
@ 2023-01-08 16:13 ` classabbyamp
6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2023-01-08 16:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
There's a merged pull request on the void-packages repository
libnvidia-container, nvidia-container-toolkit: update to 1.11.0.
https://github.com/void-linux/void-packages/pull/39551
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
#### Local build testing
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 8+ messages in thread