Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] hackrf: fix udev rules directory
@ 2022-10-02 20:21 motorto
  2022-10-02 20:25 ` [PR PATCH] [Updated] " motorto
                   ` (24 more replies)
  0 siblings, 25 replies; 26+ messages in thread
From: motorto @ 2022-10-02 20:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

There is a new pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 725 bytes --]

From 10586ecc402b7907e2be60da6668833a80ba9187 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 2 Oct 2022 21:18:42 +0100
Subject: [PATCH] hackrf: fix udev rules directory

---
 srcpkgs/hackrf/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9bd653451bb1..50e8c3fdac38 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
@ 2022-10-02 20:25 ` motorto
  2022-10-02 20:36 ` motorto
                   ` (23 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-02 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 930 bytes --]

From 5a98590f22b1e996d7c20316b83a49e2cb2c5a6a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 2 Oct 2022 21:18:42 +0100
Subject: [PATCH] hackrf: fix udev rules directory

---
 srcpkgs/hackrf/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9bd653451bb1..3afc52b4f683 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -28,7 +29,6 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
  2022-10-02 20:25 ` [PR PATCH] [Updated] " motorto
@ 2022-10-02 20:36 ` motorto
  2022-10-02 21:32 ` Piraty
                   ` (22 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-02 20:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 1035 bytes --]

From 1fc4b36f27580b582f1881b9e088c9d071f2610d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 2 Oct 2022 21:18:42 +0100
Subject: [PATCH] hackrf: fix udev rules directory

By default, it installs rules on /etc/udev/rules.d which is forbidden use
/usr/lib/udev/rules.d instead.
---
 srcpkgs/hackrf/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9bd653451bb1..3afc52b4f683 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -28,7 +29,6 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
  2022-10-02 20:25 ` [PR PATCH] [Updated] " motorto
  2022-10-02 20:36 ` motorto
@ 2022-10-02 21:32 ` Piraty
  2022-10-02 21:34 ` Piraty
                   ` (21 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: Piraty @ 2022-10-02 21:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1264737761

Comment:
ping @bra1nwave .

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (2 preceding siblings ...)
  2022-10-02 21:32 ` Piraty
@ 2022-10-02 21:34 ` Piraty
  2022-10-02 21:56 ` paper42
                   ` (20 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: Piraty @ 2022-10-02 21:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1264738106

Comment:
before
```
xbps-query -Rf libhackrf | grep udev
/usr/lib/udev/rules.d/53-hackrf.rules

xbps-query -Rf hackrf | grep udev

```

after
```
fd -t f rules masterdir/destdir
masterdir/destdir/hackrf-2021.03.1/usr/lib/udev/rules.d/53-hackrf.rules
```

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (3 preceding siblings ...)
  2022-10-02 21:34 ` Piraty
@ 2022-10-02 21:56 ` paper42
  2022-10-03  5:57 ` motorto
                   ` (19 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-10-02 21:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1264741549

Comment:
* previously it was in libhackrf, but you moved it to hackrf, this should be mentioned in the commit message
* a revbump is missing

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (4 preceding siblings ...)
  2022-10-02 21:56 ` paper42
@ 2022-10-03  5:57 ` motorto
  2022-10-03  6:00 ` [PR PATCH] [Updated] " motorto
                   ` (18 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-03  5:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1264969142

Comment:
I moved the udev rule from the libpackage because it would conflict (it seemed that both packages installed the same file).

In my opinion if the main package installs it then, there isn't a point on the lib package to have the same udev rule (pretty sure previously the rule was duplicate just in different directories)

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (5 preceding siblings ...)
  2022-10-03  5:57 ` motorto
@ 2022-10-03  6:00 ` motorto
  2022-10-03 12:33 ` classabbyamp
                   ` (17 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-03  6:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 1195 bytes --]

From 0fb8d9c78ce81cc9dca3bf11de1b176cf42cf2e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 2 Oct 2022 21:18:42 +0100
Subject: [PATCH] hackrf: remove duplicate udev rule;fix udev dir

By default, it installs rules on /etc/udev/rules.d which is forbidden use
/usr/lib/udev/rules.d instead.

Previously the udev rule would be duplicated installed by hackrf and
libhackrf.
---
 srcpkgs/hackrf/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9bd653451bb1..cf2759e92706 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -1,9 +1,10 @@
 # Template file for 'hackrf'
 pkgname=hackrf
 version=2021.03.1
-revision=1
+revision=2
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -28,7 +29,6 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (6 preceding siblings ...)
  2022-10-03  6:00 ` [PR PATCH] [Updated] " motorto
@ 2022-10-03 12:33 ` classabbyamp
  2022-10-03 15:40 ` Piraty
                   ` (16 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-10-03 12:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1265374112

Comment:
I think it makes more sense to keep this in the lib package, because someone who links against libhackrf for hackrf support in their app should have those rules so that users of the app can access the device properly. the `vinstall` can be replaced with `vmove` i think

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (7 preceding siblings ...)
  2022-10-03 12:33 ` classabbyamp
@ 2022-10-03 15:40 ` Piraty
  2022-10-04  9:40 ` motorto
                   ` (15 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: Piraty @ 2022-10-03 15:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1265658118

Comment:
it should be in the lib package. no need to change the template as it installs to the right path already.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (8 preceding siblings ...)
  2022-10-03 15:40 ` Piraty
@ 2022-10-04  9:40 ` motorto
  2022-10-04  9:40 ` [PR PATCH] [Updated] " motorto
                   ` (14 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04  9:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1266677625

Comment:
@Piraty how to solve the file conflict between the `hackrf` and `libhackrf_package` on the udev_rule ?

@classabbyamp could you specify the vinstall, the one in `libhackrf_package` ?

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (9 preceding siblings ...)
  2022-10-04  9:40 ` motorto
@ 2022-10-04  9:40 ` motorto
  2022-10-04  9:42 ` motorto
                   ` (13 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04  9:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 857 bytes --]

From e8fd266a12084b4b0f2ec95f6d73170a7f43d588 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hackrf: remove duplicate udev rule;fix udev dir

By default, it installs rules on /etc/udev/rules.d which is forbidden use
/usr/lib/udev/rules.d instead.
---
 srcpkgs/hackrf/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..2a8d53c0773a 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -5,6 +5,7 @@ revision=1
 build_wrksrc=host
 build_style=cmake
 hostmakedepends="pkg-config"
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
 short_desc="${_desc} - tools"

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (10 preceding siblings ...)
  2022-10-04  9:40 ` [PR PATCH] [Updated] " motorto
@ 2022-10-04  9:42 ` motorto
  2022-10-04 11:02 ` motorto
                   ` (12 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04  9:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 845 bytes --]

From 88b4359ae0feb90948bf91cccde5534592c8d88c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hackrf: remove duplicate udev rule;fix udev dir

By default, it installs rules on /etc/udev/rules.d which is forbidden use
/usr/lib/udev/rules.d instead.
---
 srcpkgs/hackrf/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..2a408cffcd8d 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (11 preceding siblings ...)
  2022-10-04  9:42 ` motorto
@ 2022-10-04 11:02 ` motorto
  2022-10-04 11:08 ` Piraty
                   ` (11 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04 11:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 1082 bytes --]

From 49da40fddde2f9959306cfb809e8cd9505d693d3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hackrf: remove duplicate udev rule;fix udev dir

By default, it installs rules on /etc/udev/rules.d which is forbidden use
/usr/lib/udev/rules.d instead.
---
 srcpkgs/hackrf/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..397efa95a059 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -28,7 +29,7 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
+		vmove usr/lib/udev/rules.d
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (12 preceding siblings ...)
  2022-10-04 11:02 ` motorto
@ 2022-10-04 11:08 ` Piraty
  2022-10-04 11:14 ` [PR PATCH] [Updated] " motorto
                   ` (10 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: Piraty @ 2022-10-04 11:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1266783083

Comment:
```
diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f4..397efa95a0 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -28,7 +29,7 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
+		vmove usr/lib/udev/rules.d
 	}
 }
```

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (13 preceding siblings ...)
  2022-10-04 11:08 ` Piraty
@ 2022-10-04 11:14 ` motorto
  2022-10-04 17:32 ` classabbyamp
                   ` (9 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04 11:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 1311 bytes --]

From 9b56e82bbdef78441d167a7c9f447574b664682c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hackrf: remove duplicate udev rule;fix udev dir

Fix fail, because it installs rules on /etc/udev/rules.d which is
forbidden use /usr/lib/udev/rules.d instead.

```
=> hackrf-2021.03.1_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: hackrf-2021.03.1_1: /etc/udev/rules.d is forbidden. Use /usr/lib/udev/rules.d.
=> ERROR: hackrf-2021.03.1_1: cannot continue with installation!
```
---
 srcpkgs/hackrf/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..397efa95a059 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -28,7 +29,7 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
+		vmove usr/lib/udev/rules.d
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (14 preceding siblings ...)
  2022-10-04 11:14 ` [PR PATCH] [Updated] " motorto
@ 2022-10-04 17:32 ` classabbyamp
  2022-10-04 17:33 ` classabbyamp
                   ` (8 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-10-04 17:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 3210 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1267333294

Comment:
the previously-installed rules with the `vsed` made it so only elogind users could use the udev rules. The now-installed rules only work with the `plugdev` group (and the `vsed` did nothing useful), this patch fixes that.

This should also be upstreamed, I think.

template change:
```diff
diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 397efa95a0..f47857bada 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -12,13 +12,9 @@ short_desc="${_desc} - tools"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://greatscottgadgets.com/hackrf/"
-distfiles="https://github.com/mossmann/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+distfiles="https://github.com/greatscottgadgets/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
 checksum=a43e5080c11efdfe69ddebcc35a02b018e30e820de0e0ebdc7948cf7b0cd93a3
 
-pre_configure() {
-	vsed -i 's|MODE="660", GROUP="plugdev"|TAG+="uaccess"|g' libhackrf/53-hackrf.rules
-}
-
 post_install() {
 	for f in ../firmware-bin/*.{bin,dfu}; do
 		vinstall "$f" 644 usr/share/hackrf/
```
patch:
```diff
enable device access via elogind

--- a/host/libhackrf/53-hackrf.rules.in
+++ b/host/libhackrf/53-hackrf.rules.in
@@ -1,13 +1,13 @@
 # HackRF Jawbreaker
-ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # HackRF One
-ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # rad1o
-ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # NXP Semiconductors DFU mode (HackRF and rad1o)
-ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # rad1o "full flash" mode
-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # rad1o flash disk
-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 #
```

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (15 preceding siblings ...)
  2022-10-04 17:32 ` classabbyamp
@ 2022-10-04 17:33 ` classabbyamp
  2022-10-04 19:37 ` [PR PATCH] [Updated] " motorto
                   ` (7 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-10-04 17:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 3253 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1267333294

Comment:
the previously-installed rules with the `vsed` made it so only elogind users could use the udev rules. The now-installed rules only work with the `plugdev` group (and the `vsed` did nothing useful), this patch fixes that.

This should also be upstreamed, I think.

Also, upstream repo changed namespaces.

template change:
```diff
diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 397efa95a0..f47857bada 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -12,13 +12,9 @@ short_desc="${_desc} - tools"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://greatscottgadgets.com/hackrf/"
-distfiles="https://github.com/mossmann/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+distfiles="https://github.com/greatscottgadgets/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
 checksum=a43e5080c11efdfe69ddebcc35a02b018e30e820de0e0ebdc7948cf7b0cd93a3
 
-pre_configure() {
-	vsed -i 's|MODE="660", GROUP="plugdev"|TAG+="uaccess"|g' libhackrf/53-hackrf.rules
-}
-
 post_install() {
 	for f in ../firmware-bin/*.{bin,dfu}; do
 		vinstall "$f" 644 usr/share/hackrf/
```
patch:
```diff
enable device access via elogind

--- a/host/libhackrf/53-hackrf.rules.in
+++ b/host/libhackrf/53-hackrf.rules.in
@@ -1,13 +1,13 @@
 # HackRF Jawbreaker
-ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # HackRF One
-ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # rad1o
-ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # NXP Semiconductors DFU mode (HackRF and rad1o)
-ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # rad1o "full flash" mode
-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 # rad1o flash disk
-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@"
+KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
 #
```

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (16 preceding siblings ...)
  2022-10-04 17:33 ` classabbyamp
@ 2022-10-04 19:37 ` motorto
  2022-10-04 19:41 ` motorto
                   ` (6 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04 19:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 4375 bytes --]

From 3e745ed359ea705786759b7382a0e6d67b82aae0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hckrf: remove duplicate udev rule;fix udev dir

Fix fail, because it installs rules on /etc/udev/rules.d which is
forbidden use /usr/lib/udev/rules.d instead.

```
=> hackrf-2021.03.1_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: hackrf-2021.03.1_1: /etc/udev/rules.d is forbidden. Use /usr/lib/udev/rules.d.
=> ERROR: hackrf-2021.03.1_1: cannot continue with installation!
```
---
 .../fix-device-acess-via-elogind.patch        | 24 +++++++++++++++++++
 srcpkgs/hackrf/template                       |  9 +++----
 2 files changed, 27 insertions(+), 6 deletions(-)
 create mode 100644 srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch

diff --git a/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
new file mode 100644
index 000000000000..769397760a6c
--- /dev/null
+++ b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
@@ -0,0 +1,24 @@
+enable device access via elogind
+
+--- a/host/libhackrf/53-hackrf.rules.in
++++ b/host/libhackrf/53-hackrf.rules.in
+@@ -1,13 +1,13 @@
+ # HackRF Jawbreaker
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # HackRF One
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # NXP Semiconductors DFU mode (HackRF and rad1o)
+-ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o "full flash" mode
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o flash disk
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ #
diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..2fdc4f29bb1a 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/ -Wno-dev"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -11,13 +12,9 @@ short_desc="${_desc} - tools"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://greatscottgadgets.com/hackrf/"
-distfiles="https://github.com/mossmann/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+distfiles="https://github.com/greatscottgadgets/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
 checksum=a43e5080c11efdfe69ddebcc35a02b018e30e820de0e0ebdc7948cf7b0cd93a3
 
-pre_configure() {
-	vsed -i 's|MODE="660", GROUP="plugdev"|TAG+="uaccess"|g' libhackrf/53-hackrf.rules
-}
-
 post_install() {
 	for f in ../firmware-bin/*.{bin,dfu}; do
 		vinstall "$f" 644 usr/share/hackrf/
@@ -28,7 +25,7 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
+vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (17 preceding siblings ...)
  2022-10-04 19:37 ` [PR PATCH] [Updated] " motorto
@ 2022-10-04 19:41 ` motorto
  2022-10-04 19:46 ` motorto
                   ` (5 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04 19:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 4343 bytes --]

From e9abc8867f10c18fa9e0f178bebefef0d6994a34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hckrf: remove duplicate udev rule;fix udev dir

Fix fail, because it installs rules on /etc/udev/rules.d which is
forbidden use /usr/lib/udev/rules.d instead.

```
=> hackrf-2021.03.1_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: hackrf-2021.03.1_1: /etc/udev/rules.d is forbidden. Use /usr/lib/udev/rules.d.
=> ERROR: hackrf-2021.03.1_1: cannot continue with installation!
```
---
 .../fix-device-acess-via-elogind.patch        | 24 +++++++++++++++++++
 srcpkgs/hackrf/template                       |  9 +++----
 2 files changed, 27 insertions(+), 6 deletions(-)
 create mode 100644 srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch

diff --git a/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
new file mode 100644
index 000000000000..769397760a6c
--- /dev/null
+++ b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
@@ -0,0 +1,24 @@
+enable device access via elogind
+
+--- a/host/libhackrf/53-hackrf.rules.in
++++ b/host/libhackrf/53-hackrf.rules.in
+@@ -1,13 +1,13 @@
+ # HackRF Jawbreaker
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # HackRF One
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # NXP Semiconductors DFU mode (HackRF and rad1o)
+-ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o "full flash" mode
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o flash disk
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ #
diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..b203f3a0ae0f 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/ -Wno-dev"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -11,13 +12,9 @@ short_desc="${_desc} - tools"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://greatscottgadgets.com/hackrf/"
-distfiles="https://github.com/mossmann/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+distfiles="https://github.com/greatscottgadgets/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
 checksum=a43e5080c11efdfe69ddebcc35a02b018e30e820de0e0ebdc7948cf7b0cd93a3
 
-pre_configure() {
-	vsed -i 's|MODE="660", GROUP="plugdev"|TAG+="uaccess"|g' libhackrf/53-hackrf.rules
-}
-
 post_install() {
 	for f in ../firmware-bin/*.{bin,dfu}; do
 		vinstall "$f" 644 usr/share/hackrf/
@@ -28,7 +25,7 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
+		vmove usr/lib/udev/rules.d
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (18 preceding siblings ...)
  2022-10-04 19:41 ` motorto
@ 2022-10-04 19:46 ` motorto
  2022-10-04 19:50 ` [PR PATCH] [Updated] " motorto
                   ` (4 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04 19:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1267499440

Comment:
@classabbyamp  still having the same conflict, but thanks for taking the time and fixing the vsed rule !

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (19 preceding siblings ...)
  2022-10-04 19:46 ` motorto
@ 2022-10-04 19:50 ` motorto
  2022-10-04 20:46 ` classabbyamp
                   ` (3 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04 19:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 4303 bytes --]

From b0b4b4288c8778c9e1de22fbaeb4d98d322c7b7f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hckrf: remove duplicate udev rule;fix udev dir

Fix fail, because it installs rules on /etc/udev/rules.d which is
forbidden use /usr/lib/udev/rules.d instead.

```
=> hackrf-2021.03.1_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: /etc/udev/rules.d is forbidden. Use /usr/lib/udev/rules.d.
=> ERROR: cannot continue with installation!
```
---
 .../fix-device-acess-via-elogind.patch        | 24 +++++++++++++++++++
 srcpkgs/hackrf/template                       |  9 +++----
 2 files changed, 27 insertions(+), 6 deletions(-)
 create mode 100644 srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch

diff --git a/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
new file mode 100644
index 000000000000..769397760a6c
--- /dev/null
+++ b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
@@ -0,0 +1,24 @@
+enable device access via elogind
+
+--- a/host/libhackrf/53-hackrf.rules.in
++++ b/host/libhackrf/53-hackrf.rules.in
+@@ -1,13 +1,13 @@
+ # HackRF Jawbreaker
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # HackRF One
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # NXP Semiconductors DFU mode (HackRF and rad1o)
+-ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o "full flash" mode
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o flash disk
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ #
diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..b203f3a0ae0f 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -4,6 +4,7 @@ version=2021.03.1
 revision=1
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/ -Wno-dev"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -11,13 +12,9 @@ short_desc="${_desc} - tools"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://greatscottgadgets.com/hackrf/"
-distfiles="https://github.com/mossmann/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+distfiles="https://github.com/greatscottgadgets/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
 checksum=a43e5080c11efdfe69ddebcc35a02b018e30e820de0e0ebdc7948cf7b0cd93a3
 
-pre_configure() {
-	vsed -i 's|MODE="660", GROUP="plugdev"|TAG+="uaccess"|g' libhackrf/53-hackrf.rules
-}
-
 post_install() {
 	for f in ../firmware-bin/*.{bin,dfu}; do
 		vinstall "$f" 644 usr/share/hackrf/
@@ -28,7 +25,7 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
+		vmove usr/lib/udev/rules.d
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (20 preceding siblings ...)
  2022-10-04 19:50 ` [PR PATCH] [Updated] " motorto
@ 2022-10-04 20:46 ` classabbyamp
  2022-10-04 20:49 ` [PR PATCH] [Updated] " motorto
                   ` (2 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-10-04 20:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39633#issuecomment-1267557893

Comment:
bump the revision and this should be good


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (21 preceding siblings ...)
  2022-10-04 20:46 ` classabbyamp
@ 2022-10-04 20:49 ` motorto
  2022-10-04 20:56 ` motorto
  2022-10-04 21:01 ` [PR PATCH] [Merged]: " classabbyamp
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04 20:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 4365 bytes --]

From 0e204744782a1ad8b1cedd9be32d1791d888fc78 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hckrf: remove duplicate udev rule;fix udev dir

Fix fail, because it installs rules on /etc/udev/rules.d which is
forbidden use /usr/lib/udev/rules.d instead.

```
=> hackrf-2021.03.1_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: /etc/udev/rules.d is forbidden. Use /usr/lib/udev/rules.d.
=> ERROR: cannot continue with installation!
```
---
 .../fix-device-acess-via-elogind.patch        | 24 +++++++++++++++++++
 srcpkgs/hackrf/template                       | 11 ++++-----
 2 files changed, 28 insertions(+), 7 deletions(-)
 create mode 100644 srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch

diff --git a/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
new file mode 100644
index 000000000000..769397760a6c
--- /dev/null
+++ b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
@@ -0,0 +1,24 @@
+enable device access via elogind
+
+--- a/host/libhackrf/53-hackrf.rules.in
++++ b/host/libhackrf/53-hackrf.rules.in
+@@ -1,13 +1,13 @@
+ # HackRF Jawbreaker
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # HackRF One
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # NXP Semiconductors DFU mode (HackRF and rad1o)
+-ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o "full flash" mode
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o flash disk
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ #
diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..0fe613838e85 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -1,9 +1,10 @@
 # Template file for 'hackrf'
 pkgname=hackrf
 version=2021.03.1
-revision=1
+revision=2
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/ -Wno-dev"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -11,13 +12,9 @@ short_desc="${_desc} - tools"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://greatscottgadgets.com/hackrf/"
-distfiles="https://github.com/mossmann/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+distfiles="https://github.com/greatscottgadgets/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
 checksum=a43e5080c11efdfe69ddebcc35a02b018e30e820de0e0ebdc7948cf7b0cd93a3
 
-pre_configure() {
-	vsed -i 's|MODE="660", GROUP="plugdev"|TAG+="uaccess"|g' libhackrf/53-hackrf.rules
-}
-
 post_install() {
 	for f in ../firmware-bin/*.{bin,dfu}; do
 		vinstall "$f" 644 usr/share/hackrf/
@@ -28,7 +25,7 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
+		vmove usr/lib/udev/rules.d
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (22 preceding siblings ...)
  2022-10-04 20:49 ` [PR PATCH] [Updated] " motorto
@ 2022-10-04 20:56 ` motorto
  2022-10-04 21:01 ` [PR PATCH] [Merged]: " classabbyamp
  24 siblings, 0 replies; 26+ messages in thread
From: motorto @ 2022-10-04 20:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages hackrf
https://github.com/void-linux/void-packages/pull/39633

hackrf: fix udev rules directory
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

A patch file from https://github.com/void-linux/void-packages/pull/39633.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hackrf-39633.patch --]
[-- Type: text/x-diff, Size: 4366 bytes --]

From 4982adc19a74afa57e2800ced28e9d80d4d75454 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Tue, 4 Oct 2022 10:33:36 +0100
Subject: [PATCH] hackrf: remove duplicate udev rule;fix udev dir

Fix fail, because it installs rules on /etc/udev/rules.d which is
forbidden use /usr/lib/udev/rules.d instead.

```
=> hackrf-2021.03.1_1: running pre-pkg hook: 99-pkglint ...
=> ERROR: /etc/udev/rules.d is forbidden. Use /usr/lib/udev/rules.d.
=> ERROR: cannot continue with installation!
```
---
 .../fix-device-acess-via-elogind.patch        | 24 +++++++++++++++++++
 srcpkgs/hackrf/template                       | 11 ++++-----
 2 files changed, 28 insertions(+), 7 deletions(-)
 create mode 100644 srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch

diff --git a/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
new file mode 100644
index 000000000000..769397760a6c
--- /dev/null
+++ b/srcpkgs/hackrf/patches/fix-device-acess-via-elogind.patch
@@ -0,0 +1,24 @@
+enable device access via elogind
+
+--- a/host/libhackrf/53-hackrf.rules.in
++++ b/host/libhackrf/53-hackrf.rules.in
+@@ -1,13 +1,13 @@
+ # HackRF Jawbreaker
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="604b", SYMLINK+="hackrf-jawbreaker-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # HackRF One
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="6089", SYMLINK+="hackrf-one-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o
+-ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1d50", ATTR{idProduct}=="cc15", SYMLINK+="rad1o-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # NXP Semiconductors DFU mode (HackRF and rad1o)
+-ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++ATTR{idVendor}=="1fc9", ATTR{idProduct}=="000c", SYMLINK+="nxp-dfu-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o "full flash" mode
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0042", SYMLINK+="rad1o-flash-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ # rad1o flash disk
+-KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@"
++KERNEL=="sd?", SUBSYSTEM=="block", ENV{ID_VENDOR_ID}=="1fc9", ENV{ID_MODEL_ID}=="0082", SYMLINK+="rad1o-msc-%k", MODE="660", GROUP="@HACKRF_GROUP@", TAG+="uaccess"
+ #
diff --git a/srcpkgs/hackrf/template b/srcpkgs/hackrf/template
index 9e756967f44c..0fe613838e85 100644
--- a/srcpkgs/hackrf/template
+++ b/srcpkgs/hackrf/template
@@ -1,9 +1,10 @@
 # Template file for 'hackrf'
 pkgname=hackrf
 version=2021.03.1
-revision=1
+revision=2
 build_wrksrc=host
 build_style=cmake
+configure_args="-DUDEV_RULES_PATH=/usr/lib/udev/rules.d/ -Wno-dev"
 hostmakedepends="pkg-config"
 makedepends="libusb-devel fftw-devel"
 _desc="Low cost software defined radio (SDR) platform"
@@ -11,13 +12,9 @@ short_desc="${_desc} - tools"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://greatscottgadgets.com/hackrf/"
-distfiles="https://github.com/mossmann/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
+distfiles="https://github.com/greatscottgadgets/hackrf/releases/download/v${version}/${pkgname}-${version}.tar.xz"
 checksum=a43e5080c11efdfe69ddebcc35a02b018e30e820de0e0ebdc7948cf7b0cd93a3
 
-pre_configure() {
-	vsed -i 's|MODE="660", GROUP="plugdev"|TAG+="uaccess"|g' libhackrf/53-hackrf.rules
-}
-
 post_install() {
 	for f in ../firmware-bin/*.{bin,dfu}; do
 		vinstall "$f" 644 usr/share/hackrf/
@@ -28,7 +25,7 @@ libhackrf_package() {
 	short_desc="${_desc} - library"
 	pkg_install() {
 		vmove usr/lib/*.so.*
-		vinstall libhackrf/53-hackrf.rules 644 usr/lib/udev/rules.d/
+		vmove usr/lib/udev/rules.d
 	}
 }
 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Merged]: hackrf: fix udev rules directory
  2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
                   ` (23 preceding siblings ...)
  2022-10-04 20:56 ` motorto
@ 2022-10-04 21:01 ` classabbyamp
  24 siblings, 0 replies; 26+ messages in thread
From: classabbyamp @ 2022-10-04 21:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

There's a merged pull request on the void-packages repository

hackrf: fix udev rules directory
https://github.com/void-linux/void-packages/pull/39633

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l

[39083](https://github.com/void-linux/void-packages/issues/39083)

^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2022-10-04 21:01 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-02 20:21 [PR PATCH] hackrf: fix udev rules directory motorto
2022-10-02 20:25 ` [PR PATCH] [Updated] " motorto
2022-10-02 20:36 ` motorto
2022-10-02 21:32 ` Piraty
2022-10-02 21:34 ` Piraty
2022-10-02 21:56 ` paper42
2022-10-03  5:57 ` motorto
2022-10-03  6:00 ` [PR PATCH] [Updated] " motorto
2022-10-03 12:33 ` classabbyamp
2022-10-03 15:40 ` Piraty
2022-10-04  9:40 ` motorto
2022-10-04  9:40 ` [PR PATCH] [Updated] " motorto
2022-10-04  9:42 ` motorto
2022-10-04 11:02 ` motorto
2022-10-04 11:08 ` Piraty
2022-10-04 11:14 ` [PR PATCH] [Updated] " motorto
2022-10-04 17:32 ` classabbyamp
2022-10-04 17:33 ` classabbyamp
2022-10-04 19:37 ` [PR PATCH] [Updated] " motorto
2022-10-04 19:41 ` motorto
2022-10-04 19:46 ` motorto
2022-10-04 19:50 ` [PR PATCH] [Updated] " motorto
2022-10-04 20:46 ` classabbyamp
2022-10-04 20:49 ` [PR PATCH] [Updated] " motorto
2022-10-04 20:56 ` motorto
2022-10-04 21:01 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).