Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] intellij-idea-community-edition: use jetbrains jdk
@ 2022-10-03 23:27 dexgs
  2022-10-03 23:29 ` [PR PATCH] [Updated] " dexgs
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: dexgs @ 2022-10-03 23:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]

There is a new pull request by dexgs against master on the void-packages repository

https://github.com/dexgs/void-packages intellij
https://github.com/void-linux/void-packages/pull/39683

intellij-idea-community-edition: use jetbrains jdk
<!-- Uncomment relevant sections and delete options which are not applicable -->

Trying to run intellij with an openjdk will error on startup complaining about missing AWT modules which aren't in that distribution. Instead of depending on any java environment, depend explicitly on the jetbrains jdk and modify the desktop entry to launch intellij with that jdk.

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39683.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-intellij-39683.patch --]
[-- Type: text/x-diff, Size: 1767 bytes --]

From 708f67a43ac60a28cdd5a0a6ebef154438f2e76e Mon Sep 17 00:00:00 2001
From: Dexter Gaon-Shatford <dexter.gaonshatford@gmail.com>
Date: Mon, 3 Oct 2022 19:23:34 -0400
Subject: [PATCH] intellij-idea-community-edition: use jetbrains jdk

---
 srcpkgs/intellij-idea-community-edition/files/idea.desktop | 4 ++--
 srcpkgs/intellij-idea-community-edition/template           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/intellij-idea-community-edition/files/idea.desktop b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
index 5d32e21b0193..939cd0bd9738 100644
--- a/srcpkgs/intellij-idea-community-edition/files/idea.desktop
+++ b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
@@ -1,8 +1,8 @@
 [Desktop Entry]
 Name=IntelliJ IDEA Community Edition
 Comment=Java integrated development environment by JetBrains
-Exec=/usr/bin/idea %f
+Exec=env IDEA_JDK=/usr/lib/jvm/jbrsdk /usr/bin/idea %f
 Icon=idea
 Terminal=false
 Type=Application
-Categories=Development;
\ No newline at end of file
+Categories=Development;
diff --git a/srcpkgs/intellij-idea-community-edition/template b/srcpkgs/intellij-idea-community-edition/template
index 5da32aa243a4..62ea87394b40 100644
--- a/srcpkgs/intellij-idea-community-edition/template
+++ b/srcpkgs/intellij-idea-community-edition/template
@@ -1,9 +1,9 @@
 # Template file for 'intellij-idea-community-edition'
 pkgname=intellij-idea-community-edition
 version=2021.3.3
-revision=1
+revision=3
 archs="i686 x86_64"
-depends="virtual?java-environment giflib libXtst hicolor-icon-theme"
+depends="jetbrains-jdk-bin giflib libXtst hicolor-icon-theme"
 short_desc="Java integrated development environment by JetBrains"
 maintainer="John <me@johnnynator.dev>"
 license="Apache-2.0"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] intellij-idea-community-edition: use jetbrains jdk
  2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
@ 2022-10-03 23:29 ` dexgs
  2022-10-03 23:47 ` dexgs
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: dexgs @ 2022-10-03 23:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

There is an updated pull request by dexgs against master on the void-packages repository

https://github.com/dexgs/void-packages intellij
https://github.com/void-linux/void-packages/pull/39683

intellij-idea-community-edition: use jetbrains jdk
<!-- Uncomment relevant sections and delete options which are not applicable -->

Trying to run intellij with an openjdk will error on startup complaining about missing AWT modules which aren't in that distribution. Instead of depending on any java environment, depend explicitly on the jetbrains jdk and modify the desktop entry to launch intellij with that jdk.

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39683.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-intellij-39683.patch --]
[-- Type: text/x-diff, Size: 1767 bytes --]

From e12c09f1705571fbfc5b86014cc50918ada69292 Mon Sep 17 00:00:00 2001
From: Dexter Gaon-Shatford <dexter.gaonshatford@gmail.com>
Date: Mon, 3 Oct 2022 19:23:34 -0400
Subject: [PATCH] intellij-idea-community-edition: use jetbrains jdk

---
 srcpkgs/intellij-idea-community-edition/files/idea.desktop | 4 ++--
 srcpkgs/intellij-idea-community-edition/template           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/intellij-idea-community-edition/files/idea.desktop b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
index 5d32e21b0193..939cd0bd9738 100644
--- a/srcpkgs/intellij-idea-community-edition/files/idea.desktop
+++ b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
@@ -1,8 +1,8 @@
 [Desktop Entry]
 Name=IntelliJ IDEA Community Edition
 Comment=Java integrated development environment by JetBrains
-Exec=/usr/bin/idea %f
+Exec=env IDEA_JDK=/usr/lib/jvm/jbrsdk /usr/bin/idea %f
 Icon=idea
 Terminal=false
 Type=Application
-Categories=Development;
\ No newline at end of file
+Categories=Development;
diff --git a/srcpkgs/intellij-idea-community-edition/template b/srcpkgs/intellij-idea-community-edition/template
index 5da32aa243a4..62ea87394b40 100644
--- a/srcpkgs/intellij-idea-community-edition/template
+++ b/srcpkgs/intellij-idea-community-edition/template
@@ -1,9 +1,9 @@
 # Template file for 'intellij-idea-community-edition'
 pkgname=intellij-idea-community-edition
 version=2021.3.3
-revision=1
+revision=3
 archs="i686 x86_64"
-depends="virtual?java-environment giflib libXtst hicolor-icon-theme"
+depends="jetbrains-jdk-bin giflib libXtst hicolor-icon-theme"
 short_desc="Java integrated development environment by JetBrains"
 maintainer="John <me@johnnynator.dev>"
 license="Apache-2.0"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] intellij-idea-community-edition: use jetbrains jdk
  2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
  2022-10-03 23:29 ` [PR PATCH] [Updated] " dexgs
@ 2022-10-03 23:47 ` dexgs
  2022-10-04 18:45 ` [PR PATCH] [Merged]: " classabbyamp
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: dexgs @ 2022-10-03 23:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

There is an updated pull request by dexgs against master on the void-packages repository

https://github.com/dexgs/void-packages intellij
https://github.com/void-linux/void-packages/pull/39683

intellij-idea-community-edition: use jetbrains jdk
<!-- Uncomment relevant sections and delete options which are not applicable -->

Trying to run intellij with an openjdk will error on startup complaining about missing AWT modules which aren't in that distribution. Instead of depending on any java environment, depend explicitly on the jetbrains jdk and modify the desktop entry to launch intellij with that jdk.

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39683.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-intellij-39683.patch --]
[-- Type: text/x-diff, Size: 1767 bytes --]

From ee62a6240028586263001c44d9e57682b103f79f Mon Sep 17 00:00:00 2001
From: Dexter Gaon-Shatford <dexter.gaonshatford@gmail.com>
Date: Mon, 3 Oct 2022 19:23:34 -0400
Subject: [PATCH] intellij-idea-community-edition: use jetbrains jdk

---
 srcpkgs/intellij-idea-community-edition/files/idea.desktop | 4 ++--
 srcpkgs/intellij-idea-community-edition/template           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/intellij-idea-community-edition/files/idea.desktop b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
index 5d32e21b0193..939cd0bd9738 100644
--- a/srcpkgs/intellij-idea-community-edition/files/idea.desktop
+++ b/srcpkgs/intellij-idea-community-edition/files/idea.desktop
@@ -1,8 +1,8 @@
 [Desktop Entry]
 Name=IntelliJ IDEA Community Edition
 Comment=Java integrated development environment by JetBrains
-Exec=/usr/bin/idea %f
+Exec=env IDEA_JDK=/usr/lib/jvm/jbrsdk /usr/bin/idea %f
 Icon=idea
 Terminal=false
 Type=Application
-Categories=Development;
\ No newline at end of file
+Categories=Development;
diff --git a/srcpkgs/intellij-idea-community-edition/template b/srcpkgs/intellij-idea-community-edition/template
index 5da32aa243a4..fdc0f380b0b2 100644
--- a/srcpkgs/intellij-idea-community-edition/template
+++ b/srcpkgs/intellij-idea-community-edition/template
@@ -1,9 +1,9 @@
 # Template file for 'intellij-idea-community-edition'
 pkgname=intellij-idea-community-edition
 version=2021.3.3
-revision=1
+revision=2
 archs="i686 x86_64"
-depends="virtual?java-environment giflib libXtst hicolor-icon-theme"
+depends="jetbrains-jdk-bin giflib libXtst hicolor-icon-theme"
 short_desc="Java integrated development environment by JetBrains"
 maintainer="John <me@johnnynator.dev>"
 license="Apache-2.0"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: intellij-idea-community-edition: use jetbrains jdk
  2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
  2022-10-03 23:29 ` [PR PATCH] [Updated] " dexgs
  2022-10-03 23:47 ` dexgs
@ 2022-10-04 18:45 ` classabbyamp
  2022-10-04 18:58 ` Chocimier
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2022-10-04 18:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

There's a merged pull request on the void-packages repository

intellij-idea-community-edition: use jetbrains jdk
https://github.com/void-linux/void-packages/pull/39683

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

Trying to run intellij with an openjdk will error on startup complaining about missing AWT modules which aren't in that distribution. Instead of depending on any java environment via the `java-environment` virtual package, depend explicitly on the jetbrains jdk and modify the desktop entry to launch intellij with that jdk.

With these changes, intellij is only launched with the jetbrains jdk by default when you use the desktop entry. You can still launch it using any java environment when using the executable directly by setting the `IDEA_JDK` variable on the command line.

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: intellij-idea-community-edition: use jetbrains jdk
  2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
                   ` (2 preceding siblings ...)
  2022-10-04 18:45 ` [PR PATCH] [Merged]: " classabbyamp
@ 2022-10-04 18:58 ` Chocimier
  2022-10-04 19:00 ` dexgs
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2022-10-04 18:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/39683#issuecomment-1267452246

Comment:
IDEA_JDK is exported by jetbrains jdk so it should not be needed to force it in desktop file.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: intellij-idea-community-edition: use jetbrains jdk
  2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
                   ` (3 preceding siblings ...)
  2022-10-04 18:58 ` Chocimier
@ 2022-10-04 19:00 ` dexgs
  2022-10-04 19:03 ` classabbyamp
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: dexgs @ 2022-10-04 19:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]

New comment by dexgs on void-packages repository

https://github.com/void-linux/void-packages/pull/39683#issuecomment-1267454389

Comment:
Yes, it will re-export its value, but if it's unset it will try to detect the system's default jdk and use that. If it *is* set, no detection happens and it just uses the value you give it. This is desirable because intellij will not work if you try to run it with the openjdk.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: intellij-idea-community-edition: use jetbrains jdk
  2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
                   ` (4 preceding siblings ...)
  2022-10-04 19:00 ` dexgs
@ 2022-10-04 19:03 ` classabbyamp
  2022-10-04 19:04 ` dexgs
  2022-10-04 19:10 ` classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2022-10-04 19:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39683#issuecomment-1267456817

Comment:
but it *will* be set, because it's exported in /etc/profile

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: intellij-idea-community-edition: use jetbrains jdk
  2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
                   ` (5 preceding siblings ...)
  2022-10-04 19:03 ` classabbyamp
@ 2022-10-04 19:04 ` dexgs
  2022-10-04 19:10 ` classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: dexgs @ 2022-10-04 19:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by dexgs on void-packages repository

https://github.com/void-linux/void-packages/pull/39683#issuecomment-1267458754

Comment:
you're right. I guess the change to the desktop entry should be reverted, then.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: intellij-idea-community-edition: use jetbrains jdk
  2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
                   ` (6 preceding siblings ...)
  2022-10-04 19:04 ` dexgs
@ 2022-10-04 19:10 ` classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2022-10-04 19:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/39683#issuecomment-1267464952

Comment:
done


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-10-04 19:10 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-03 23:27 [PR PATCH] intellij-idea-community-edition: use jetbrains jdk dexgs
2022-10-03 23:29 ` [PR PATCH] [Updated] " dexgs
2022-10-03 23:47 ` dexgs
2022-10-04 18:45 ` [PR PATCH] [Merged]: " classabbyamp
2022-10-04 18:58 ` Chocimier
2022-10-04 19:00 ` dexgs
2022-10-04 19:03 ` classabbyamp
2022-10-04 19:04 ` dexgs
2022-10-04 19:10 ` classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).