* [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump
@ 2022-10-04 0:48 dmarto
2022-10-04 0:55 ` classabbyamp
` (22 more replies)
0 siblings, 23 replies; 24+ messages in thread
From: dmarto @ 2022-10-04 0:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
There is a new pull request by dmarto against master on the void-packages repository
https://github.com/dmarto/void-packages libfido-plugdev
https://github.com/void-linux/void-packages/pull/39688
libfido2: switch udev rules back to 'plugdev', revbump
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/39688.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libfido-plugdev-39688.patch --]
[-- Type: text/x-diff, Size: 1498 bytes --]
From 8c5a64647072b81411b44654b51267f132cbf746 Mon Sep 17 00:00:00 2001
From: Martin Dimov <martin@dmarto.com>
Date: Tue, 4 Oct 2022 03:46:32 +0300
Subject: [PATCH] libfido2: switch udev rules back to 'plugdev', revbump
---
srcpkgs/libfido2/template | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/libfido2/template b/srcpkgs/libfido2/template
index bb68556787ef..a5127f2ea672 100644
--- a/srcpkgs/libfido2/template
+++ b/srcpkgs/libfido2/template
@@ -1,7 +1,7 @@
# Template file for 'libfido2'
pkgname=libfido2
version=1.12.0
-revision=1
+revision=2
build_style=cmake
configure_args="-DUDEV_RULES_DIR=/usr/lib/udev/rules.d"
hostmakedepends="pkg-config"
@@ -10,8 +10,8 @@ short_desc="Library for FIDO 2.0, including communication with a device over USB
maintainer="Leah Neukirchen <leah@vuxu.org>"
license="BSD-2-Clause"
homepage="https://github.com/Yubico/libfido2"
+changelog="https://raw.githubusercontent.com/Yubico/libfido2/main/NEWS"
distfiles="https://github.com/Yubico/libfido2/archive/${version}.tar.gz"
-changelog="https://github.com/Yubico/libfido2/blob/main/NEWS"
checksum=813d6d25116143d16d2e96791718a74825da16b774a8d093d96f06ae1730d9c5
# udev rules used to be shipped by libu2f-host
conf_files="/usr/lib/udev/rules.d/70-u2f.rules"
@@ -23,8 +23,6 @@ post_extract() {
post_install() {
vlicense LICENSE
- vsed -e 's/GROUP="plugdev"/GROUP="users"/' \
- -i ${DESTDIR}/usr/lib/udev/rules.d/70-u2f.rules
}
libfido2-devel_package() {
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
@ 2022-10-04 0:55 ` classabbyamp
2022-10-04 1:11 ` dmarto
` (21 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-10-04 0:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266267232
Comment:
this will probably be a breaking change for some users, we should be careful with it
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
2022-10-04 0:55 ` classabbyamp
@ 2022-10-04 1:11 ` dmarto
2022-10-04 1:12 ` dmarto
` (20 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-04 1:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266276633
Comment:
And to help with that, here is some history context:
Started as `plugdev`
Got changed to `users` in #4605
Got changed back to `plugdev` in #13914
Got changed back to `users` in #25646 (it may have been a mistake, as it is not mentioned anywhere?)
This PR.
Honestly, I would be happy with an INSTALL message, that mention this anachronism
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
2022-10-04 0:55 ` classabbyamp
2022-10-04 1:11 ` dmarto
@ 2022-10-04 1:12 ` dmarto
2022-10-04 2:07 ` 0x5c
` (19 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-04 1:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266276633
Comment:
And to help with that, here is some history context:
Started as `plugdev`
Got changed to `users` in #4605
Got changed back to `plugdev` in #13914
Got changed back to `users` in #25646 (it may have been a mistake, as it is not mentioned anywhere?)
This PR.
Honestly, I would be happy with an INSTALL message that mention this anachronism.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (2 preceding siblings ...)
2022-10-04 1:12 ` dmarto
@ 2022-10-04 2:07 ` 0x5c
2022-10-04 12:35 ` dmarto
` (18 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: 0x5c @ 2022-10-04 2:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
New comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266302001
Comment:
So there's a bit of history here
Those udev rule modifications to use the `users` group are from quite some time ago, before the `plugdev` group existed.
The `plugdev` group as as proper default system group is new from this year (https://github.com/void-linux/void-packages/pull/36238). Before that many packages would define it in their templates.
As for why it's `users`, I imagine that at the time it was expected that any normal users would be added to that group. As a result we got a policy of putting FIDO/U2F devices, and only those devices, in the `users` group.
I'm generally in support of this change, with the caveat that we need to avoid problems for existing users.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (3 preceding siblings ...)
2022-10-04 2:07 ` 0x5c
@ 2022-10-04 12:35 ` dmarto
2022-10-04 12:52 ` leahneukirchen
` (17 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-04 12:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266927505
Comment:
Ok, I tried my best, this is what I figured:
- we want to keep the old rules file, for people that have it
- the new one should overwrite it
```diff
diff --git a/srcpkgs/libfido2/template b/srcpkgs/libfido2/template
index a5127f2ea6..7472dc44ab 100644
--- a/srcpkgs/libfido2/template
+++ b/srcpkgs/libfido2/template
@@ -14,14 +14,16 @@ changelog="https://raw.githubusercontent.com/Yubico/libfido2/main/NEWS"
distfiles="https://github.com/Yubico/libfido2/archive/${version}.tar.gz"
checksum=813d6d25116143d16d2e96791718a74825da16b774a8d093d96f06ae1730d9c5
# udev rules used to be shipped by libu2f-host
-conf_files="/usr/lib/udev/rules.d/70-u2f.rules"
conflicts="libu2f-host<=1.1.10_3"
+# keep the old 70-u2f.rules
+preserve=yes
post_extract() {
vsed -i -e '/add_compile_options(-Werror)/d' CMakeLists.txt
}
post_install() {
+ mv ${DESTDIR}/usr/lib/udev/rules.d/{70-u2f.rules,69-u2f-plugdev.rules}
vlicense LICENSE
}
```
I am not sure if this is a good solution or not; I would love any help or suggestions you may have.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (4 preceding siblings ...)
2022-10-04 12:35 ` dmarto
@ 2022-10-04 12:52 ` leahneukirchen
2022-10-04 13:12 ` dmarto
` (16 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: leahneukirchen @ 2022-10-04 12:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
New comment by leahneukirchen on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266949029
Comment:
IMO just change it, most users will be in plugdev already anyway I think? INSTALL.msg is fine.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (5 preceding siblings ...)
2022-10-04 12:52 ` leahneukirchen
@ 2022-10-04 13:12 ` dmarto
2022-10-04 15:16 ` classabbyamp
` (15 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-04 13:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266927505
Comment:
Ok, I tried my best, this is what I figured:
- we want to keep the old rules file, for people that have it
- the new one should NOT overwrite it
```diff
diff --git a/srcpkgs/libfido2/template b/srcpkgs/libfido2/template
index a5127f2ea6..7472dc44ab 100644
--- a/srcpkgs/libfido2/template
+++ b/srcpkgs/libfido2/template
@@ -14,14 +14,16 @@ changelog="https://raw.githubusercontent.com/Yubico/libfido2/main/NEWS"
distfiles="https://github.com/Yubico/libfido2/archive/${version}.tar.gz"
checksum=813d6d25116143d16d2e96791718a74825da16b774a8d093d96f06ae1730d9c5
# udev rules used to be shipped by libu2f-host
-conf_files="/usr/lib/udev/rules.d/70-u2f.rules"
conflicts="libu2f-host<=1.1.10_3"
+# keep the old 70-u2f.rules
+preserve=yes
post_extract() {
vsed -i -e '/add_compile_options(-Werror)/d' CMakeLists.txt
}
post_install() {
+ mv ${DESTDIR}/usr/lib/udev/rules.d/{70-u2f.rules,69-u2f-plugdev.rules}
vlicense LICENSE
}
```
I am not sure if this is a good solution or not; I would love any help or suggestions you may have.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (6 preceding siblings ...)
2022-10-04 13:12 ` dmarto
@ 2022-10-04 15:16 ` classabbyamp
2022-10-04 15:56 ` dmarto
` (14 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-10-04 15:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 248 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1267166784
Comment:
copying the rule to two places with different groups won't work, only 1 group can own the device node
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (7 preceding siblings ...)
2022-10-04 15:16 ` classabbyamp
@ 2022-10-04 15:56 ` dmarto
2022-10-04 16:14 ` dmarto
` (13 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-04 15:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1267221940
Comment:
> copying the rule to two places with different groups won't work, only 1 group can own the device node
yes, the idea is that the older rule (the one with `users`) is going to overwrite the newer one, and for people that have the file it will still be owned by users; anyway that was just a suggestion towards, trying to not break anything.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (8 preceding siblings ...)
2022-10-04 15:56 ` dmarto
@ 2022-10-04 16:14 ` dmarto
2022-10-05 14:47 ` CameronNemo
` (12 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-04 16:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1267221940
Comment:
> copying the rule to two places with different groups won't work, only 1 group can own the device node
yes, the idea is that the older rule (the one with `users`) is going to overwrite the newer one, and for people that have the file it will still be owned by users; anyway that was just a suggestion towards, trying to not break anything.
edit: anyway it is not a nice solution, I am thinking of just writing two install msgs (either for changing it back to `plugdev`, or mentioning the history quirk and that it is `users`) and leaving it some sort of consensus (between you) for what the group will be.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (9 preceding siblings ...)
2022-10-04 16:14 ` dmarto
@ 2022-10-05 14:47 ` CameronNemo
2022-10-08 22:54 ` dmarto
` (11 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: CameronNemo @ 2022-10-05 14:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1268538087
Comment:
I think you are mistaken regarding #13914. That PR kept it as users.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (10 preceding siblings ...)
2022-10-05 14:47 ` CameronNemo
@ 2022-10-08 22:54 ` dmarto
2022-10-08 22:57 ` dmarto
` (10 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-08 22:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1272409657
Comment:
> I think you are mistaken regarding #13914. That PR kept it as users.
you are more then correct, I got baited by the PR description
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (11 preceding siblings ...)
2022-10-08 22:54 ` dmarto
@ 2022-10-08 22:57 ` dmarto
2022-10-08 23:16 ` [PR PATCH] [Updated] " dmarto
` (9 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-08 22:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1266276633
Comment:
And to help with that, here is some history context:
Started as `plugdev`
Got changed to `users` in #4605
~~Got~~ Attempted change~~d~~ back to `plugdev`, but was left as `user` in #13914
~~Got changed back to `users` in #25646 (it may have been a mistake, as it is not mentioned anywhere?)~~
This PR.
Honestly, I would be happy with an INSTALL message that mention this anachronism.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (12 preceding siblings ...)
2022-10-08 22:57 ` dmarto
@ 2022-10-08 23:16 ` dmarto
2022-10-08 23:19 ` dmarto
` (8 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-08 23:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
There is an updated pull request by dmarto against master on the void-packages repository
https://github.com/dmarto/void-packages libfido-plugdev
https://github.com/void-linux/void-packages/pull/39688
libfido2: switch udev rules back to 'plugdev', revbump
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86-64_glibc)
@leahneukirchen
Embarrassingly, I spent a lot of time wondering why my U2F was not showing and then I noticed this switch in the template.
Most other rules shipped by void, use `plugdev`, and the current docs imply that it should be `plugdev`.
```
plugdev | Access to pluggable devices.
users | Ordinary users.
```
from https://docs.voidlinux.org/config/users-and-groups.html
A patch file from https://github.com/void-linux/void-packages/pull/39688.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libfido-plugdev-39688.patch --]
[-- Type: text/x-diff, Size: 1718 bytes --]
From 6679ee30497900659a79afaefaff18b532b31f50 Mon Sep 17 00:00:00 2001
From: Martin Dimov <martin@dmarto.com>
Date: Sun, 9 Oct 2022 02:16:10 +0300
Subject: [PATCH] libfido2: add INSTALL.msg, revbump
---
srcpkgs/libfido2/INSTALL.msg | 3 +++
srcpkgs/libfido2/template | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
create mode 100644 srcpkgs/libfido2/INSTALL.msg
diff --git a/srcpkgs/libfido2/INSTALL.msg b/srcpkgs/libfido2/INSTALL.msg
new file mode 100644
index 000000000000..f0690ce7a254
--- /dev/null
+++ b/srcpkgs/libfido2/INSTALL.msg
@@ -0,0 +1,3 @@
+If you are NOT using a login/seat manager with support for "uaccess"
+tags, you will need to be in the "users" group to take advantage of
+the default udev rules.
diff --git a/srcpkgs/libfido2/template b/srcpkgs/libfido2/template
index bb68556787ef..99ef1b004f4d 100644
--- a/srcpkgs/libfido2/template
+++ b/srcpkgs/libfido2/template
@@ -1,7 +1,7 @@
# Template file for 'libfido2'
pkgname=libfido2
version=1.12.0
-revision=1
+revision=2
build_style=cmake
configure_args="-DUDEV_RULES_DIR=/usr/lib/udev/rules.d"
hostmakedepends="pkg-config"
@@ -10,8 +10,8 @@ short_desc="Library for FIDO 2.0, including communication with a device over USB
maintainer="Leah Neukirchen <leah@vuxu.org>"
license="BSD-2-Clause"
homepage="https://github.com/Yubico/libfido2"
+changelog="https://raw.githubusercontent.com/Yubico/libfido2/main/NEWS"
distfiles="https://github.com/Yubico/libfido2/archive/${version}.tar.gz"
-changelog="https://github.com/Yubico/libfido2/blob/main/NEWS"
checksum=813d6d25116143d16d2e96791718a74825da16b774a8d093d96f06ae1730d9c5
# udev rules used to be shipped by libu2f-host
conf_files="/usr/lib/udev/rules.d/70-u2f.rules"
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules back to 'plugdev', revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (13 preceding siblings ...)
2022-10-08 23:16 ` [PR PATCH] [Updated] " dmarto
@ 2022-10-08 23:19 ` dmarto
2022-10-09 6:08 ` libfido2: add INSTALL.msg, revbump 0x5c
` (7 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-10-08 23:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1272412124
Comment:
In light of my lack of reading skills and not breaking existing users setups, I believe this message should be enough for new users of U2f.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: add INSTALL.msg, revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (14 preceding siblings ...)
2022-10-08 23:19 ` dmarto
@ 2022-10-09 6:08 ` 0x5c
2022-10-09 6:09 ` classabbyamp
` (6 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: 0x5c @ 2022-10-09 6:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
New comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1272464929
Comment:
For reference, udev rules for other features of those security devices (smartcard stuff, etc) [use the `plugdev`+`uaccess` combo](https://github.com/void-linux/void-packages/pull/38037), so with a good INSTALL message and documentation change we could move towards consistency.
Docs-wise the changes would be making the plugdev description better, mentioning examples of device types that are covered by it. I'm also thinking of making a proper docs page for smartcard and security device stuff.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: add INSTALL.msg, revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (15 preceding siblings ...)
2022-10-09 6:08 ` libfido2: add INSTALL.msg, revbump 0x5c
@ 2022-10-09 6:09 ` classabbyamp
2022-10-09 11:30 ` leahneukirchen
` (5 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2022-10-09 6:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1272465074
Comment:
I think the correct direction is to go towards plugdev for things like this
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: add INSTALL.msg, revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (16 preceding siblings ...)
2022-10-09 6:09 ` classabbyamp
@ 2022-10-09 11:30 ` leahneukirchen
2022-11-13 0:30 ` dmarto
` (4 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: leahneukirchen @ 2022-10-09 11:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New comment by leahneukirchen on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1272521589
Comment:
I agree we should go with plugdev.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: add INSTALL.msg, revbump
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (17 preceding siblings ...)
2022-10-09 11:30 ` leahneukirchen
@ 2022-11-13 0:30 ` dmarto
2022-11-13 3:46 ` libfido2: switch udev rules to the `plugdev` group 0x5c
` (3 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: dmarto @ 2022-11-13 0:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
New comment by dmarto on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1312604357
Comment:
Sorry for my absence.
Should the `conf_files` be then also dropped? So that, xbps can overwrite the file, and of course all that be explained in a separate `README.voidlinux`?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules to the `plugdev` group
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (18 preceding siblings ...)
2022-11-13 0:30 ` dmarto
@ 2022-11-13 3:46 ` 0x5c
2022-11-13 15:38 ` CameronNemo
` (2 subsequent siblings)
22 siblings, 0 replies; 24+ messages in thread
From: 0x5c @ 2022-11-13 3:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
New comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1312631913
Comment:
> Should the conf_files be then also dropped?
I would think so, the file isn't supposed to be modified (don't take my word for it though)
Should the `libu2f-{host,server}` packages even be kept? Both are deprecated upstream and don't seem to have any reverse dependencies, and haven't had updates in a long while (going through multiple rebuilds for various shlibdeps). `libu2f-host`'s github repo has been archived.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules to the `plugdev` group
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (19 preceding siblings ...)
2022-11-13 3:46 ` libfido2: switch udev rules to the `plugdev` group 0x5c
@ 2022-11-13 15:38 ` CameronNemo
2023-02-12 2:01 ` github-actions
2023-02-26 2:06 ` [PR PATCH] [Closed]: " github-actions
22 siblings, 0 replies; 24+ messages in thread
From: CameronNemo @ 2022-11-13 15:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1312759024
Comment:
>Should the libu2f-{host,server} packages even be kept? Both are deprecated upstream and don't seem to have any reverse dependencies, and haven't had updates in a long while (going through multiple rebuilds for various shlibdeps). libu2f-host's github repo has been archived.
Probably off-topic for this PR. Removal can be done in a separate PR more easily. Along with, perhaps, a discussion to remove the package or make it a dummy package depending on libfido2.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: libfido2: switch udev rules to the `plugdev` group
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (20 preceding siblings ...)
2022-11-13 15:38 ` CameronNemo
@ 2023-02-12 2:01 ` github-actions
2023-02-26 2:06 ` [PR PATCH] [Closed]: " github-actions
22 siblings, 0 replies; 24+ messages in thread
From: github-actions @ 2023-02-12 2:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/39688#issuecomment-1426920563
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Closed]: libfido2: switch udev rules to the `plugdev` group
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
` (21 preceding siblings ...)
2023-02-12 2:01 ` github-actions
@ 2023-02-26 2:06 ` github-actions
22 siblings, 0 replies; 24+ messages in thread
From: github-actions @ 2023-02-26 2:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
There's a closed pull request on the void-packages repository
libfido2: switch udev rules to the `plugdev` group
https://github.com/void-linux/void-packages/pull/39688
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86-64_glibc)
@leahneukirchen
Embarrassingly, I spent a lot of time wondering why my U2F was not showing and then I noticed this switch in the template.
Most other rules shipped by void, use `plugdev`, and the current docs imply that it should be `plugdev`.
```
plugdev | Access to pluggable devices.
users | Ordinary users.
```
from https://docs.voidlinux.org/config/users-and-groups.html
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2023-02-26 2:06 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-04 0:48 [PR PATCH] libfido2: switch udev rules back to 'plugdev', revbump dmarto
2022-10-04 0:55 ` classabbyamp
2022-10-04 1:11 ` dmarto
2022-10-04 1:12 ` dmarto
2022-10-04 2:07 ` 0x5c
2022-10-04 12:35 ` dmarto
2022-10-04 12:52 ` leahneukirchen
2022-10-04 13:12 ` dmarto
2022-10-04 15:16 ` classabbyamp
2022-10-04 15:56 ` dmarto
2022-10-04 16:14 ` dmarto
2022-10-05 14:47 ` CameronNemo
2022-10-08 22:54 ` dmarto
2022-10-08 22:57 ` dmarto
2022-10-08 23:16 ` [PR PATCH] [Updated] " dmarto
2022-10-08 23:19 ` dmarto
2022-10-09 6:08 ` libfido2: add INSTALL.msg, revbump 0x5c
2022-10-09 6:09 ` classabbyamp
2022-10-09 11:30 ` leahneukirchen
2022-11-13 0:30 ` dmarto
2022-11-13 3:46 ` libfido2: switch udev rules to the `plugdev` group 0x5c
2022-11-13 15:38 ` CameronNemo
2023-02-12 2:01 ` github-actions
2023-02-26 2:06 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).