[PR PATCH] glab: add shell completions

[PR PATCH] glab: add shell completions

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages glab-1.22.0_2
https://github.com/void-linux/void-packages/pull/39880

glab: add shell completions
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39880.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-glab-1.22.0_2-39880.patch --]
[-- Type: text/x-diff, Size: 1324 bytes --]

From 89eb014fea3a7547881f80f45d98630429d88ec3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Tue, 11 Oct 2022 10:32:22 +0200
Subject: [PATCH] glab: add shell completions

---
 srcpkgs/glab/template | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/glab/template b/srcpkgs/glab/template
index b050f7bebb65..bf1842ed1229 100644
--- a/srcpkgs/glab/template
+++ b/srcpkgs/glab/template
@@ -1,9 +1,10 @@
 # Template file for 'glab'
 pkgname=glab
 version=1.22.0
-revision=1
+revision=2
 wrksrc="cli-v$version"
 build_style=go
+build_helper=qemu
 go_ldflags="-X main.version=$version"
 go_import_path=github.com/profclems/glab
 go_package="${go_import_path}/cmd/glab"
@@ -13,7 +14,18 @@ license="MIT"
 homepage="https://gitlab.com/gitlab-org/cli"
 distfiles="https://gitlab.com/gitlab-org/cli/-/archive/v$version/cli-v$version.tar.gz"
 checksum=4d9bceb6818c8bf9f681119dae3a65f1c895fa21e9da6b38e8f88d245f524e10
+_completions="bash zsh fish"
+
+post_build() {
+	local cli=$(find $GOPATH/bin -name glab)
+	for shell in $_completions; do
+		vtargetrun $cli completion $shell > "glab.${shell}"
+	done
+}
 
 post_install() {
 	vlicense LICENSE
+	for shell in $_completions; do
+		vcompletion "glab.${shell}" $shell glab
+	done
 }

Re: [PR PATCH] [Updated] glab: add shell completions

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages glab-1.22.0_2
https://github.com/void-linux/void-packages/pull/39880

glab: add shell completions
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/39880.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-glab-1.22.0_2-39880.patch --]
[-- Type: text/x-diff, Size: 1327 bytes --]

From 4c0c000750d2981534137f25f9ad1bbb2064b135 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Tue, 11 Oct 2022 10:32:22 +0200
Subject: [PATCH] glab: add shell completions

---
 srcpkgs/glab/template | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/glab/template b/srcpkgs/glab/template
index b050f7bebb65..3af1d018c61a 100644
--- a/srcpkgs/glab/template
+++ b/srcpkgs/glab/template
@@ -1,9 +1,10 @@
 # Template file for 'glab'
 pkgname=glab
 version=1.22.0
-revision=1
+revision=2
 wrksrc="cli-v$version"
 build_style=go
+build_helper=qemu
 go_ldflags="-X main.version=$version"
 go_import_path=github.com/profclems/glab
 go_package="${go_import_path}/cmd/glab"
@@ -13,7 +14,18 @@ license="MIT"
 homepage="https://gitlab.com/gitlab-org/cli"
 distfiles="https://gitlab.com/gitlab-org/cli/-/archive/v$version/cli-v$version.tar.gz"
 checksum=4d9bceb6818c8bf9f681119dae3a65f1c895fa21e9da6b38e8f88d245f524e10
+_completions="bash zsh fish"
+
+post_build() {
+	local cli=$(find $GOPATH/bin -name glab)
+	for shell in $_completions; do
+		vtargetrun $cli completion -s $shell > "glab.${shell}"
+	done
+}
 
 post_install() {
 	vlicense LICENSE
+	for shell in $_completions; do
+		vcompletion "glab.${shell}" $shell glab
+	done
 }

Re: glab: add shell completions

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/39880#issuecomment-1313556240

Comment:
considering this didn't work out as expected I'll close this for now

Re: [PR PATCH] [Closed]: glab: add shell completions

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

There's a closed pull request on the void-packages repository

glab: add shell completions
https://github.com/void-linux/void-packages/pull/39880

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**, but the verdict was that it does not work for me right now on zsh. Not quite sure why, maybe someone else can have a look? The completions are generated, they are written out to the correct place. cc @Gottox 

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->