[PR PATCH] WIP NetworkManager-openconnect: update to 1.2.8

[PR PATCH] WIP NetworkManager-openconnect: update to 1.2.8

[atk]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

There is a new pull request by atk against master on the void-packages repository

https://github.com/atk/void-packages networkmanager-openconnect-1.2.8
https://github.com/void-linux/void-packages/pull/39947

WIP NetworkManager-openconnect: update to 1.2.8
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/39947.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-openconnect-1.2.8-39947.patch --]
[-- Type: text/x-diff, Size: 1740 bytes --]

From 1af5be9ed1eea5b6ae6299a1008b00fe0e2e24de Mon Sep 17 00:00:00 2001
From: Alex Lohr <alexthkloss@web.de>
Date: Fri, 14 Oct 2022 10:33:05 +0200
Subject: [PATCH] NetworkManager-openconnect: update to 1.2.8

---
 srcpkgs/NetworkManager-openconnect/template | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/NetworkManager-openconnect/template b/srcpkgs/NetworkManager-openconnect/template
index e2bf803ac0e9..d7db26110ff1 100644
--- a/srcpkgs/NetworkManager-openconnect/template
+++ b/srcpkgs/NetworkManager-openconnect/template
@@ -1,17 +1,21 @@
 # Template file for 'NetworkManager-openconnect'
 pkgname=NetworkManager-openconnect
-version=1.2.6
-revision=4
+version=1.2.8
+revision=1
 build_style=gnu-configure
-configure_args="--disable-static"
+configure_args="--disable-static --with-gtk4"
 hostmakedepends="pkg-config intltool"
-makedepends="gcr-devel gtk+3-devel liblz4-devel libnma-devel
- openssl-devel libsecret-devel libxml2-devel openconnect-devel"
-depends="openconnect"
+makedepends="gcr-devel gtk4-devel liblz4-devel libnma-devel
+ openssl-devel libsecret-devel libxml2-devel openconnect-devel webkit2gtk-devel"
+depends="openconnect libnma webkit2gtk"
 short_desc="NetworkManager VPN plugin for OpenConnect"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/NetworkManager"
 distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=95109803596a9782680a5dca3b51c4ad8ff7e126169d5431278cab694112975a
+checksum=5dedaa785d82d8e239ddd082bfac5250c691e964464be1807b6827263633cdcc
 lib32disabled=yes
+
+post_configure() {
+  chmod a+rw properties/gresource.xml
+}

Re: [PR REVIEW] WIP NetworkManager-openconnect: update to 1.2.8

[paper42]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39947#discussion_r995525871

Comment:
webkit2gtk uses gtk3, this program gtk4 and mixing them does not work. You might want to wait for #39488 and then use libwebkit2gtk50

Re: [PR REVIEW] WIP NetworkManager-openconnect: update to 1.2.8

[atk]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/39947#discussion_r995527135

Comment:
Strange enough, it works locally. Building with gtk3 produces build erorrs.

Re: [PR PATCH] [Updated] WIP NetworkManager-openconnect: update to 1.2.8

[atk]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

There is an updated pull request by atk against master on the void-packages repository

https://github.com/atk/void-packages networkmanager-openconnect-1.2.8
https://github.com/void-linux/void-packages/pull/39947

WIP NetworkManager-openconnect: update to 1.2.8
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

A patch file from https://github.com/void-linux/void-packages/pull/39947.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-networkmanager-openconnect-1.2.8-39947.patch --]
[-- Type: text/x-diff, Size: 1739 bytes --]

From e458bb6f674d329b86a061ab195713a308b7e781 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alexthkloss@web.de>
Date: Fri, 14 Oct 2022 10:33:05 +0200
Subject: [PATCH] NetworkManager-openconnect: update to 1.2.8

---
 srcpkgs/NetworkManager-openconnect/template | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/NetworkManager-openconnect/template b/srcpkgs/NetworkManager-openconnect/template
index e2bf803ac0e9..786b72cdfa75 100644
--- a/srcpkgs/NetworkManager-openconnect/template
+++ b/srcpkgs/NetworkManager-openconnect/template
@@ -1,17 +1,21 @@
 # Template file for 'NetworkManager-openconnect'
 pkgname=NetworkManager-openconnect
-version=1.2.6
-revision=4
+version=1.2.8
+revision=1
 build_style=gnu-configure
-configure_args="--disable-static"
+configure_args="--disable-static --with-gtk4"
 hostmakedepends="pkg-config intltool"
-makedepends="gcr-devel gtk+3-devel liblz4-devel libnma-devel
- openssl-devel libsecret-devel libxml2-devel openconnect-devel"
-depends="openconnect"
+makedepends="gcr-devel gtk4-devel liblz4-devel libnma-devel
+ openssl-devel libsecret-devel libxml2-devel openconnect-devel webkit2gtk-devel"
+depends="openconnect libnma webkit2gtk"
 short_desc="NetworkManager VPN plugin for OpenConnect"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/NetworkManager"
 distfiles="${GNOME_SITE}/${pkgname}/${version%.*}/${pkgname}-${version}.tar.xz"
-checksum=95109803596a9782680a5dca3b51c4ad8ff7e126169d5431278cab694112975a
+checksum=5dedaa785d82d8e239ddd082bfac5250c691e964464be1807b6827263633cdcc
 lib32disabled=yes
+
+post_configure() {
+	chmod a+rw properties/gresource.xml
+}

Re: [PR REVIEW] WIP NetworkManager-openconnect: update to 1.2.8

[atk]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/39947#discussion_r995527135

Comment:
Strange enough, it works locally. Building with gtk3 produces build errors.

Re: [PR REVIEW] WIP NetworkManager-openconnect: update to 1.2.8

[paper42]

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/39947#discussion_r995530365

Comment:
hmm, then I guess they might be using gtk3 webkit and gtk4 for different things and not mix them

Re: [PR REVIEW] WIP NetworkManager-openconnect: update to 1.2.8

[atk]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by atk on void-packages repository

https://github.com/void-linux/void-packages/pull/39947#discussion_r995563221

Comment:
The cross-compiled builds are still failing with the same issue that the update to gtk4 fixed on x64.

Re: WIP NetworkManager-openconnect: update to 1.2.8

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/39947#issuecomment-1381238552

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: WIP NetworkManager-openconnect: update to 1.2.8

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]

There's a closed pull request on the void-packages repository

WIP NetworkManager-openconnect: update to 1.2.8
https://github.com/void-linux/void-packages/pull/39947

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->