* [PR PATCH] New package: looking-glass-5.0.1
@ 2022-10-19 3:50 lay-by
2022-10-19 4:48 ` [PR REVIEW] " classabbyamp
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: lay-by @ 2022-10-19 3:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
There is a new pull request by lay-by against master on the void-packages repository
https://github.com/lay-by/void-packages looking-glass-client
https://github.com/void-linux/void-packages/pull/40031
New package: looking-glass-5.0.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/40031.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-looking-glass-client-40031.patch --]
[-- Type: text/x-diff, Size: 1414 bytes --]
From 397e5c7f813cca9e4bd404044809fac85e1081d0 Mon Sep 17 00:00:00 2001
From: lay-by <bean_s@riseup.net>
Date: Tue, 18 Oct 2022 22:25:46 -0500
Subject: [PATCH] added looking-glass
---
srcpkgs/looking-glass/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/looking-glass/template
diff --git a/srcpkgs/looking-glass/template b/srcpkgs/looking-glass/template
new file mode 100644
index 000000000000..b9ce7f13a66b
--- /dev/null
+++ b/srcpkgs/looking-glass/template
@@ -0,0 +1,16 @@
+# Template file for 'looking-glass'
+pkgname=looking-glass
+version=5.0.1
+revision=1
+archs="x86_64"
+wrksrc="$pkgname-B$version/client"
+build_style=cmake
+configure_args="-DENABLE_BACKTRACE=no"
+makedepends="cmake make gcc libglapi libglib-devel nettle-devel gmp-devel fontconfig-devel spice-devel pkg-config libX11-devel libXfixes-devel libXi-devel libXinerama-devel libXcursor-devel libXpresent-devel libxkbcommon-devel libwaylandpp libwaylandpp-devel wayland-protocols dejavu-fonts-ttf libXScrnSaver-devel MesaLib-devel"
+depends="dejavu-fonts-ttf"
+short_desc="Extremely low latency KVMFR for guests with VGA PCI Passthrough"
+maintainer="lay-by <bean_s@riseup.net>"
+license="GPL-2.0-or-later"
+homepage="https://looking-glass.io/"
+distfiles="$homepage/artifact/B$version/source>$pkgname-B$version.tar.gz"
+checksum=15f0c35b195242d6b8087785f76d425e0dffd49ba9d57e26cc26f458973e92cd
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
2022-10-19 4:48 ` [PR REVIEW] " classabbyamp
2022-10-19 4:48 ` classabbyamp
@ 2022-10-19 4:48 ` classabbyamp
2022-10-19 5:14 ` [PR PATCH] [Updated] " lay-by
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-10-19 4:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r998935955
Comment:
```
cmake make gcc
```
already included in the build chroot, don't specify them (gcc: by default; make: not needed, void's cmake defaults to ninja; cmake: already included by the build style)
---
```
pkg-config
```
should be in `hostmakedepends`
---
```
libglapi
```
covered by `MesaLib-devel`
---
```
libwaylandpp dejavu-fonts-ttf
```
are these actually needed at build time?
---
```
libglib-devel nettle-devel gmp-devel fontconfig-devel spice-devel ibX11-devel libXfixes-devel libXi-devel libXinerama-devel libXcursor-devel libXpresent-devel libxkbcommon-devel libwaylandpp-devel libXScrnSaver-devel MesaLib-devel
```
the rest are probably fine
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
@ 2022-10-19 4:48 ` classabbyamp
2022-10-19 4:48 ` classabbyamp
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-10-19 4:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r998931720
Comment:
why?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
2022-10-19 4:48 ` [PR REVIEW] " classabbyamp
@ 2022-10-19 4:48 ` classabbyamp
2022-10-19 4:48 ` classabbyamp
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-10-19 4:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r998937837
Comment:
```suggestion
distfiles="https://looking-glass.io/artifact/B$version/source>$pkgname-$version.tar.gz"
```
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Updated] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (2 preceding siblings ...)
2022-10-19 4:48 ` classabbyamp
@ 2022-10-19 5:14 ` lay-by
2022-10-19 5:18 ` [PR REVIEW] " lay-by
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: lay-by @ 2022-10-19 5:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
There is an updated pull request by lay-by against master on the void-packages repository
https://github.com/lay-by/void-packages looking-glass-client
https://github.com/void-linux/void-packages/pull/40031
New package: looking-glass-5.0.1
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/40031.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-looking-glass-client-40031.patch --]
[-- Type: text/x-diff, Size: 3150 bytes --]
From 397e5c7f813cca9e4bd404044809fac85e1081d0 Mon Sep 17 00:00:00 2001
From: lay-by <bean_s@riseup.net>
Date: Tue, 18 Oct 2022 22:25:46 -0500
Subject: [PATCH 1/2] added looking-glass
---
srcpkgs/looking-glass/template | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 srcpkgs/looking-glass/template
diff --git a/srcpkgs/looking-glass/template b/srcpkgs/looking-glass/template
new file mode 100644
index 000000000000..b9ce7f13a66b
--- /dev/null
+++ b/srcpkgs/looking-glass/template
@@ -0,0 +1,16 @@
+# Template file for 'looking-glass'
+pkgname=looking-glass
+version=5.0.1
+revision=1
+archs="x86_64"
+wrksrc="$pkgname-B$version/client"
+build_style=cmake
+configure_args="-DENABLE_BACKTRACE=no"
+makedepends="cmake make gcc libglapi libglib-devel nettle-devel gmp-devel fontconfig-devel spice-devel pkg-config libX11-devel libXfixes-devel libXi-devel libXinerama-devel libXcursor-devel libXpresent-devel libxkbcommon-devel libwaylandpp libwaylandpp-devel wayland-protocols dejavu-fonts-ttf libXScrnSaver-devel MesaLib-devel"
+depends="dejavu-fonts-ttf"
+short_desc="Extremely low latency KVMFR for guests with VGA PCI Passthrough"
+maintainer="lay-by <bean_s@riseup.net>"
+license="GPL-2.0-or-later"
+homepage="https://looking-glass.io/"
+distfiles="$homepage/artifact/B$version/source>$pkgname-B$version.tar.gz"
+checksum=15f0c35b195242d6b8087785f76d425e0dffd49ba9d57e26cc26f458973e92cd
From 40bbd25c252fac3cccd46376faed6a7b4dfaa415 Mon Sep 17 00:00:00 2001
From: lay-by <bean_s@riseup.net>
Date: Wed, 19 Oct 2022 00:13:37 -0500
Subject: [PATCH 2/2] fixed template issues
---
srcpkgs/looking-glass/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/looking-glass/template b/srcpkgs/looking-glass/template
index b9ce7f13a66b..5895ff01abac 100644
--- a/srcpkgs/looking-glass/template
+++ b/srcpkgs/looking-glass/template
@@ -2,15 +2,15 @@
pkgname=looking-glass
version=5.0.1
revision=1
-archs="x86_64"
wrksrc="$pkgname-B$version/client"
build_style=cmake
configure_args="-DENABLE_BACKTRACE=no"
-makedepends="cmake make gcc libglapi libglib-devel nettle-devel gmp-devel fontconfig-devel spice-devel pkg-config libX11-devel libXfixes-devel libXi-devel libXinerama-devel libXcursor-devel libXpresent-devel libxkbcommon-devel libwaylandpp libwaylandpp-devel wayland-protocols dejavu-fonts-ttf libXScrnSaver-devel MesaLib-devel"
+hostmakedepends="pkg-config"
+makedepends="libglib-devel nettle-devel gmp-devel fontconfig-devel spice-devel libX11-devel libXfixes-devel libXi-devel libXinerama-devel libXcursor-devel libXpresent-devel libxkbcommon-devel libwaylandpp-devel wayland-protocols libXScrnSaver-devel MesaLib-devel"
depends="dejavu-fonts-ttf"
short_desc="Extremely low latency KVMFR for guests with VGA PCI Passthrough"
maintainer="lay-by <bean_s@riseup.net>"
license="GPL-2.0-or-later"
homepage="https://looking-glass.io/"
-distfiles="$homepage/artifact/B$version/source>$pkgname-B$version.tar.gz"
+distfiles="https://looking-glass.io/artifact/B$version/source>$pkgname-B$version.tar.gz"
checksum=15f0c35b195242d6b8087785f76d425e0dffd49ba9d57e26cc26f458973e92cd
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (3 preceding siblings ...)
2022-10-19 5:14 ` [PR PATCH] [Updated] " lay-by
@ 2022-10-19 5:18 ` lay-by
2023-01-18 2:00 ` github-actions
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: lay-by @ 2022-10-19 5:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
New review comment by lay-by on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r998951287
Comment:
I changed all of the parts you mentioned, thanks for your help and patience.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (4 preceding siblings ...)
2022-10-19 5:18 ` [PR REVIEW] " lay-by
@ 2023-01-18 2:00 ` github-actions
2023-01-20 22:48 ` [PR REVIEW] " JamiKettunen
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: github-actions @ 2023-01-18 2:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#issuecomment-1386357256
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (6 preceding siblings ...)
2023-01-20 22:48 ` [PR REVIEW] " JamiKettunen
@ 2023-01-20 22:48 ` JamiKettunen
2023-01-20 22:48 ` JamiKettunen
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: JamiKettunen @ 2023-01-20 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r1083055253
Comment:
Please wrap at 80 characters with one space at the beginning of new lines which continue the string
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (7 preceding siblings ...)
2023-01-20 22:48 ` JamiKettunen
@ 2023-01-20 22:48 ` JamiKettunen
2023-01-20 22:48 ` JamiKettunen
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: JamiKettunen @ 2023-01-20 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r1083056205
Comment:
Please update to https://github.com/gnif/LookingGlass/releases/tag/B6 :)
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (5 preceding siblings ...)
2023-01-18 2:00 ` github-actions
@ 2023-01-20 22:48 ` JamiKettunen
2023-01-20 22:48 ` JamiKettunen
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: JamiKettunen @ 2023-01-20 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r1083111653
Comment:
`$pkgname` -> `looking-glass`
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (8 preceding siblings ...)
2023-01-20 22:48 ` JamiKettunen
@ 2023-01-20 22:48 ` JamiKettunen
2023-01-21 2:11 ` JamiKettunen
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: JamiKettunen @ 2023-01-20 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r1083053923
Comment:
Drop whole `wrksrc` line, it's guessed guessed automatically now and ignored; I believe `build_wrksrc="client"` should do the trick now
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (9 preceding siblings ...)
2023-01-20 22:48 ` JamiKettunen
@ 2023-01-21 2:11 ` JamiKettunen
2023-01-21 2:12 ` JamiKettunen
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: JamiKettunen @ 2023-01-21 2:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 280 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r1083053923
Comment:
Drop whole `wrksrc` line, it's now guessed automatically and ignored; I believe `build_wrksrc="client"` should do the trick now
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR REVIEW] New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (10 preceding siblings ...)
2023-01-21 2:11 ` JamiKettunen
@ 2023-01-21 2:12 ` JamiKettunen
2023-04-22 1:53 ` github-actions
2023-05-07 1:56 ` [PR PATCH] [Closed]: " github-actions
13 siblings, 0 replies; 15+ messages in thread
From: JamiKettunen @ 2023-01-21 2:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
New review comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#discussion_r1083053923
Comment:
Drop whole `wrksrc` line, it's now guessed automatically and ignored in templates; I believe `build_wrksrc="client"` should do the trick now
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (11 preceding siblings ...)
2023-01-21 2:12 ` JamiKettunen
@ 2023-04-22 1:53 ` github-actions
2023-05-07 1:56 ` [PR PATCH] [Closed]: " github-actions
13 siblings, 0 replies; 15+ messages in thread
From: github-actions @ 2023-04-22 1:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/40031#issuecomment-1518465969
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Closed]: New package: looking-glass-5.0.1
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
` (12 preceding siblings ...)
2023-04-22 1:53 ` github-actions
@ 2023-05-07 1:56 ` github-actions
13 siblings, 0 replies; 15+ messages in thread
From: github-actions @ 2023-05-07 1:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
There's a closed pull request on the void-packages repository
New package: looking-glass-5.0.1
https://github.com/void-linux/void-packages/pull/40031
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2023-05-07 1:56 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-19 3:50 [PR PATCH] New package: looking-glass-5.0.1 lay-by
2022-10-19 4:48 ` [PR REVIEW] " classabbyamp
2022-10-19 4:48 ` classabbyamp
2022-10-19 4:48 ` classabbyamp
2022-10-19 5:14 ` [PR PATCH] [Updated] " lay-by
2022-10-19 5:18 ` [PR REVIEW] " lay-by
2023-01-18 2:00 ` github-actions
2023-01-20 22:48 ` [PR REVIEW] " JamiKettunen
2023-01-20 22:48 ` JamiKettunen
2023-01-20 22:48 ` JamiKettunen
2023-01-20 22:48 ` JamiKettunen
2023-01-21 2:11 ` JamiKettunen
2023-01-21 2:12 ` JamiKettunen
2023-04-22 1:53 ` github-actions
2023-05-07 1:56 ` [PR PATCH] [Closed]: " github-actions
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).