[PR PATCH] New package: dotool-1.0

[PR PATCH] New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

There is a new pull request by JohnGebbie against master on the void-packages repository

https://github.com/JohnGebbie/void-packages dotool
https://github.com/void-linux/void-packages/pull/40115

New package: dotool-1.0
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - aarch64-musl cross
  - armv7l cross

I was packaging ydotool (https://github.com/void-linux/void-packages/pull/39920),
which was a dependency of my program (https://github.com/void-linux/void-packages/pull/39716),
but it was requiring enough patching that I didn't want to depend on it and so I wrote dotool.


A patch file from https://github.com/void-linux/void-packages/pull/40115.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dotool-40115.patch --]
[-- Type: text/x-diff, Size: 2769 bytes --]

From 3ab7847e00fa79dca99adda63b6be5272bb538ea Mon Sep 17 00:00:00 2001
From: John Gebbie <me@johngebbie.com>
Date: Sat, 22 Oct 2022 19:27:12 +0100
Subject: [PATCH] New package: dotool-1.0

---
 srcpkgs/dotool/INSTALL.msg           |  6 ++++++
 srcpkgs/dotool/files/80-dotool.rules |  2 ++
 srcpkgs/dotool/files/dotoold/log/run |  2 ++
 srcpkgs/dotool/files/dotoold/run     |  3 +++
 srcpkgs/dotool/template              | 20 ++++++++++++++++++++
 5 files changed, 33 insertions(+)
 create mode 100644 srcpkgs/dotool/INSTALL.msg
 create mode 100644 srcpkgs/dotool/files/80-dotool.rules
 create mode 100755 srcpkgs/dotool/files/dotoold/log/run
 create mode 100755 srcpkgs/dotool/files/dotoold/run
 create mode 100644 srcpkgs/dotool/template

diff --git a/srcpkgs/dotool/INSTALL.msg b/srcpkgs/dotool/INSTALL.msg
new file mode 100644
index 000000000000..3f3355925de7
--- /dev/null
+++ b/srcpkgs/dotool/INSTALL.msg
@@ -0,0 +1,6 @@
+A udev rule has been added to allow users in group input to use dotool
+without root permissions.  You can make it effective without rebooting
+by running:
+
+	$ sudo udevadm trigger
+
diff --git a/srcpkgs/dotool/files/80-dotool.rules b/srcpkgs/dotool/files/80-dotool.rules
new file mode 100644
index 000000000000..68ccfa8a279e
--- /dev/null
+++ b/srcpkgs/dotool/files/80-dotool.rules
@@ -0,0 +1,2 @@
+# This allows users in group input to use dotool without root permissions.
+KERNEL=="uinput", GROUP="input", MODE="0660"
diff --git a/srcpkgs/dotool/files/dotoold/log/run b/srcpkgs/dotool/files/dotoold/log/run
new file mode 100755
index 000000000000..762ba9e6cc26
--- /dev/null
+++ b/srcpkgs/dotool/files/dotoold/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -p daemon.info -t dotoold
diff --git a/srcpkgs/dotool/files/dotoold/run b/srcpkgs/dotool/files/dotoold/run
new file mode 100755
index 000000000000..4f8205c123e0
--- /dev/null
+++ b/srcpkgs/dotool/files/dotoold/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -u _dotoold:input dotoold
diff --git a/srcpkgs/dotool/template b/srcpkgs/dotool/template
new file mode 100644
index 000000000000..3a768f200837
--- /dev/null
+++ b/srcpkgs/dotool/template
@@ -0,0 +1,20 @@
+# Template file for 'dotool'
+pkgname=dotool
+version=1.0
+revision=1
+build_style=go
+go_import_path="git.sr.ht/~geb/dotool"
+short_desc="Command to simulate input anywhere (X11, Wayland, TTYs)"
+maintainer="John Gebbie <me@johngebbie.com>"
+license="GPL-3.0-only"
+homepage="https://sr.ht/~geb/dotool"
+distfiles="https://git.sr.ht/~geb/dotool/archive/${version}.tar.gz"
+checksum=3821dc2f7ef2483cd8e74857bb0f37986176e951a19e16b15f3ceedc11b10e44
+system_accounts="_dotoold"
+
+post_install() {
+	vbin dotoolc
+	vbin dotoold
+	vsv dotoold
+	vinstall "${FILESDIR}/80-dotool.rules" 644 usr/lib/udev/rules.d
+}

Re: [PR REVIEW] New package: dotool-1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1002569054

Comment:
this is something general enough that you should maybe include it upstream for other distro packages

Re: [PR REVIEW] New package: dotool-1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1002568859

Comment:
not necessary, this isn't specific to void. maybe you'd want to add this to your documentation upstream.

Re: [PR REVIEW] New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by JohnGebbie on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1002570206

Comment:
okay thank you I'll sleep on it.

Re: [PR REVIEW] New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by JohnGebbie on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1002678325

Comment:
Do you think a more specific group would be better? I was thinking "**u**input" but maybe even "dotool"?

Re: [PR REVIEW] New package: dotool-1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1002745843

Comment:
input is a fairly standard name across distros. I think systemd distros have it by default, with the same purpose as void's input group

Re: [PR REVIEW] New package: dotool-1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1002745989

Comment:
in fact, there might already be a udev rule that does this maybe? 

Re: [PR REVIEW] New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

New review comment by JohnGebbie on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1002778167

Comment:
If I remove the rule and reboot it doesn't work so I don't think there's a rule already.

My reasoning for a uinput group was just because access to /dev/uinput is less of a big deal than to /dev/input, and so you wouldn't need to give a user as big a permission.
Maybe I should do both? then it'd just work for everyone in input too.

Re: [PR REVIEW] New package: dotool-1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1002779453

Comment:
i'd go with the [existing system group](https://docs.voidlinux.org/config/users-and-groups.html#default-groups), input

Re: [PR PATCH] [Updated] New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

There is an updated pull request by JohnGebbie against master on the void-packages repository

https://github.com/JohnGebbie/void-packages dotool
https://github.com/void-linux/void-packages/pull/40115

New package: dotool-1.0
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - aarch64-musl cross
  - armv7l cross

I was packaging ydotool (https://github.com/void-linux/void-packages/pull/39920),
which was a dependency of my program (https://github.com/void-linux/void-packages/pull/39716),
but it was requiring enough patching that I didn't want to depend on it and so I wrote dotool.


A patch file from https://github.com/void-linux/void-packages/pull/40115.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dotool-40115.patch --]
[-- Type: text/x-diff, Size: 1845 bytes --]

From 7e23e8fda4b88f52e021cea8c6d627ae4eda9c4d Mon Sep 17 00:00:00 2001
From: John Gebbie <me@johngebbie.com>
Date: Sat, 22 Oct 2022 19:27:12 +0100
Subject: [PATCH] New package: dotool-1.0

---
 srcpkgs/dotool/files/dotoold/log/run |  2 ++
 srcpkgs/dotool/files/dotoold/run     |  3 +++
 srcpkgs/dotool/template              | 20 ++++++++++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100755 srcpkgs/dotool/files/dotoold/log/run
 create mode 100755 srcpkgs/dotool/files/dotoold/run
 create mode 100644 srcpkgs/dotool/template

diff --git a/srcpkgs/dotool/files/dotoold/log/run b/srcpkgs/dotool/files/dotoold/log/run
new file mode 100755
index 000000000000..762ba9e6cc26
--- /dev/null
+++ b/srcpkgs/dotool/files/dotoold/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -p daemon.info -t dotoold
diff --git a/srcpkgs/dotool/files/dotoold/run b/srcpkgs/dotool/files/dotoold/run
new file mode 100755
index 000000000000..4f8205c123e0
--- /dev/null
+++ b/srcpkgs/dotool/files/dotoold/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -u _dotoold:input dotoold
diff --git a/srcpkgs/dotool/template b/srcpkgs/dotool/template
new file mode 100644
index 000000000000..c52d51753beb
--- /dev/null
+++ b/srcpkgs/dotool/template
@@ -0,0 +1,20 @@
+# Template file for 'dotool'
+pkgname=dotool
+version=1.0
+revision=1
+build_style=go
+go_import_path="git.sr.ht/~geb/dotool"
+short_desc="Command to simulate input anywhere (X11, Wayland, TTYs)"
+maintainer="John Gebbie <me@johngebbie.com>"
+license="GPL-3.0-only"
+homepage="https://sr.ht/~geb/dotool"
+distfiles="https://git.sr.ht/~geb/dotool/archive/${version}.tar.gz"
+checksum=084e2a15fbe7473a76fa159db66695359c339e69259793ad85bcb7fb2979254c
+system_accounts="_dotoold"
+
+post_install() {
+	vbin dotoolc
+	vbin dotoold
+	vsv dotoold
+	vinstall 80-dotool.rules 644 usr/lib/udev/rules.d
+}

Re: [PR REVIEW] New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by JohnGebbie on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#discussion_r1003148780

Comment:
i followed your advice

Re: [PR PATCH] [Updated] New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

There is an updated pull request by JohnGebbie against master on the void-packages repository

https://github.com/JohnGebbie/void-packages dotool
https://github.com/void-linux/void-packages/pull/40115

New package: dotool-1.0
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - aarch64-musl cross
  - armv7l cross

I was packaging ydotool (https://github.com/void-linux/void-packages/pull/39920),
which was a dependency of my program (https://github.com/void-linux/void-packages/pull/39716),
but it was requiring enough patching that I didn't want to depend on it and so I wrote dotool.


A patch file from https://github.com/void-linux/void-packages/pull/40115.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dotool-40115.patch --]
[-- Type: text/x-diff, Size: 1845 bytes --]

From 2ca935d1bbcc99d655ec057d93235904c8059cec Mon Sep 17 00:00:00 2001
From: John Gebbie <me@johngebbie.com>
Date: Sat, 22 Oct 2022 19:27:12 +0100
Subject: [PATCH] New package: dotool-1.0

---
 srcpkgs/dotool/files/dotoold/log/run |  2 ++
 srcpkgs/dotool/files/dotoold/run     |  3 +++
 srcpkgs/dotool/template              | 20 ++++++++++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100755 srcpkgs/dotool/files/dotoold/log/run
 create mode 100755 srcpkgs/dotool/files/dotoold/run
 create mode 100644 srcpkgs/dotool/template

diff --git a/srcpkgs/dotool/files/dotoold/log/run b/srcpkgs/dotool/files/dotoold/log/run
new file mode 100755
index 000000000000..762ba9e6cc26
--- /dev/null
+++ b/srcpkgs/dotool/files/dotoold/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -p daemon.info -t dotoold
diff --git a/srcpkgs/dotool/files/dotoold/run b/srcpkgs/dotool/files/dotoold/run
new file mode 100755
index 000000000000..4f8205c123e0
--- /dev/null
+++ b/srcpkgs/dotool/files/dotoold/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -u _dotoold:input dotoold
diff --git a/srcpkgs/dotool/template b/srcpkgs/dotool/template
new file mode 100644
index 000000000000..dd9c871b851e
--- /dev/null
+++ b/srcpkgs/dotool/template
@@ -0,0 +1,20 @@
+# Template file for 'dotool'
+pkgname=dotool
+version=1.0
+revision=1
+build_style=go
+go_import_path="git.sr.ht/~geb/dotool"
+short_desc="Command to simulate input anywhere (X11, Wayland, TTYs)"
+maintainer="John Gebbie <me@johngebbie.com>"
+license="GPL-3.0-only"
+homepage="https://sr.ht/~geb/dotool"
+distfiles="https://git.sr.ht/~geb/dotool/archive/${version}.tar.gz"
+checksum=a92ca63f177df095cba5b7f15fe3512559a815d756c6121897a655385994d870
+system_accounts="_dotoold"
+
+post_install() {
+	vbin dotoolc
+	vbin dotoold
+	vsv dotoold
+	vinstall 80-dotool.rules 644 usr/lib/udev/rules.d
+}

Re: [PR PATCH] [Updated] New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

There is an updated pull request by JohnGebbie against master on the void-packages repository

https://github.com/JohnGebbie/void-packages dotool
https://github.com/void-linux/void-packages/pull/40115

New package: dotool-1.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - aarch64-musl cross
  - armv7l cross

I was packaging ydotool (https://github.com/void-linux/void-packages/pull/39920),
which was a dependency of my program (https://github.com/void-linux/void-packages/pull/39716),
but it was requiring enough patching that I didn't want to depend on it and so I wrote dotool.


A patch file from https://github.com/void-linux/void-packages/pull/40115.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dotool-40115.patch --]
[-- Type: text/x-diff, Size: 1845 bytes --]

From 7608d02d9d48cffe507f01c5a1c8d5a59a2f96f2 Mon Sep 17 00:00:00 2001
From: John Gebbie <me@johngebbie.com>
Date: Sat, 22 Oct 2022 19:27:12 +0100
Subject: [PATCH] New package: dotool-1.0

---
 srcpkgs/dotool/files/dotoold/log/run |  2 ++
 srcpkgs/dotool/files/dotoold/run     |  3 +++
 srcpkgs/dotool/template              | 20 ++++++++++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100755 srcpkgs/dotool/files/dotoold/log/run
 create mode 100755 srcpkgs/dotool/files/dotoold/run
 create mode 100644 srcpkgs/dotool/template

diff --git a/srcpkgs/dotool/files/dotoold/log/run b/srcpkgs/dotool/files/dotoold/log/run
new file mode 100755
index 000000000000..762ba9e6cc26
--- /dev/null
+++ b/srcpkgs/dotool/files/dotoold/log/run
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec vlogger -p daemon.info -t dotoold
diff --git a/srcpkgs/dotool/files/dotoold/run b/srcpkgs/dotool/files/dotoold/run
new file mode 100755
index 000000000000..4f8205c123e0
--- /dev/null
+++ b/srcpkgs/dotool/files/dotoold/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -u _dotoold:input dotoold
diff --git a/srcpkgs/dotool/template b/srcpkgs/dotool/template
new file mode 100644
index 000000000000..ab1c583b2870
--- /dev/null
+++ b/srcpkgs/dotool/template
@@ -0,0 +1,20 @@
+# Template file for 'dotool'
+pkgname=dotool
+version=1.0
+revision=1
+build_style=go
+go_import_path="git.sr.ht/~geb/dotool"
+short_desc="Command to simulate input anywhere (X11, Wayland, TTYs)"
+maintainer="John Gebbie <me@johngebbie.com>"
+license="GPL-3.0-only"
+homepage="https://sr.ht/~geb/dotool"
+distfiles="https://git.sr.ht/~geb/dotool/archive/${version}.tar.gz"
+checksum=b73097f0c7be22e318e8ee446aed8291693a7198d335a82ca624a5887fe8d16d
+system_accounts="_dotoold"
+
+post_install() {
+	vbin dotoolc
+	vbin dotoold
+	vsv dotoold
+	vinstall 80-dotool.rules 644 usr/lib/udev/rules.d
+}

Re: New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by JohnGebbie on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#issuecomment-1292258701

Comment:
That's it ready to merge

Re: [PR PATCH] [Merged]: New package: dotool-1.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

There's a merged pull request on the void-packages repository

New package: dotool-1.0
https://github.com/void-linux/void-packages/pull/40115

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
  - aarch64-musl cross
  - armv7l cross

I was packaging ydotool (https://github.com/void-linux/void-packages/pull/39920),
which was a dependency of my program (https://github.com/void-linux/void-packages/pull/39716),
but it was requiring enough patching that I didn't want to depend on it and so I wrote dotool.

Re: New package: dotool-1.0

[JohnGebbie]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New comment by JohnGebbie on void-packages repository

https://github.com/void-linux/void-packages/pull/40115#issuecomment-1292440688

Comment:
Thank you!