[PR PATCH] Update gap to 4.12.1

[PR PATCH] Update gap to 4.12.1

[fingolfin]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

There is a new pull request by fingolfin against master on the void-packages repository

https://github.com/fingolfin/void-packages patch-1
https://github.com/void-linux/void-packages/pull/40208

Update gap to 4.12.1
#### Testing the changes
- I tested the changes in this PR: **NO**

CC @tornaria 

A patch file from https://github.com/void-linux/void-packages/pull/40208.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-40208.patch --]
[-- Type: text/x-diff, Size: 2037 bytes --]

From b42d38fa44208a67c0f057a16850a259b9397915 Mon Sep 17 00:00:00 2001
From: Max Horn <max@quendi.de>
Date: Fri, 28 Oct 2022 22:51:45 +0200
Subject: [PATCH] Update gap to 4.12.1

---
 srcpkgs/gap/template | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/gap/template b/srcpkgs/gap/template
index 7bc7d13ace20..f500d184dd26 100644
--- a/srcpkgs/gap/template
+++ b/srcpkgs/gap/template
@@ -1,17 +1,17 @@
 # Template file for 'gap'
 pkgname=gap
-version=4.11.1
+version=4.12.1
 revision=1
 build_style=gnu-configure
-make_install_target="install-bin install-gaproot install-headers install-libgap"
+make_install_target="install"
 makedepends="gmp-devel zlib-devel readline-devel"
 checkdepends="perl"
 short_desc="Groups, Algorithms, Programming - computational discrete algebra"
 maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
 license="GPL-2.0-or-later"
-homepage="http://www.gap-system.org/"
+homepage="https://www.gap-system.org/"
 distfiles="https://github.com/gap-system/gap/releases/download/v${version}/gap-${version}.tar.gz"
-checksum=6635c5da7d82755f8339486b9cac33766f58712f297e8234fba40818902ea304
+checksum=f9ebef11ee31b210ce36e3c70960742b4e253282bbd5270adc9324273c92b016
 
 if [ "$XBPS_CHECK_PKGS" = full ]; then
 	# not sure about this -- takes about 25 minutes
@@ -21,11 +21,11 @@ fi
 _GAPROOT=/usr/share/gap/
 
 # minimal required packages
-_GAPPKGS="GAPDoc primgrp SmallGrp transgrp"
+_GAPPKGS="gapdoc primgrp smallgrp transgrp"
 
 # other expected packages
-_GAPPKGS+=" atlasrep autpgrp alnuth crisp ctbllib FactInt fga irredsol laguna
- polenta polycyclic resclasses sophus tomlib"
+_GAPPKGS+=" atlasrep autpgrp alnuth crisp ctbllib factint fga irredsol laguna
+ polenta polycyclic resclasses sophus tomlib utils"
 
 post_install() {
 	vmkdir ${_GAPROOT}/pkg
@@ -33,8 +33,6 @@ post_install() {
 		[ -d pkg/$p ] || p="$p-*"
 		vcopy "pkg/$p" ${_GAPROOT}/pkg
 	done
-	# not handled by make install-headers
-	vcopy gen/config.h /usr/include/gap
 }
 
 gap-devel_package() {

Re: Update gap to 4.12.1

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/40208#issuecomment-1295473021

Comment:
@fingolfin Thanks: I have an update to 4.12.1 as part of #39876, with make check passing. Should be merged soon.

Re: Update gap to 4.12.1

[fingolfin]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by fingolfin on void-packages repository

https://github.com/void-linux/void-packages/pull/40208#issuecomment-1295624662

Comment:
@tornaria that PR seems to use 4.12.0, not 4.12.1?

Re: Update gap to 4.12.1

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/40208#issuecomment-1295655802

Comment:
> @tornaria that PR seems to use 4.12.0, not 4.12.1?

It seems I didn't push that but I have 4.12.1 working. I'll soon push an update to #39876 with this.

Re: Update gap to 4.12.1

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1926 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/40208#issuecomment-1295799628

Comment:
@fingolfin: you can see my update from gap 4.11.1 to 4.12.1 here https://github.com/void-linux/void-packages/pull/39876/files#diff-d5e8ac4c14235608656fe702205ba0e985de306ecc14756391643152370bfbd3

Differences from yours:
 - I had to add `autodoc` and `radiroot` pkgs that are needed for some installed packages.
 - I added a check for missing packages (meaning `./xbps-src check` will try to run gap and `LoadPackage(pkg)` for each package and complain on failure).
 - I added a patch to the testsuite so it passes without trying to hit the network (which fails since neither `curl` nor `wget` nor the `io` package are installed), so check passes.

Now I'm having trouble with sagemath  b/c of the same thing with download. There are 8 doctests failed in sage (--long) testsuite. All of them because a warning is printed (No download method is available, etc). However, the actual answers are always correct, so the download is not really needed (???).

I can think two ways forward
a. configure atlasrep to not download anything by default (how would I do that?)
b. have a data package installed in the system that contains all the stuff atlasrep might want to download. I think an issue is that the data packages are not versioned so it would be hard to keep up to date, etc.

Do you know why atlasrep is trying to download something that is not necessary to give the correct answer? What would be missing without this feature? Note that the feature won't work in a system install of gap anyway since the package wants to place the files in a system directory (there's no way we can ship a 1777 directory in `/usr` as the installer wants -- this feature can only work if the downloaded files are placed in the user homedir, preferably in `$XDG_CACHE_HOME` or similar).

Re: Update gap to 4.12.1

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/40208#issuecomment-1295804843

Comment:
@tornaria Please pull any relevant differences into your sage PR.

Re: [PR PATCH] [Closed]: Update gap to 4.12.1

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

There's a closed pull request on the void-packages repository

Update gap to 4.12.1
https://github.com/void-linux/void-packages/pull/40208

Description:
#### Testing the changes
- I tested the changes in this PR: **NO**

CC @tornaria