Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: heroic-games-launcher-2.4.3
@ 2022-10-29 16:53 wiktorciurej
  2022-10-29 21:09 ` [PR PATCH] [Updated] " wiktorciurej
                   ` (17 more replies)
  0 siblings, 18 replies; 19+ messages in thread
From: wiktorciurej @ 2022-10-29 16:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

There is a new pull request by wiktorciurej against master on the void-packages repository

https://github.com/wiktorciurej/void-packages new_package/heroic-games-launcher
https://github.com/void-linux/void-packages/pull/40220

New package: heroic-games-launcher-2.4.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64*
  - armv7l*
  - x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/40220.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package/heroic-games-launcher-40220.patch --]
[-- Type: text/x-diff, Size: 2856 bytes --]

From e383def50503a73f9736553f025888edbca8f586 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 18:47:44 +0200
Subject: [PATCH] New package: heroic-games-launcher-2.4.3

---
 .../files/heroic.desktop                      | 10 +++++
 srcpkgs/heroic-games-launcher/template        | 45 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/heroic-games-launcher/files/heroic.desktop
 create mode 100644 srcpkgs/heroic-games-launcher/template

diff --git a/srcpkgs/heroic-games-launcher/files/heroic.desktop b/srcpkgs/heroic-games-launcher/files/heroic.desktop
new file mode 100644
index 000000000000..15c393b9e41e
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/files/heroic.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Name=Heroic Games Launcher
+Exec=/usr/bin/heroic %U
+Terminal=false
+Type=Application
+Icon=heroic
+StartupWMClass=Heroic
+Comment=Open Source GOG and Epic Games launcher
+MimeType=x-scheme-handler/heroic;
+Categories=Game;
diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
new file mode 100644
index 000000000000..aeddb6f659b8
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/template
@@ -0,0 +1,45 @@
+# Template file for 'heroic-games-launcher'
+pkgname=heroic-games-launcher
+version=2.4.3
+revision=1
+archs="x86_64* armv7l* aarch64*"
+wrksrc="HeroicGamesLauncher-${version}"
+hostmakedepends="nodejs python3 yarn"
+depends="alsa-lib gtk+3 nss python3"
+checkdepends="tar xz"
+short_desc="Open Source Launcher for GOG and Epic Games"
+maintainer="Wiktor Ciurej <wiktor.ciurej@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
+distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
+checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a
+nopie_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+case ${XBPS_TARGET_MACHINE} in
+	x86_64*) _arch=x64 ;;
+	aarch64*) _arch=arm64 ;;
+	armv7l*) _arch=armv7l ;;
+	*) broken="There is no electron package provided for selected architecture." ;;
+esac
+
+do_build() {
+	npm_config_arch=${_arch} npm_config_platform=linux yarn
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+}
+
+do_check() {
+	npm_config_arch=${_arch} yarn test
+	npm_config_arch=${_arch} yarn test:ci
+}
+
+do_install() {
+	vmkdir opt/heroic/
+	vcopy dist/linux-unpacked/* opt/heroic/
+	vmkdir usr/bin/
+	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
+	vmkdir usr/share/pixmaps/
+	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
+	vmkdir usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+}

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
@ 2022-10-29 21:09 ` wiktorciurej
  2022-10-29 23:25 ` wiktorciurej
                   ` (16 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: wiktorciurej @ 2022-10-29 21:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by wiktorciurej against master on the void-packages repository

https://github.com/wiktorciurej/void-packages new_package/heroic-games-launcher
https://github.com/void-linux/void-packages/pull/40220

New package: heroic-games-launcher-2.4.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64*
  - armv7l*
  - x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/40220.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package/heroic-games-launcher-40220.patch --]
[-- Type: text/x-diff, Size: 4621 bytes --]

From e383def50503a73f9736553f025888edbca8f586 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 18:47:44 +0200
Subject: [PATCH 1/2] New package: heroic-games-launcher-2.4.3

---
 .../files/heroic.desktop                      | 10 +++++
 srcpkgs/heroic-games-launcher/template        | 45 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/heroic-games-launcher/files/heroic.desktop
 create mode 100644 srcpkgs/heroic-games-launcher/template

diff --git a/srcpkgs/heroic-games-launcher/files/heroic.desktop b/srcpkgs/heroic-games-launcher/files/heroic.desktop
new file mode 100644
index 000000000000..15c393b9e41e
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/files/heroic.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Name=Heroic Games Launcher
+Exec=/usr/bin/heroic %U
+Terminal=false
+Type=Application
+Icon=heroic
+StartupWMClass=Heroic
+Comment=Open Source GOG and Epic Games launcher
+MimeType=x-scheme-handler/heroic;
+Categories=Game;
diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
new file mode 100644
index 000000000000..aeddb6f659b8
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/template
@@ -0,0 +1,45 @@
+# Template file for 'heroic-games-launcher'
+pkgname=heroic-games-launcher
+version=2.4.3
+revision=1
+archs="x86_64* armv7l* aarch64*"
+wrksrc="HeroicGamesLauncher-${version}"
+hostmakedepends="nodejs python3 yarn"
+depends="alsa-lib gtk+3 nss python3"
+checkdepends="tar xz"
+short_desc="Open Source Launcher for GOG and Epic Games"
+maintainer="Wiktor Ciurej <wiktor.ciurej@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
+distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
+checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a
+nopie_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+case ${XBPS_TARGET_MACHINE} in
+	x86_64*) _arch=x64 ;;
+	aarch64*) _arch=arm64 ;;
+	armv7l*) _arch=armv7l ;;
+	*) broken="There is no electron package provided for selected architecture." ;;
+esac
+
+do_build() {
+	npm_config_arch=${_arch} npm_config_platform=linux yarn
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+}
+
+do_check() {
+	npm_config_arch=${_arch} yarn test
+	npm_config_arch=${_arch} yarn test:ci
+}
+
+do_install() {
+	vmkdir opt/heroic/
+	vcopy dist/linux-unpacked/* opt/heroic/
+	vmkdir usr/bin/
+	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
+	vmkdir usr/share/pixmaps/
+	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
+	vmkdir usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+}

From 03aef87bc8be5ee1690cb87a0a2917db9fbaa3df Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 23:08:07 +0200
Subject: [PATCH 2/2] Fix arm install errors.

---
 srcpkgs/heroic-games-launcher/template | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index aeddb6f659b8..adf58f561712 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -23,6 +23,14 @@ case ${XBPS_TARGET_MACHINE} in
 	*) broken="There is no electron package provided for selected architecture." ;;
 esac
 
+if ! [ ${_arch} == "x64" ]; then
+	nostrip_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+	skiprdeps="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
 	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
@@ -35,11 +43,15 @@ do_check() {
 
 do_install() {
 	vmkdir opt/heroic/
-	vcopy dist/linux-unpacked/* opt/heroic/
+	if [ ${_arch} == "x64" ]; then
+		vcopy dist/linux-unpacked/* opt/heroic/
+	else
+		vcopy dist/linux-${_arch}-unpacked/* opt/heroic/
+	fi
 	vmkdir usr/bin/
 	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
 	vmkdir usr/share/pixmaps/
 	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
 	vmkdir usr/share/applications/
-	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0644 usr/share/applications/
 }

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
  2022-10-29 21:09 ` [PR PATCH] [Updated] " wiktorciurej
@ 2022-10-29 23:25 ` wiktorciurej
  2022-10-29 23:26 ` wiktorciurej
                   ` (15 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: wiktorciurej @ 2022-10-29 23:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by wiktorciurej against master on the void-packages repository

https://github.com/wiktorciurej/void-packages new_package/heroic-games-launcher
https://github.com/void-linux/void-packages/pull/40220

New package: heroic-games-launcher-2.4.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64*
  - armv7l*
  - x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/40220.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package/heroic-games-launcher-40220.patch --]
[-- Type: text/x-diff, Size: 5747 bytes --]

From e383def50503a73f9736553f025888edbca8f586 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 18:47:44 +0200
Subject: [PATCH 1/3] New package: heroic-games-launcher-2.4.3

---
 .../files/heroic.desktop                      | 10 +++++
 srcpkgs/heroic-games-launcher/template        | 45 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/heroic-games-launcher/files/heroic.desktop
 create mode 100644 srcpkgs/heroic-games-launcher/template

diff --git a/srcpkgs/heroic-games-launcher/files/heroic.desktop b/srcpkgs/heroic-games-launcher/files/heroic.desktop
new file mode 100644
index 000000000000..15c393b9e41e
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/files/heroic.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Name=Heroic Games Launcher
+Exec=/usr/bin/heroic %U
+Terminal=false
+Type=Application
+Icon=heroic
+StartupWMClass=Heroic
+Comment=Open Source GOG and Epic Games launcher
+MimeType=x-scheme-handler/heroic;
+Categories=Game;
diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
new file mode 100644
index 000000000000..aeddb6f659b8
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/template
@@ -0,0 +1,45 @@
+# Template file for 'heroic-games-launcher'
+pkgname=heroic-games-launcher
+version=2.4.3
+revision=1
+archs="x86_64* armv7l* aarch64*"
+wrksrc="HeroicGamesLauncher-${version}"
+hostmakedepends="nodejs python3 yarn"
+depends="alsa-lib gtk+3 nss python3"
+checkdepends="tar xz"
+short_desc="Open Source Launcher for GOG and Epic Games"
+maintainer="Wiktor Ciurej <wiktor.ciurej@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
+distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
+checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a
+nopie_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+case ${XBPS_TARGET_MACHINE} in
+	x86_64*) _arch=x64 ;;
+	aarch64*) _arch=arm64 ;;
+	armv7l*) _arch=armv7l ;;
+	*) broken="There is no electron package provided for selected architecture." ;;
+esac
+
+do_build() {
+	npm_config_arch=${_arch} npm_config_platform=linux yarn
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+}
+
+do_check() {
+	npm_config_arch=${_arch} yarn test
+	npm_config_arch=${_arch} yarn test:ci
+}
+
+do_install() {
+	vmkdir opt/heroic/
+	vcopy dist/linux-unpacked/* opt/heroic/
+	vmkdir usr/bin/
+	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
+	vmkdir usr/share/pixmaps/
+	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
+	vmkdir usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+}

From 03aef87bc8be5ee1690cb87a0a2917db9fbaa3df Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 23:08:07 +0200
Subject: [PATCH 2/3] Fix arm install errors.

---
 srcpkgs/heroic-games-launcher/template | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index aeddb6f659b8..adf58f561712 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -23,6 +23,14 @@ case ${XBPS_TARGET_MACHINE} in
 	*) broken="There is no electron package provided for selected architecture." ;;
 esac
 
+if ! [ ${_arch} == "x64" ]; then
+	nostrip_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+	skiprdeps="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
 	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
@@ -35,11 +43,15 @@ do_check() {
 
 do_install() {
 	vmkdir opt/heroic/
-	vcopy dist/linux-unpacked/* opt/heroic/
+	if [ ${_arch} == "x64" ]; then
+		vcopy dist/linux-unpacked/* opt/heroic/
+	else
+		vcopy dist/linux-${_arch}-unpacked/* opt/heroic/
+	fi
 	vmkdir usr/bin/
 	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
 	vmkdir usr/share/pixmaps/
 	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
 	vmkdir usr/share/applications/
-	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0644 usr/share/applications/
 }

From d4841df4bd298de108d2f0241812898e59b85eae Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sun, 30 Oct 2022 01:23:56 +0200
Subject: [PATCH 3/3] Fix musl builds failing.

---
 srcpkgs/heroic-games-launcher/template | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index adf58f561712..f6a78e875095 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -31,9 +31,17 @@ if ! [ ${_arch} == "x64" ]; then
 	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
 fi
 
+if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
+	hostmakedepends+=" p7zip"
+	_use_system_p7zip=true
+else
+	_use_system_p7zip=false
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
-	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+	echo ${_use_system_p7zip}
+	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
 }
 
 do_check() {

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
  2022-10-29 21:09 ` [PR PATCH] [Updated] " wiktorciurej
  2022-10-29 23:25 ` wiktorciurej
@ 2022-10-29 23:26 ` wiktorciurej
  2022-10-30 10:11 ` Johnnynator
                   ` (14 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: wiktorciurej @ 2022-10-29 23:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by wiktorciurej against master on the void-packages repository

https://github.com/wiktorciurej/void-packages new_package/heroic-games-launcher
https://github.com/void-linux/void-packages/pull/40220

New package: heroic-games-launcher-2.4.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64*
  - armv7l*
  - x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/40220.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package/heroic-games-launcher-40220.patch --]
[-- Type: text/x-diff, Size: 5717 bytes --]

From e383def50503a73f9736553f025888edbca8f586 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 18:47:44 +0200
Subject: [PATCH 1/3] New package: heroic-games-launcher-2.4.3

---
 .../files/heroic.desktop                      | 10 +++++
 srcpkgs/heroic-games-launcher/template        | 45 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/heroic-games-launcher/files/heroic.desktop
 create mode 100644 srcpkgs/heroic-games-launcher/template

diff --git a/srcpkgs/heroic-games-launcher/files/heroic.desktop b/srcpkgs/heroic-games-launcher/files/heroic.desktop
new file mode 100644
index 000000000000..15c393b9e41e
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/files/heroic.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Name=Heroic Games Launcher
+Exec=/usr/bin/heroic %U
+Terminal=false
+Type=Application
+Icon=heroic
+StartupWMClass=Heroic
+Comment=Open Source GOG and Epic Games launcher
+MimeType=x-scheme-handler/heroic;
+Categories=Game;
diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
new file mode 100644
index 000000000000..aeddb6f659b8
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/template
@@ -0,0 +1,45 @@
+# Template file for 'heroic-games-launcher'
+pkgname=heroic-games-launcher
+version=2.4.3
+revision=1
+archs="x86_64* armv7l* aarch64*"
+wrksrc="HeroicGamesLauncher-${version}"
+hostmakedepends="nodejs python3 yarn"
+depends="alsa-lib gtk+3 nss python3"
+checkdepends="tar xz"
+short_desc="Open Source Launcher for GOG and Epic Games"
+maintainer="Wiktor Ciurej <wiktor.ciurej@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
+distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
+checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a
+nopie_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+case ${XBPS_TARGET_MACHINE} in
+	x86_64*) _arch=x64 ;;
+	aarch64*) _arch=arm64 ;;
+	armv7l*) _arch=armv7l ;;
+	*) broken="There is no electron package provided for selected architecture." ;;
+esac
+
+do_build() {
+	npm_config_arch=${_arch} npm_config_platform=linux yarn
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+}
+
+do_check() {
+	npm_config_arch=${_arch} yarn test
+	npm_config_arch=${_arch} yarn test:ci
+}
+
+do_install() {
+	vmkdir opt/heroic/
+	vcopy dist/linux-unpacked/* opt/heroic/
+	vmkdir usr/bin/
+	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
+	vmkdir usr/share/pixmaps/
+	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
+	vmkdir usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+}

From 03aef87bc8be5ee1690cb87a0a2917db9fbaa3df Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 23:08:07 +0200
Subject: [PATCH 2/3] Fix arm install errors.

---
 srcpkgs/heroic-games-launcher/template | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index aeddb6f659b8..adf58f561712 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -23,6 +23,14 @@ case ${XBPS_TARGET_MACHINE} in
 	*) broken="There is no electron package provided for selected architecture." ;;
 esac
 
+if ! [ ${_arch} == "x64" ]; then
+	nostrip_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+	skiprdeps="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
 	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
@@ -35,11 +43,15 @@ do_check() {
 
 do_install() {
 	vmkdir opt/heroic/
-	vcopy dist/linux-unpacked/* opt/heroic/
+	if [ ${_arch} == "x64" ]; then
+		vcopy dist/linux-unpacked/* opt/heroic/
+	else
+		vcopy dist/linux-${_arch}-unpacked/* opt/heroic/
+	fi
 	vmkdir usr/bin/
 	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
 	vmkdir usr/share/pixmaps/
 	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
 	vmkdir usr/share/applications/
-	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0644 usr/share/applications/
 }

From c4bc074eddb33c85cf97e70917659ec72c6c11bf Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sun, 30 Oct 2022 01:23:56 +0200
Subject: [PATCH 3/3] Fix musl builds failing.

---
 srcpkgs/heroic-games-launcher/template | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index adf58f561712..1ce15d1792f4 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -31,9 +31,16 @@ if ! [ ${_arch} == "x64" ]; then
 	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
 fi
 
+if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
+	hostmakedepends+=" p7zip"
+	_use_system_p7zip=true
+else
+	_use_system_p7zip=false
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
-	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
 }
 
 do_check() {

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (2 preceding siblings ...)
  2022-10-29 23:26 ` wiktorciurej
@ 2022-10-30 10:11 ` Johnnynator
  2022-10-30 10:33 ` [PR PATCH] [Updated] " wiktorciurej
                   ` (13 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: Johnnynator @ 2022-10-30 10:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#issuecomment-1296199058

Comment:
https://github.com/void-linux/void-packages/actions/runs/3353335290/jobs/5558484193#step:7:170

You are fetching precompiled binaries for glibc.
Also heroic would be pretty limited on *musl and arm/aarch64 since everything it downloads is for x86_64-glibc.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (3 preceding siblings ...)
  2022-10-30 10:11 ` Johnnynator
@ 2022-10-30 10:33 ` wiktorciurej
  2022-10-30 11:17 ` wiktorciurej
                   ` (12 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: wiktorciurej @ 2022-10-30 10:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by wiktorciurej against master on the void-packages repository

https://github.com/wiktorciurej/void-packages new_package/heroic-games-launcher
https://github.com/void-linux/void-packages/pull/40220

New package: heroic-games-launcher-2.4.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64*
  - armv7l*
  - x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/40220.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package/heroic-games-launcher-40220.patch --]
[-- Type: text/x-diff, Size: 7534 bytes --]

From e383def50503a73f9736553f025888edbca8f586 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 18:47:44 +0200
Subject: [PATCH 1/4] New package: heroic-games-launcher-2.4.3

---
 .../files/heroic.desktop                      | 10 +++++
 srcpkgs/heroic-games-launcher/template        | 45 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/heroic-games-launcher/files/heroic.desktop
 create mode 100644 srcpkgs/heroic-games-launcher/template

diff --git a/srcpkgs/heroic-games-launcher/files/heroic.desktop b/srcpkgs/heroic-games-launcher/files/heroic.desktop
new file mode 100644
index 000000000000..15c393b9e41e
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/files/heroic.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Name=Heroic Games Launcher
+Exec=/usr/bin/heroic %U
+Terminal=false
+Type=Application
+Icon=heroic
+StartupWMClass=Heroic
+Comment=Open Source GOG and Epic Games launcher
+MimeType=x-scheme-handler/heroic;
+Categories=Game;
diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
new file mode 100644
index 000000000000..aeddb6f659b8
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/template
@@ -0,0 +1,45 @@
+# Template file for 'heroic-games-launcher'
+pkgname=heroic-games-launcher
+version=2.4.3
+revision=1
+archs="x86_64* armv7l* aarch64*"
+wrksrc="HeroicGamesLauncher-${version}"
+hostmakedepends="nodejs python3 yarn"
+depends="alsa-lib gtk+3 nss python3"
+checkdepends="tar xz"
+short_desc="Open Source Launcher for GOG and Epic Games"
+maintainer="Wiktor Ciurej <wiktor.ciurej@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
+distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
+checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a
+nopie_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+case ${XBPS_TARGET_MACHINE} in
+	x86_64*) _arch=x64 ;;
+	aarch64*) _arch=arm64 ;;
+	armv7l*) _arch=armv7l ;;
+	*) broken="There is no electron package provided for selected architecture." ;;
+esac
+
+do_build() {
+	npm_config_arch=${_arch} npm_config_platform=linux yarn
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+}
+
+do_check() {
+	npm_config_arch=${_arch} yarn test
+	npm_config_arch=${_arch} yarn test:ci
+}
+
+do_install() {
+	vmkdir opt/heroic/
+	vcopy dist/linux-unpacked/* opt/heroic/
+	vmkdir usr/bin/
+	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
+	vmkdir usr/share/pixmaps/
+	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
+	vmkdir usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+}

From 32d8dd571cb5d5999212414e3d9c8245ad65c227 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 23:08:07 +0200
Subject: [PATCH 2/4] heroic-games-launcher: Fix arm install errors.

---
 srcpkgs/heroic-games-launcher/template | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index aeddb6f659b8..adf58f561712 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -23,6 +23,14 @@ case ${XBPS_TARGET_MACHINE} in
 	*) broken="There is no electron package provided for selected architecture." ;;
 esac
 
+if ! [ ${_arch} == "x64" ]; then
+	nostrip_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+	skiprdeps="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
 	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
@@ -35,11 +43,15 @@ do_check() {
 
 do_install() {
 	vmkdir opt/heroic/
-	vcopy dist/linux-unpacked/* opt/heroic/
+	if [ ${_arch} == "x64" ]; then
+		vcopy dist/linux-unpacked/* opt/heroic/
+	else
+		vcopy dist/linux-${_arch}-unpacked/* opt/heroic/
+	fi
 	vmkdir usr/bin/
 	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
 	vmkdir usr/share/pixmaps/
 	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
 	vmkdir usr/share/applications/
-	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0644 usr/share/applications/
 }

From 3cd7a8554d342e3c34a93cf28c1f017098e1d79b Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sun, 30 Oct 2022 01:23:56 +0200
Subject: [PATCH 3/4] heroic-games-launcher: Fix musl builds failing.

---
 srcpkgs/heroic-games-launcher/template | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index adf58f561712..1ce15d1792f4 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -31,9 +31,16 @@ if ! [ ${_arch} == "x64" ]; then
 	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
 fi
 
+if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
+	hostmakedepends+=" p7zip"
+	_use_system_p7zip=true
+else
+	_use_system_p7zip=false
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
-	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
 }
 
 do_check() {

From 444354421c8d4d8f3426e9c3cc0ad75287bed623 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sun, 30 Oct 2022 11:32:33 +0100
Subject: [PATCH 4/4] heroic-games-launcher: Exclude musl arch because of
 bundled glibc libs.

---
 srcpkgs/heroic-games-launcher/template | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index 1ce15d1792f4..e611a8064914 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -2,7 +2,7 @@
 pkgname=heroic-games-launcher
 version=2.4.3
 revision=1
-archs="x86_64* armv7l* aarch64*"
+archs="x86_64-glibc armv7l-glibc aarch64-glibc"
 wrksrc="HeroicGamesLauncher-${version}"
 hostmakedepends="nodejs python3 yarn"
 depends="alsa-lib gtk+3 nss python3"
@@ -31,16 +31,18 @@ if ! [ ${_arch} == "x64" ]; then
 	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
 fi
 
-if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
-	hostmakedepends+=" p7zip"
-	_use_system_p7zip=true
-else
-	_use_system_p7zip=false
-fi
+# Bundled libs are compiled against glibc so musl build won't work anyway.
+#if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
+#	hostmakedepends+=" p7zip"
+#	_use_system_p7zip=true
+#else
+#	_use_system_p7zip=false
+#fi
 
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
-	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+#	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
 }
 
 do_check() {

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (4 preceding siblings ...)
  2022-10-30 10:33 ` [PR PATCH] [Updated] " wiktorciurej
@ 2022-10-30 11:17 ` wiktorciurej
  2022-10-30 11:18 ` wiktorciurej
                   ` (11 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: wiktorciurej @ 2022-10-30 11:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by wiktorciurej against master on the void-packages repository

https://github.com/wiktorciurej/void-packages new_package/heroic-games-launcher
https://github.com/void-linux/void-packages/pull/40220

New package: heroic-games-launcher-2.4.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64*
  - armv7l*
  - x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/40220.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package/heroic-games-launcher-40220.patch --]
[-- Type: text/x-diff, Size: 7524 bytes --]

From e383def50503a73f9736553f025888edbca8f586 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 18:47:44 +0200
Subject: [PATCH 1/4] New package: heroic-games-launcher-2.4.3

---
 .../files/heroic.desktop                      | 10 +++++
 srcpkgs/heroic-games-launcher/template        | 45 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/heroic-games-launcher/files/heroic.desktop
 create mode 100644 srcpkgs/heroic-games-launcher/template

diff --git a/srcpkgs/heroic-games-launcher/files/heroic.desktop b/srcpkgs/heroic-games-launcher/files/heroic.desktop
new file mode 100644
index 000000000000..15c393b9e41e
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/files/heroic.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Name=Heroic Games Launcher
+Exec=/usr/bin/heroic %U
+Terminal=false
+Type=Application
+Icon=heroic
+StartupWMClass=Heroic
+Comment=Open Source GOG and Epic Games launcher
+MimeType=x-scheme-handler/heroic;
+Categories=Game;
diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
new file mode 100644
index 000000000000..aeddb6f659b8
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/template
@@ -0,0 +1,45 @@
+# Template file for 'heroic-games-launcher'
+pkgname=heroic-games-launcher
+version=2.4.3
+revision=1
+archs="x86_64* armv7l* aarch64*"
+wrksrc="HeroicGamesLauncher-${version}"
+hostmakedepends="nodejs python3 yarn"
+depends="alsa-lib gtk+3 nss python3"
+checkdepends="tar xz"
+short_desc="Open Source Launcher for GOG and Epic Games"
+maintainer="Wiktor Ciurej <wiktor.ciurej@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
+distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
+checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a
+nopie_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+case ${XBPS_TARGET_MACHINE} in
+	x86_64*) _arch=x64 ;;
+	aarch64*) _arch=arm64 ;;
+	armv7l*) _arch=armv7l ;;
+	*) broken="There is no electron package provided for selected architecture." ;;
+esac
+
+do_build() {
+	npm_config_arch=${_arch} npm_config_platform=linux yarn
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+}
+
+do_check() {
+	npm_config_arch=${_arch} yarn test
+	npm_config_arch=${_arch} yarn test:ci
+}
+
+do_install() {
+	vmkdir opt/heroic/
+	vcopy dist/linux-unpacked/* opt/heroic/
+	vmkdir usr/bin/
+	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
+	vmkdir usr/share/pixmaps/
+	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
+	vmkdir usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+}

From 32d8dd571cb5d5999212414e3d9c8245ad65c227 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 23:08:07 +0200
Subject: [PATCH 2/4] heroic-games-launcher: Fix arm install errors.

---
 srcpkgs/heroic-games-launcher/template | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index aeddb6f659b8..adf58f561712 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -23,6 +23,14 @@ case ${XBPS_TARGET_MACHINE} in
 	*) broken="There is no electron package provided for selected architecture." ;;
 esac
 
+if ! [ ${_arch} == "x64" ]; then
+	nostrip_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+	skiprdeps="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
 	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
@@ -35,11 +43,15 @@ do_check() {
 
 do_install() {
 	vmkdir opt/heroic/
-	vcopy dist/linux-unpacked/* opt/heroic/
+	if [ ${_arch} == "x64" ]; then
+		vcopy dist/linux-unpacked/* opt/heroic/
+	else
+		vcopy dist/linux-${_arch}-unpacked/* opt/heroic/
+	fi
 	vmkdir usr/bin/
 	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
 	vmkdir usr/share/pixmaps/
 	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
 	vmkdir usr/share/applications/
-	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0644 usr/share/applications/
 }

From 3cd7a8554d342e3c34a93cf28c1f017098e1d79b Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sun, 30 Oct 2022 01:23:56 +0200
Subject: [PATCH 3/4] heroic-games-launcher: Fix musl builds failing.

---
 srcpkgs/heroic-games-launcher/template | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index adf58f561712..1ce15d1792f4 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -31,9 +31,16 @@ if ! [ ${_arch} == "x64" ]; then
 	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
 fi
 
+if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
+	hostmakedepends+=" p7zip"
+	_use_system_p7zip=true
+else
+	_use_system_p7zip=false
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
-	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
 }
 
 do_check() {

From a422599f039e9ec43c51d712c428ab3778bf0d2e Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sun, 30 Oct 2022 11:32:33 +0100
Subject: [PATCH 4/4] heroic-games-launcher: Exclude musl arch because of
 bundled glibc libs.

---
 srcpkgs/heroic-games-launcher/template | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index 1ce15d1792f4..2c35d2b2933c 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -2,7 +2,7 @@
 pkgname=heroic-games-launcher
 version=2.4.3
 revision=1
-archs="x86_64* armv7l* aarch64*"
+archs="x86_64 armv7l aarch64 ~*-musl"
 wrksrc="HeroicGamesLauncher-${version}"
 hostmakedepends="nodejs python3 yarn"
 depends="alsa-lib gtk+3 nss python3"
@@ -31,16 +31,18 @@ if ! [ ${_arch} == "x64" ]; then
 	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
 fi
 
-if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
-	hostmakedepends+=" p7zip"
-	_use_system_p7zip=true
-else
-	_use_system_p7zip=false
-fi
+# Bundled libs are compiled against glibc so musl build won't work anyway.
+#if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
+#	hostmakedepends+=" p7zip"
+#	_use_system_p7zip=true
+#else
+#	_use_system_p7zip=false
+#fi
 
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
-	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+#	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
 }
 
 do_check() {

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (5 preceding siblings ...)
  2022-10-30 11:17 ` wiktorciurej
@ 2022-10-30 11:18 ` wiktorciurej
  2022-10-30 11:22 ` [PR PATCH] [Updated] " wiktorciurej
                   ` (10 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: wiktorciurej @ 2022-10-30 11:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

New comment by wiktorciurej on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#issuecomment-1296222100

Comment:
> https://github.com/void-linux/void-packages/actions/runs/3353335290/jobs/5558484193#step:7:170
> 
> You are fetching precompiled binaries for glibc. Also heroic would be pretty limited on *musl and arm/aarch64 since everything it downloads is for x86_64-glibc.

Yep, I just realised that and removed musl architectures completely.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Updated] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (6 preceding siblings ...)
  2022-10-30 11:18 ` wiktorciurej
@ 2022-10-30 11:22 ` wiktorciurej
  2023-01-29  2:01 ` github-actions
                   ` (9 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: wiktorciurej @ 2022-10-30 11:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

There is an updated pull request by wiktorciurej against master on the void-packages repository

https://github.com/wiktorciurej/void-packages new_package/heroic-games-launcher
https://github.com/void-linux/void-packages/pull/40220

New package: heroic-games-launcher-2.4.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64*
  - armv7l*
  - x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/40220.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_package/heroic-games-launcher-40220.patch --]
[-- Type: text/x-diff, Size: 7176 bytes --]

From e383def50503a73f9736553f025888edbca8f586 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 18:47:44 +0200
Subject: [PATCH 1/4] New package: heroic-games-launcher-2.4.3

---
 .../files/heroic.desktop                      | 10 +++++
 srcpkgs/heroic-games-launcher/template        | 45 +++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/heroic-games-launcher/files/heroic.desktop
 create mode 100644 srcpkgs/heroic-games-launcher/template

diff --git a/srcpkgs/heroic-games-launcher/files/heroic.desktop b/srcpkgs/heroic-games-launcher/files/heroic.desktop
new file mode 100644
index 000000000000..15c393b9e41e
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/files/heroic.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Name=Heroic Games Launcher
+Exec=/usr/bin/heroic %U
+Terminal=false
+Type=Application
+Icon=heroic
+StartupWMClass=Heroic
+Comment=Open Source GOG and Epic Games launcher
+MimeType=x-scheme-handler/heroic;
+Categories=Game;
diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
new file mode 100644
index 000000000000..aeddb6f659b8
--- /dev/null
+++ b/srcpkgs/heroic-games-launcher/template
@@ -0,0 +1,45 @@
+# Template file for 'heroic-games-launcher'
+pkgname=heroic-games-launcher
+version=2.4.3
+revision=1
+archs="x86_64* armv7l* aarch64*"
+wrksrc="HeroicGamesLauncher-${version}"
+hostmakedepends="nodejs python3 yarn"
+depends="alsa-lib gtk+3 nss python3"
+checkdepends="tar xz"
+short_desc="Open Source Launcher for GOG and Epic Games"
+maintainer="Wiktor Ciurej <wiktor.ciurej@gmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher"
+distfiles="https://github.com/Heroic-Games-Launcher/HeroicGamesLauncher/archive/v${version}.tar.gz"
+checksum=b6590fd99776c2f6d890266ee177d1d90f8a127eaa47b9aec41fc00c4194bc9a
+nopie_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+case ${XBPS_TARGET_MACHINE} in
+	x86_64*) _arch=x64 ;;
+	aarch64*) _arch=arm64 ;;
+	armv7l*) _arch=armv7l ;;
+	*) broken="There is no electron package provided for selected architecture." ;;
+esac
+
+do_build() {
+	npm_config_arch=${_arch} npm_config_platform=linux yarn
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+}
+
+do_check() {
+	npm_config_arch=${_arch} yarn test
+	npm_config_arch=${_arch} yarn test:ci
+}
+
+do_install() {
+	vmkdir opt/heroic/
+	vcopy dist/linux-unpacked/* opt/heroic/
+	vmkdir usr/bin/
+	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
+	vmkdir usr/share/pixmaps/
+	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
+	vmkdir usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+}

From 32d8dd571cb5d5999212414e3d9c8245ad65c227 Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sat, 29 Oct 2022 23:08:07 +0200
Subject: [PATCH 2/4] heroic-games-launcher: Fix arm install errors.

---
 srcpkgs/heroic-games-launcher/template | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index aeddb6f659b8..adf58f561712 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -23,6 +23,14 @@ case ${XBPS_TARGET_MACHINE} in
 	*) broken="There is no electron package provided for selected architecture." ;;
 esac
 
+if ! [ ${_arch} == "x64" ]; then
+	nostrip_files="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+
+	skiprdeps="/opt/heroic/resources/app.asar.unpacked/build/bin/linux/gogdl
+	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
 	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
@@ -35,11 +43,15 @@ do_check() {
 
 do_install() {
 	vmkdir opt/heroic/
-	vcopy dist/linux-unpacked/* opt/heroic/
+	if [ ${_arch} == "x64" ]; then
+		vcopy dist/linux-unpacked/* opt/heroic/
+	else
+		vcopy dist/linux-${_arch}-unpacked/* opt/heroic/
+	fi
 	vmkdir usr/bin/
 	ln -sf /opt/heroic/heroic ${DESTDIR}/usr/bin/heroic
 	vmkdir usr/share/pixmaps/
 	vinstall public/icon.png 0755 usr/share/pixmaps/ heroic.png
 	vmkdir usr/share/applications/
-	vinstall ${FILESDIR}/heroic.desktop 0755 usr/share/applications/
+	vinstall ${FILESDIR}/heroic.desktop 0644 usr/share/applications/
 }

From 3cd7a8554d342e3c34a93cf28c1f017098e1d79b Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sun, 30 Oct 2022 01:23:56 +0200
Subject: [PATCH 3/4] heroic-games-launcher: Fix musl builds failing.

---
 srcpkgs/heroic-games-launcher/template | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index adf58f561712..1ce15d1792f4 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -31,9 +31,16 @@ if ! [ ${_arch} == "x64" ]; then
 	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
 fi
 
+if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
+	hostmakedepends+=" p7zip"
+	_use_system_p7zip=true
+else
+	_use_system_p7zip=false
+fi
+
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
-	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
 }
 
 do_check() {

From e0b96b67410d881a961bc5a6a5652e4adf74c76d Mon Sep 17 00:00:00 2001
From: Wiktor Ciurej <wiktor.ciurej@gmail.com>
Date: Sun, 30 Oct 2022 11:32:33 +0100
Subject: [PATCH 4/4] heroic-games-launcher: Exclude musl arch because of
 bundled glibc libs.

---
 srcpkgs/heroic-games-launcher/template | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/heroic-games-launcher/template b/srcpkgs/heroic-games-launcher/template
index 1ce15d1792f4..be29249eca5f 100644
--- a/srcpkgs/heroic-games-launcher/template
+++ b/srcpkgs/heroic-games-launcher/template
@@ -2,7 +2,7 @@
 pkgname=heroic-games-launcher
 version=2.4.3
 revision=1
-archs="x86_64* armv7l* aarch64*"
+archs="x86_64 armv7l aarch64 ~*-musl"
 wrksrc="HeroicGamesLauncher-${version}"
 hostmakedepends="nodejs python3 yarn"
 depends="alsa-lib gtk+3 nss python3"
@@ -31,16 +31,9 @@ if ! [ ${_arch} == "x64" ]; then
 	/opt/heroic/resources/app.asar.unpacked/build/bin/linux/legendary"
 fi
 
-if [ ${XBPS_TARGET_LIBC} == "musl" ]; then
-	hostmakedepends+=" p7zip"
-	_use_system_p7zip=true
-else
-	_use_system_p7zip=false
-fi
-
 do_build() {
 	npm_config_arch=${_arch} npm_config_platform=linux yarn
-	USE_SYSTEM_7ZA=${_use_system_p7zip} npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
+	npm_config_arch=${_arch} npm_config_platform=linux yarn dist:linux tar.xz --${_arch}
 }
 
 do_check() {

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (7 preceding siblings ...)
  2022-10-30 11:22 ` [PR PATCH] [Updated] " wiktorciurej
@ 2023-01-29  2:01 ` github-actions
  2023-02-03 17:02 ` [PR REVIEW] " sirkhancision
                   ` (8 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: github-actions @ 2023-01-29  2:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#issuecomment-1407536282

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (8 preceding siblings ...)
  2023-01-29  2:01 ` github-actions
@ 2023-02-03 17:02 ` sirkhancision
  2023-02-03 17:02 ` sirkhancision
                   ` (7 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: sirkhancision @ 2023-02-03 17:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#discussion_r1096039414

Comment:
```suggestion
Exec=/opt/heroic/heroic %U
```

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (9 preceding siblings ...)
  2023-02-03 17:02 ` [PR REVIEW] " sirkhancision
@ 2023-02-03 17:02 ` sirkhancision
  2023-02-03 17:03 ` sirkhancision
                   ` (6 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: sirkhancision @ 2023-02-03 17:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#discussion_r1096039884

Comment:
```suggestion
version=2.6.1
```

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (10 preceding siblings ...)
  2023-02-03 17:02 ` sirkhancision
@ 2023-02-03 17:03 ` sirkhancision
  2023-02-03 17:03 ` sirkhancision
                   ` (5 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: sirkhancision @ 2023-02-03 17:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#discussion_r1096040584

Comment:
```suggestion
archs="x86_64"
```

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (11 preceding siblings ...)
  2023-02-03 17:03 ` sirkhancision
@ 2023-02-03 17:03 ` sirkhancision
  2023-02-03 17:04 ` sirkhancision
                   ` (4 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: sirkhancision @ 2023-02-03 17:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#discussion_r1096040882

Comment:
```suggestion
depends="fuse gawk"
```

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (12 preceding siblings ...)
  2023-02-03 17:03 ` sirkhancision
@ 2023-02-03 17:04 ` sirkhancision
  2023-02-03 17:06 ` sirkhancision
                   ` (3 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: sirkhancision @ 2023-02-03 17:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#discussion_r1096041552

Comment:
```suggestion
checksum=d312ae93a63029491bf23eb52074580e4a1830d030b70f9547fd9b187306f8aa
```

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR REVIEW] New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (13 preceding siblings ...)
  2023-02-03 17:04 ` sirkhancision
@ 2023-02-03 17:06 ` sirkhancision
  2023-02-03 17:10 ` sirkhancision
                   ` (2 subsequent siblings)
  17 siblings, 0 replies; 19+ messages in thread
From: sirkhancision @ 2023-02-03 17:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

New review comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#discussion_r1096043647

Comment:
```suggestion
do_build() {
	yarn
	yarn dist:linux tar.xz
}

do_check() {
	yarn test
	yarn test:ci
}

do_install() {
	vmkdir opt/heroic
	vcopy dist/linux-unpacked/* opt/heroic

	vinstall public/icon.png 644 usr/share/pixmaps heroic.png
	vinstall ${FILESDIR}/heroic.desktop 644 usr/share/applications
}
```

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (14 preceding siblings ...)
  2023-02-03 17:06 ` sirkhancision
@ 2023-02-03 17:10 ` sirkhancision
  2023-05-06  1:48 ` github-actions
  2023-05-20  1:51 ` [PR PATCH] [Closed]: " github-actions
  17 siblings, 0 replies; 19+ messages in thread
From: sirkhancision @ 2023-02-03 17:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by sirkhancision on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#issuecomment-1416160116

Comment:
The above suggestions are to update it to the latest version, reduce dependencies, simplify the process and make it build properly (the base code wasn't building in my machine). Compilation also failed when building for anything other than x86_64, so I've removed the other architectures.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (15 preceding siblings ...)
  2023-02-03 17:10 ` sirkhancision
@ 2023-05-06  1:48 ` github-actions
  2023-05-20  1:51 ` [PR PATCH] [Closed]: " github-actions
  17 siblings, 0 replies; 19+ messages in thread
From: github-actions @ 2023-05-06  1:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/40220#issuecomment-1536973802

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PR PATCH] [Closed]: New package: heroic-games-launcher-2.4.3
  2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
                   ` (16 preceding siblings ...)
  2023-05-06  1:48 ` github-actions
@ 2023-05-20  1:51 ` github-actions
  17 siblings, 0 replies; 19+ messages in thread
From: github-actions @ 2023-05-20  1:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

There's a closed pull request on the void-packages repository

New package: heroic-games-launcher-2.4.3
https://github.com/void-linux/void-packages/pull/40220

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64*
  - armv7l*
  - x86_64-musl



^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2023-05-20  1:51 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-29 16:53 [PR PATCH] New package: heroic-games-launcher-2.4.3 wiktorciurej
2022-10-29 21:09 ` [PR PATCH] [Updated] " wiktorciurej
2022-10-29 23:25 ` wiktorciurej
2022-10-29 23:26 ` wiktorciurej
2022-10-30 10:11 ` Johnnynator
2022-10-30 10:33 ` [PR PATCH] [Updated] " wiktorciurej
2022-10-30 11:17 ` wiktorciurej
2022-10-30 11:18 ` wiktorciurej
2022-10-30 11:22 ` [PR PATCH] [Updated] " wiktorciurej
2023-01-29  2:01 ` github-actions
2023-02-03 17:02 ` [PR REVIEW] " sirkhancision
2023-02-03 17:02 ` sirkhancision
2023-02-03 17:03 ` sirkhancision
2023-02-03 17:03 ` sirkhancision
2023-02-03 17:04 ` sirkhancision
2023-02-03 17:06 ` sirkhancision
2023-02-03 17:10 ` sirkhancision
2023-05-06  1:48 ` github-actions
2023-05-20  1:51 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).