[PR PATCH] Solaar: update to 1.1.7.

[PR PATCH] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages Solaar
https://github.com/void-linux/void-packages/pull/40318

Solaar: update to 1.1.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/40318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Solaar-40318.patch --]
[-- Type: text/x-diff, Size: 1418 bytes --]

From 887178549dd613d9281ee2043409989655cebb37 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 30 Oct 2022 19:59:00 +0530
Subject: [PATCH] Solaar: update to 1.1.7.

---
 srcpkgs/Solaar/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 50064f81a68c..aa3c916c372b 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -1,17 +1,18 @@
 # Template file for 'Solaar'
 pkgname=Solaar
-version=1.1.5
+version=1.1.7
 revision=1
+wrksrc="solaar-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-evdev python3-pyudev python3-psutil python3-yaml
- python3-xlib python3-gobject"
+ python3-xlib python3-typing_extensions python3-gobject"
 short_desc="Linux device manager for a wide range of Logitech devices"
 maintainer="Young Jin Park <youngjinpark20@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://pwr-solaar.github.io/Solaar/"
 changelog="https://raw.githubusercontent.com/pwr-Solaar/Solaar/master/ChangeLog.md"
-distfiles="https://github.com/pwr-Solaar/Solaar/archive/${version}.tar.gz"
-checksum=f8ac1db77d2713f057a83e448d84f6266d63c4fd36235ddb3dc20c6c8cbc0efe
+distfiles="${PYPI_SITE}/s/solaar/solaar-${version}.tar.gz"
+checksum=04224eec598a7b5c988d52e823a2257cb0255257736b915202388c5aafc0fd9c
 # Package provides no tests
 make_check=no

Re: Solaar: update to 1.1.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#issuecomment-1304011782

Comment:
I couldn't find any usage of typing_extensions in the code, so I asked them in the PR that added it: https://github.com/pwr-Solaar/Solaar/pull/1824#issuecomment-1304010410

Re: Solaar: update to 1.1.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#issuecomment-1304356777

Comment:
> I couldn't find any usage of typing_extensions in the code, so I asked them in the PR that added it: https://github.com/pwr-Solaar/Solaar/pull/1824#issuecomment-1304010410

We should drop that dependency, it's a dependency of hid-parser which we don't package and only for Python 3.7.

Re: [PR PATCH] [Updated] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages Solaar
https://github.com/void-linux/void-packages/pull/40318

Solaar: update to 1.1.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/40318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Solaar-40318.patch --]
[-- Type: text/x-diff, Size: 1269 bytes --]

From bee479f3128e6557c7c37bcac543da57e67e9504 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 30 Oct 2022 19:59:00 +0530
Subject: [PATCH] Solaar: update to 1.1.7.

---
 srcpkgs/Solaar/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 50064f81a68c..fdae7f293611 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -1,7 +1,8 @@
 # Template file for 'Solaar'
 pkgname=Solaar
-version=1.1.5
+version=1.1.7
 revision=1
+wrksrc="solaar-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-evdev python3-pyudev python3-psutil python3-yaml
@@ -11,7 +12,7 @@ maintainer="Young Jin Park <youngjinpark20@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://pwr-solaar.github.io/Solaar/"
 changelog="https://raw.githubusercontent.com/pwr-Solaar/Solaar/master/ChangeLog.md"
-distfiles="https://github.com/pwr-Solaar/Solaar/archive/${version}.tar.gz"
-checksum=f8ac1db77d2713f057a83e448d84f6266d63c4fd36235ddb3dc20c6c8cbc0efe
+distfiles="${PYPI_SITE}/s/solaar/solaar-${version}.tar.gz"
+checksum=04224eec598a7b5c988d52e823a2257cb0255257736b915202388c5aafc0fd9c
 # Package provides no tests
 make_check=no

Re: [PR PATCH] [Updated] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages Solaar
https://github.com/void-linux/void-packages/pull/40318

Solaar: update to 1.1.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/40318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Solaar-40318.patch --]
[-- Type: text/x-diff, Size: 1269 bytes --]

From bee479f3128e6557c7c37bcac543da57e67e9504 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 30 Oct 2022 19:59:00 +0530
Subject: [PATCH] Solaar: update to 1.1.7.

---
 srcpkgs/Solaar/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 50064f81a68c..fdae7f293611 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -1,7 +1,8 @@
 # Template file for 'Solaar'
 pkgname=Solaar
-version=1.1.5
+version=1.1.7
 revision=1
+wrksrc="solaar-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-evdev python3-pyudev python3-psutil python3-yaml
@@ -11,7 +12,7 @@ maintainer="Young Jin Park <youngjinpark20@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://pwr-solaar.github.io/Solaar/"
 changelog="https://raw.githubusercontent.com/pwr-Solaar/Solaar/master/ChangeLog.md"
-distfiles="https://github.com/pwr-Solaar/Solaar/archive/${version}.tar.gz"
-checksum=f8ac1db77d2713f057a83e448d84f6266d63c4fd36235ddb3dc20c6c8cbc0efe
+distfiles="${PYPI_SITE}/s/solaar/solaar-${version}.tar.gz"
+checksum=04224eec598a7b5c988d52e823a2257cb0255257736b915202388c5aafc0fd9c
 # Package provides no tests
 make_check=no

Re: [PR PATCH] [Updated] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages Solaar
https://github.com/void-linux/void-packages/pull/40318

Solaar: update to 1.1.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/40318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Solaar-40318.patch --]
[-- Type: text/x-diff, Size: 1283 bytes --]

From 38e0dbffd556ba2de07740a9029a14e53d33af75 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 30 Oct 2022 19:59:00 +0530
Subject: [PATCH] Solaar: update to 1.1.7.

---
 srcpkgs/Solaar/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 854f058f6afe..fdae7f293611 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -1,7 +1,8 @@
 # Template file for 'Solaar'
 pkgname=Solaar
-version=1.1.5
-revision=2
+version=1.1.7
+revision=1
+wrksrc="solaar-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-evdev python3-pyudev python3-psutil python3-yaml
@@ -11,7 +12,7 @@ maintainer="Young Jin Park <youngjinpark20@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://pwr-solaar.github.io/Solaar/"
 changelog="https://raw.githubusercontent.com/pwr-Solaar/Solaar/master/ChangeLog.md"
-distfiles="https://github.com/pwr-Solaar/Solaar/archive/${version}.tar.gz"
-checksum=f8ac1db77d2713f057a83e448d84f6266d63c4fd36235ddb3dc20c6c8cbc0efe
+distfiles="${PYPI_SITE}/s/solaar/solaar-${version}.tar.gz"
+checksum=04224eec598a7b5c988d52e823a2257cb0255257736b915202388c5aafc0fd9c
 # Package provides no tests
 make_check=no

Re: [PR PATCH] [Updated] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages Solaar
https://github.com/void-linux/void-packages/pull/40318

Solaar: update to 1.1.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/40318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Solaar-40318.patch --]
[-- Type: text/x-diff, Size: 1283 bytes --]

From 1cf20b2296be2e00855489d4e8afbc3f09cdb8ed Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 30 Oct 2022 19:59:00 +0530
Subject: [PATCH] Solaar: update to 1.1.7.

---
 srcpkgs/Solaar/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 854f058f6afe..fdae7f293611 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -1,7 +1,8 @@
 # Template file for 'Solaar'
 pkgname=Solaar
-version=1.1.5
-revision=2
+version=1.1.7
+revision=1
+wrksrc="solaar-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-evdev python3-pyudev python3-psutil python3-yaml
@@ -11,7 +12,7 @@ maintainer="Young Jin Park <youngjinpark20@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://pwr-solaar.github.io/Solaar/"
 changelog="https://raw.githubusercontent.com/pwr-Solaar/Solaar/master/ChangeLog.md"
-distfiles="https://github.com/pwr-Solaar/Solaar/archive/${version}.tar.gz"
-checksum=f8ac1db77d2713f057a83e448d84f6266d63c4fd36235ddb3dc20c6c8cbc0efe
+distfiles="${PYPI_SITE}/s/solaar/solaar-${version}.tar.gz"
+checksum=04224eec598a7b5c988d52e823a2257cb0255257736b915202388c5aafc0fd9c
 # Package provides no tests
 make_check=no

Re: [PR REVIEW] Solaar: update to 1.1.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1017066110

Comment:
wrksrc is not necessary anymore

Re: [PR PATCH] [Updated] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages Solaar
https://github.com/void-linux/void-packages/pull/40318

Solaar: update to 1.1.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/40318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Solaar-40318.patch --]
[-- Type: text/x-diff, Size: 1254 bytes --]

From 5c252784240a845efd237e73dbe8e2c02aecdaa9 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 30 Oct 2022 19:59:00 +0530
Subject: [PATCH] Solaar: update to 1.1.7.

---
 srcpkgs/Solaar/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 854f058f6afe..86c19b87c1dd 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -1,7 +1,7 @@
 # Template file for 'Solaar'
 pkgname=Solaar
-version=1.1.5
-revision=2
+version=1.1.7
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-evdev python3-pyudev python3-psutil python3-yaml
@@ -11,7 +11,7 @@ maintainer="Young Jin Park <youngjinpark20@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://pwr-solaar.github.io/Solaar/"
 changelog="https://raw.githubusercontent.com/pwr-Solaar/Solaar/master/ChangeLog.md"
-distfiles="https://github.com/pwr-Solaar/Solaar/archive/${version}.tar.gz"
-checksum=f8ac1db77d2713f057a83e448d84f6266d63c4fd36235ddb3dc20c6c8cbc0efe
+distfiles="${PYPI_SITE}/s/solaar/solaar-${version}.tar.gz"
+checksum=04224eec598a7b5c988d52e823a2257cb0255257736b915202388c5aafc0fd9c
 # Package provides no tests
 make_check=no

Re: [PR REVIEW] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1017069741

Comment:
Huh, is that a thing now?! Have to read the updated manual I guess.

Re: [PR REVIEW] Solaar: update to 1.1.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1019541843

Comment:
gtk+3 is missing

Re: [PR REVIEW] Solaar: update to 1.1.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1019542861

Comment:
If the package provides no tests, there shouldn't be anything that can fail, so we don't have to skip them, no?

Re: [PR REVIEW] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1019564705

Comment:
Right, this is something I wasn't sure about when I last updated it as well. I guess the maintainer didn't included it initially cause the cli works fine without it? I don't have a preference either way.

Re: [PR REVIEW] Solaar: update to 1.1.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1019567406

Comment:
I don't use this software, so I assumed it's only graphical software.

Re: [PR REVIEW] Solaar: update to 1.1.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1019568003

Comment:
Could we split CLI to a subpackage?

Re: [PR REVIEW] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1019576041

Comment:
The setup.py testing procedure always errs out when there are no tests defined. I don't quite understand why it happens but it's the same for other `python3-module` packages (with no tests) too as far as I have seen.

Re: [PR REVIEW] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1019576302

Comment:
The cli doesn't seem to be something that can be easily separated. Like if you just run `$ solaar` it will open a gui. But the functionalities can be achieved with `$ solaar show`, `$ solaar pair`, `$ solaar probe` etc subcommands.

Re: [PR REVIEW] Solaar: update to 1.1.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40318#discussion_r1025075323

Comment:
It only fails because it checks for dependencies:
```
=> Solaar-1.1.7_1: running do_check ...
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
/usr/lib/python3.11/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
  warnings.warn(
WARNING: The wheel package is not available.
/usr/bin/python3: No module named pip
error: Command '['/usr/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpkph0cl5h', '--quiet', 'typing_extensions>=4.0.0']' returned non-zero exit status 1.
=> ERROR: Solaar-1.1.7_1: do_check: '${make_check_pre} python3 setup.py ${make_check_target} ${make_check_args}' exited with 1
=> ERROR:   in do_check() at common/build-style/python3-module.sh:28
```
So removing `make_check=no`, adding `checkdepends="$depends"` and patching out the typing_extensions dependency (import this patch https://github.com/pwr-Solaar/Solaar/commit/e15b58fdaa9137556e98e618489dffac12de13b8.patch) will make it pass. This is not the same as not running tests because it checks dependencies which is useful. Adding typing_extensions to checkdepends would also fix it, but we will probably forget to remove it next time the package is updated and a patch will stop applying, so that's better.

Re: [PR PATCH] [Updated] Solaar: update to 1.1.7.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages Solaar
https://github.com/void-linux/void-packages/pull/40318

Solaar: update to 1.1.7.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/40318.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-Solaar-40318.patch --]
[-- Type: text/x-diff, Size: 1400 bytes --]

From 9c9ff9236e6bd694c2b765548d2d1c41c704d0c9 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sun, 30 Oct 2022 19:59:00 +0530
Subject: [PATCH] Solaar: update to 1.1.8.

---
 srcpkgs/Solaar/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/Solaar/template b/srcpkgs/Solaar/template
index 854f058f6afe..6189136a9935 100644
--- a/srcpkgs/Solaar/template
+++ b/srcpkgs/Solaar/template
@@ -1,17 +1,16 @@
 # Template file for 'Solaar'
 pkgname=Solaar
-version=1.1.5
-revision=2
+version=1.1.8
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-evdev python3-pyudev python3-psutil python3-yaml
  python3-xlib python3-gobject"
+checkdepends="${depends}"
 short_desc="Linux device manager for a wide range of Logitech devices"
 maintainer="Young Jin Park <youngjinpark20@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://pwr-solaar.github.io/Solaar/"
 changelog="https://raw.githubusercontent.com/pwr-Solaar/Solaar/master/ChangeLog.md"
-distfiles="https://github.com/pwr-Solaar/Solaar/archive/${version}.tar.gz"
-checksum=f8ac1db77d2713f057a83e448d84f6266d63c4fd36235ddb3dc20c6c8cbc0efe
-# Package provides no tests
-make_check=no
+distfiles="https://github.com/pwr-Solaar/Solaar/archive/refs/tags/${version}.tar.gz"
+checksum=616c8056e7fe1f836e9d26e57430388d35c7f8d3b6d33ce0b2682d89e46714c1

Re: [PR PATCH] [Merged]: Solaar: update to 1.1.8.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

There's a merged pull request on the void-packages repository

Solaar: update to 1.1.8.
https://github.com/void-linux/void-packages/pull/40318

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64