[PR PATCH] [draft] sioyek: add .desktop file

[PR PATCH] [draft] sioyek: add .desktop file

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages sioy
https://github.com/void-linux/void-packages/pull/40460

[draft] sioyek: add .desktop file
#### Testing the changes
- I tested the changes in this PR: I'm still unable to select it e.g. in firefox.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/40460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sioy-40460.patch --]
[-- Type: text/x-diff, Size: 1632 bytes --]

From 7d205de30ff825b40a227191beb042835e83249c Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 10 Nov 2022 17:53:27 -0500
Subject: [PATCH] sioyek: add .desktop file

---
 srcpkgs/sioyek/files/sioyek.desktop | 12 ++++++++++++
 srcpkgs/sioyek/template             |  5 ++++-
 2 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/sioyek/files/sioyek.desktop

diff --git a/srcpkgs/sioyek/files/sioyek.desktop b/srcpkgs/sioyek/files/sioyek.desktop
new file mode 100644
index 000000000000..917fd62c03da
--- /dev/null
+++ b/srcpkgs/sioyek/files/sioyek.desktop
@@ -0,0 +1,12 @@
+[Desktop Entry]
+Name=Sioyek
+Comment=PDF viewer for reading research papers and technical books
+Keywords=pdf;viewer;reader;research;
+TryExec=sioyek
+Exec=sioyek %U
+StartupNotify=true
+Terminal=false
+Type=Application
+Icon=sioyek-icon-linux
+Categories=Development;Viewer;
+MimeType=application/pdf;
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index 4a0c74c829f2..fb1be606bc05 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,7 +1,7 @@
 # Template file for 'sioyek'
 pkgname=sioyek
 version=1.5.0
-revision=1
+revision=2
 archs="i686* x86_64*"
 build_style=qmake
 hostmakedepends="qt5-qmake qt5-host-tools
@@ -30,5 +30,8 @@ do_install() {
 	vmkdir usr/share/sioyek/shaders
 	vcopy pdf_viewer/shaders/* usr/share/sioyek/shaders
 	vinstall tutorial.pdf 644 usr/share/sioyek
+	# we can go back to this on next release
+	# vinstall resources/sioyek.desktop 644 usr/share/sioyek
+	vinstall ${FILESDIR}/sioyek.desktop 644 usr/share/sioyek
 	vman resources/sioyek.1
 }

Re: [draft] sioyek: add .desktop file

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311821317

Comment:
https://github.com/ahrm/sioyek/blob/main/resources/sioyek.desktop instead of vendoring, maybe patch it if required (the latest commit is missing).

Re: [draft] sioyek: add .desktop file

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311821317

Comment:
https://github.com/ahrm/sioyek/blob/main/resources/sioyek.desktop instead of vendoring, maybe patch it if required ((the latest commit is missing) makes it easier to notice when we don't have to vendor it anymore etc).

Re: [draft] sioyek: add .desktop file

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311848396

Comment:
@q66 I still think arch should be restricted: perhaps inlcude ppc*?

Re: [draft] sioyek: add .desktop file

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311868364

Comment:
also, it still depends on gcc, which looks suspicious

Re: [PR PATCH] [Updated] [draft] sioyek: add .desktop file

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages sioy
https://github.com/void-linux/void-packages/pull/40460

[draft] sioyek: add .desktop file
#### Testing the changes
- I tested the changes in this PR: I'm still unable to select it e.g. in firefox.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/40460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sioy-40460.patch --]
[-- Type: text/x-diff, Size: 2198 bytes --]

From e78ff2fbe524613e6ecfbc7629ae12d84cfb0095 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 10 Nov 2022 17:53:27 -0500
Subject: [PATCH] sioyek: add .desktop file, restore arch

---
 srcpkgs/sioyek/patches/desktop.patch | 22 ++++++++++++++++++++++
 srcpkgs/sioyek/template              |  5 +++--
 2 files changed, 25 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/sioyek/patches/desktop.patch

diff --git a/srcpkgs/sioyek/patches/desktop.patch b/srcpkgs/sioyek/patches/desktop.patch
new file mode 100644
index 000000000000..bf42608b3baa
--- /dev/null
+++ b/srcpkgs/sioyek/patches/desktop.patch
@@ -0,0 +1,22 @@
+diff --git a/resources/sioyek.desktop b/resources/sioyek.desktop
+index cf8b6b2..917fd62 100644
+--- a/resources/sioyek.desktop
++++ b/resources/sioyek.desktop
+@@ -1,8 +1,12 @@
+ [Desktop Entry]
+-Version=1.0
+-Type=Application
+-MimeType=application/pdf;
+ Name=Sioyek
+-Exec=sioyek
++Comment=PDF viewer for reading research papers and technical books
++Keywords=pdf;viewer;reader;research;
++TryExec=sioyek
++Exec=sioyek %U
++StartupNotify=true
++Terminal=false
++Type=Application
+ Icon=sioyek-icon-linux
+-Categories=Development;
++Categories=Development;Viewer;
++MimeType=application/pdf;
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index ef5c44f9096d..413a80d58e16 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,7 +1,8 @@
 # Template file for 'sioyek'
 pkgname=sioyek
 version=1.5.0
-revision=1
+revision=2
+archs="~aarch64* ~arm*"
 build_style=qmake
 hostmakedepends="qt5-qmake qt5-host-tools
  qt5-opengl qt5-gui qt5-widgets qt5-network"
@@ -15,7 +16,6 @@ license="GPL-3.0-or-later"
 homepage="https://sioyek.info/"
 distfiles="https://github.com/ahrm/sioyek/archive/refs/tags/v${version}.tar.gz"
 checksum=2d01c757953c3f2d98428376e642d13b8a9edeba8fee506477e8aa178756f16b
-nocross=yes
 
 do_build() {
 	qmake pdf_viewer_build_config.pro
@@ -30,5 +30,6 @@ do_install() {
 	vmkdir usr/share/sioyek/shaders
 	vcopy pdf_viewer/shaders/* usr/share/sioyek/shaders
 	vinstall tutorial.pdf 644 usr/share/sioyek
+	vinstall resources/sioyek.desktop 644 usr/share/sioyek
 	vman resources/sioyek.1
 }

Re: [draft] sioyek: add .desktop file

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311921779

Comment:
how about now?

Re: sioyek: add .desktop file, fix arch

[q66]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311966733

Comment:
leave archs alone, there is no problem with sioyek on other architectures

it's likely qmake being miscompiled due to cross, which then breaks native systems

in any case tagging archs here is wrong 

Re: sioyek: add .desktop file, fix arch

[q66]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311967427

Comment:
also the package cannot be crosscompiled, so removing nocross is wrong always 

Re: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1312061448

Comment:
For sure, it fails to natively build on aarch64 with present Void's setup.
I haven't tried to recompile qmake, so cannot comment.
I've noticed that Alpine also does this
`arch="all !aarch64 !armhf !armv7"  # fails to build`
I can put back no cross. What do you want me to do with arch?

Re: [PR PATCH] [Updated] sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages sioy
https://github.com/void-linux/void-packages/pull/40460

sioyek: add .desktop file, fix arch
#### Testing the changes
- I tested the changes in this PR: I'm still unable to select it e.g. in firefox.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/40460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sioy-40460.patch --]
[-- Type: text/x-diff, Size: 1897 bytes --]

From 58bf8c6e0b459f42c9fad0414458bc02a6f5cf13 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 10 Nov 2022 17:53:27 -0500
Subject: [PATCH] sioyek: add .desktop file, restore arch

---
 srcpkgs/sioyek/patches/desktop.patch | 22 ++++++++++++++++++++++
 srcpkgs/sioyek/template              |  4 +++-
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/sioyek/patches/desktop.patch

diff --git a/srcpkgs/sioyek/patches/desktop.patch b/srcpkgs/sioyek/patches/desktop.patch
new file mode 100644
index 000000000000..bf42608b3baa
--- /dev/null
+++ b/srcpkgs/sioyek/patches/desktop.patch
@@ -0,0 +1,22 @@
+diff --git a/resources/sioyek.desktop b/resources/sioyek.desktop
+index cf8b6b2..917fd62 100644
+--- a/resources/sioyek.desktop
++++ b/resources/sioyek.desktop
+@@ -1,8 +1,12 @@
+ [Desktop Entry]
+-Version=1.0
+-Type=Application
+-MimeType=application/pdf;
+ Name=Sioyek
+-Exec=sioyek
++Comment=PDF viewer for reading research papers and technical books
++Keywords=pdf;viewer;reader;research;
++TryExec=sioyek
++Exec=sioyek %U
++StartupNotify=true
++Terminal=false
++Type=Application
+ Icon=sioyek-icon-linux
+-Categories=Development;
++Categories=Development;Viewer;
++MimeType=application/pdf;
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index ef5c44f9096d..b3e6c65209b0 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,7 +1,8 @@
 # Template file for 'sioyek'
 pkgname=sioyek
 version=1.5.0
-revision=1
+revision=2
+archs="~aarch64* ~arm*"
 build_style=qmake
 hostmakedepends="qt5-qmake qt5-host-tools
  qt5-opengl qt5-gui qt5-widgets qt5-network"
@@ -30,5 +31,6 @@ do_install() {
 	vmkdir usr/share/sioyek/shaders
 	vcopy pdf_viewer/shaders/* usr/share/sioyek/shaders
 	vinstall tutorial.pdf 644 usr/share/sioyek
+	vinstall resources/sioyek.desktop 644 usr/share/sioyek
 	vman resources/sioyek.1
 }

Re: sioyek: add .desktop file, fix arch

[paper42]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1312066275

Comment:
If it doesn't even build natively, it should be arch restricted

Re: sioyek: add .desktop file, fix arch

[paper42]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1312066275

Comment:
If it doesn't even build natively, it should be arch restricted, but probably with a list of supported archa, not a list of unsupported.

Re: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1312068674

Comment:
> probably with a list of supported archa, not a list of unsupported.

Which is what I did previously :) how about archs="i686* x86_64* ppc*" ?

Re: sioyek: add .desktop file, fix arch

[paper42]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1312072529

Comment:
I didn't see the comments above... This is tricky, ideally the solution would be to fix qmake, nocross and arch restrictions restrict something that's not broken.

Re: [PR PATCH] [Updated] sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages sioy
https://github.com/void-linux/void-packages/pull/40460

sioyek: add .desktop file, fix arch
#### Testing the changes
- I tested the changes in this PR: I'm still unable to select it e.g. in firefox.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/40460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sioy-40460.patch --]
[-- Type: text/x-diff, Size: 1903 bytes --]

From 3bb5efb45ea703154162906aa4846227d0f2cad1 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 10 Nov 2022 17:53:27 -0500
Subject: [PATCH] sioyek: add .desktop file, restore arch

---
 srcpkgs/sioyek/patches/desktop.patch | 22 ++++++++++++++++++++++
 srcpkgs/sioyek/template              |  4 +++-
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/sioyek/patches/desktop.patch

diff --git a/srcpkgs/sioyek/patches/desktop.patch b/srcpkgs/sioyek/patches/desktop.patch
new file mode 100644
index 000000000000..bf42608b3baa
--- /dev/null
+++ b/srcpkgs/sioyek/patches/desktop.patch
@@ -0,0 +1,22 @@
+diff --git a/resources/sioyek.desktop b/resources/sioyek.desktop
+index cf8b6b2..917fd62 100644
+--- a/resources/sioyek.desktop
++++ b/resources/sioyek.desktop
+@@ -1,8 +1,12 @@
+ [Desktop Entry]
+-Version=1.0
+-Type=Application
+-MimeType=application/pdf;
+ Name=Sioyek
+-Exec=sioyek
++Comment=PDF viewer for reading research papers and technical books
++Keywords=pdf;viewer;reader;research;
++TryExec=sioyek
++Exec=sioyek %U
++StartupNotify=true
++Terminal=false
++Type=Application
+ Icon=sioyek-icon-linux
+-Categories=Development;
++Categories=Development;Viewer;
++MimeType=application/pdf;
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index ef5c44f9096d..dab5c744f830 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,7 +1,8 @@
 # Template file for 'sioyek'
 pkgname=sioyek
 version=1.5.0
-revision=1
+revision=2
+archs="~aarch64* ~arm*"
 build_style=qmake
 hostmakedepends="qt5-qmake qt5-host-tools
  qt5-opengl qt5-gui qt5-widgets qt5-network"
@@ -30,5 +31,6 @@ do_install() {
 	vmkdir usr/share/sioyek/shaders
 	vcopy pdf_viewer/shaders/* usr/share/sioyek/shaders
 	vinstall tutorial.pdf 644 usr/share/sioyek
+	vinstall resources/sioyek.desktop 644 usr/share/applications
 	vman resources/sioyek.1
 }

Re: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311868364

Comment:
also, it still depends on gcc, which looks suspicious (discard this comment)

Re: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1311868364

Comment:
also, it still depends on gcc, which looks suspicious (discard this comment)

Re: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1312201690

Comment:
It's now working as expected.
Let me know what the consesus about arch/nocross is, so this can be merged.

Re: sioyek: add .desktop file, fix arch

[q66]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1312276113

Comment:
don't add any archs, leave it alone

Re: [PR PATCH] [Updated] sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages sioy
https://github.com/void-linux/void-packages/pull/40460

sioyek: add .desktop file, fix arch
#### Testing the changes
- I tested the changes in this PR: yes.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/40460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sioy-40460.patch --]
[-- Type: text/x-diff, Size: 1863 bytes --]

From 3a68ee4bcd094b321c0679db7831cc26857fcfe8 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 10 Nov 2022 17:53:27 -0500
Subject: [PATCH] sioyek: add .desktop file

---
 srcpkgs/sioyek/patches/desktop.patch | 22 ++++++++++++++++++++++
 srcpkgs/sioyek/template              |  3 ++-
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/sioyek/patches/desktop.patch

diff --git a/srcpkgs/sioyek/patches/desktop.patch b/srcpkgs/sioyek/patches/desktop.patch
new file mode 100644
index 000000000000..bf42608b3baa
--- /dev/null
+++ b/srcpkgs/sioyek/patches/desktop.patch
@@ -0,0 +1,22 @@
+diff --git a/resources/sioyek.desktop b/resources/sioyek.desktop
+index cf8b6b2..917fd62 100644
+--- a/resources/sioyek.desktop
++++ b/resources/sioyek.desktop
+@@ -1,8 +1,12 @@
+ [Desktop Entry]
+-Version=1.0
+-Type=Application
+-MimeType=application/pdf;
+ Name=Sioyek
+-Exec=sioyek
++Comment=PDF viewer for reading research papers and technical books
++Keywords=pdf;viewer;reader;research;
++TryExec=sioyek
++Exec=sioyek %U
++StartupNotify=true
++Terminal=false
++Type=Application
+ Icon=sioyek-icon-linux
+-Categories=Development;
++Categories=Development;Viewer;
++MimeType=application/pdf;
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index ef5c44f9096d..7c6c49944b59 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,7 +1,7 @@
 # Template file for 'sioyek'
 pkgname=sioyek
 version=1.5.0
-revision=1
+revision=2
 build_style=qmake
 hostmakedepends="qt5-qmake qt5-host-tools
  qt5-opengl qt5-gui qt5-widgets qt5-network"
@@ -30,5 +30,6 @@ do_install() {
 	vmkdir usr/share/sioyek/shaders
 	vcopy pdf_viewer/shaders/* usr/share/sioyek/shaders
 	vinstall tutorial.pdf 644 usr/share/sioyek
+	vinstall resources/sioyek.desktop 644 usr/share/applications
 	vman resources/sioyek.1
 }

Re: [PR PATCH] [Updated] sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages sioy
https://github.com/void-linux/void-packages/pull/40460

sioyek: add .desktop file, fix arch
#### Testing the changes
- I tested the changes in this PR: yes.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

A patch file from https://github.com/void-linux/void-packages/pull/40460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sioy-40460.patch --]
[-- Type: text/x-diff, Size: 1863 bytes --]

From efbfb8e94d1cfefbbe0e73f4552b58c0fbd5a735 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Thu, 10 Nov 2022 17:53:27 -0500
Subject: [PATCH] sioyek: add .desktop file

---
 srcpkgs/sioyek/patches/desktop.patch | 22 ++++++++++++++++++++++
 srcpkgs/sioyek/template              |  3 ++-
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/sioyek/patches/desktop.patch

diff --git a/srcpkgs/sioyek/patches/desktop.patch b/srcpkgs/sioyek/patches/desktop.patch
new file mode 100644
index 000000000000..bf42608b3baa
--- /dev/null
+++ b/srcpkgs/sioyek/patches/desktop.patch
@@ -0,0 +1,22 @@
+diff --git a/resources/sioyek.desktop b/resources/sioyek.desktop
+index cf8b6b2..917fd62 100644
+--- a/resources/sioyek.desktop
++++ b/resources/sioyek.desktop
+@@ -1,8 +1,12 @@
+ [Desktop Entry]
+-Version=1.0
+-Type=Application
+-MimeType=application/pdf;
+ Name=Sioyek
+-Exec=sioyek
++Comment=PDF viewer for reading research papers and technical books
++Keywords=pdf;viewer;reader;research;
++TryExec=sioyek
++Exec=sioyek %U
++StartupNotify=true
++Terminal=false
++Type=Application
+ Icon=sioyek-icon-linux
+-Categories=Development;
++Categories=Development;Viewer;
++MimeType=application/pdf;
diff --git a/srcpkgs/sioyek/template b/srcpkgs/sioyek/template
index ef5c44f9096d..7c6c49944b59 100644
--- a/srcpkgs/sioyek/template
+++ b/srcpkgs/sioyek/template
@@ -1,7 +1,7 @@
 # Template file for 'sioyek'
 pkgname=sioyek
 version=1.5.0
-revision=1
+revision=2
 build_style=qmake
 hostmakedepends="qt5-qmake qt5-host-tools
  qt5-opengl qt5-gui qt5-widgets qt5-network"
@@ -30,5 +30,6 @@ do_install() {
 	vmkdir usr/share/sioyek/shaders
 	vcopy pdf_viewer/shaders/* usr/share/sioyek/shaders
 	vinstall tutorial.pdf 644 usr/share/sioyek
+	vinstall resources/sioyek.desktop 644 usr/share/applications
 	vman resources/sioyek.1
 }

Re: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1351552003

Comment:
Can this simple change be merged?

Re: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1366009637

Comment:
Superseded by https://github.com/void-linux/void-packages/pull/41318

Re: [PR PATCH] [Closed]: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

There's a closed pull request on the void-packages repository

sioyek: add .desktop file, fix arch
https://github.com/void-linux/void-packages/pull/40460

Description:
#### Testing the changes
- I tested the changes in this PR: yes.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)

Re: sioyek: add .desktop file, fix arch

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/40460#issuecomment-1406926218

Comment:
@q66 For the record, you were right: rebuilding natively qt5-qmake let's me build sioyek-2.0.0