Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [ISSUE] Rewrite mtime of files in packages to the distfile's mtime
Date: Wed, 07 Dec 2022 22:10:53 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40963@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

New issue by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/40963

Description:
Previously in 2016, mtime was always set to the date of the last commit in the package: 16050ad3f292306b0421ee6133b174db3f1b227d
Then in 2018 this mtime was changed to always be set to the date of HEAD because getting the time of the last package change from history was taking too long: a4a229cf6428ecca04d50369d010e028414590e5

This approach doesn't really work well for reproducibility because when HEAD moves, even that commit is unrelated, the whole package gets different timestamps which results in a seemingly random difference when someone merged an old commit to master. This way the mtime can also go backwards on user's systems which can be confusing.

I propose to change this mtime to the mtime of the first distfile and encourage packagers to make sure the first distfile is from the main project if there is more than one. That way the files in the resulting package have a predictable mtime that is also the date of the upstream release.

             reply	other threads:[~2022-12-07 21:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-07 21:10 paper42 [this message]
2022-12-12  6:51 ` paper42
2023-03-13  1:58 ` github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-40963@inbox.vuxu.org \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).