[PR PATCH] gawk: update to 5.2.1.

[PR PATCH] gawk: update to 5.2.1.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages gawk-5.2.1
https://github.com/void-linux/void-packages/pull/40968

gawk: update to 5.2.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40968.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gawk-5.2.1-40968.patch --]
[-- Type: text/x-diff, Size: 1060 bytes --]

From efea1e09c8dc73710b362177985c82f9049c7d34 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 8 Dec 2022 00:20:59 +0000
Subject: [PATCH] gawk: update to 5.2.1.

---
 srcpkgs/gawk/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gawk/template b/srcpkgs/gawk/template
index b5f624bebf45..ad0463c4b6bb 100644
--- a/srcpkgs/gawk/template
+++ b/srcpkgs/gawk/template
@@ -1,6 +1,6 @@
 # Template file for 'gawk'
 pkgname=gawk
-version=5.1.1
+version=5.2.1
 revision=1
 build_style=gnu-configure
 configure_args="--with-readline"
@@ -10,8 +10,10 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://directory.fsf.org/wiki/Gawk"
 distfiles="${GNU_SITE}/${pkgname}/${pkgname}-${version}.tar.xz"
-checksum=d87629386e894bbea11a5e00515fc909dc9b7249529dad9e6a3a2c77085f7ea2
+checksum=673553b91f9e18cc5792ed51075df8d510c9040f550a6f74e09c9add243a7e4f
 lib32disabled=yes
+# PIE is disabled for persistent malloc.
+nopie=yes
 
 provides="awk-0_1"
 alternatives="

Re: [PR REVIEW] gawk: update to 5.2.1.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/40968#discussion_r1042808973

Comment:
See https://www.gnu.org/software/gawk/manual/html_node/Persistent-Memory.html. Given that this feature is experimental, maybe it should just be disabled? If we're keeping it, we should disable PIE only on systems supporting persistent malloc which, according to that link, are "64-bit systems supporting the mmap() and munmap() system calls." Does that include x86_64-musl, or only x86_64?

Re: [PR REVIEW] gawk: update to 5.2.1.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/40968#discussion_r1042808973

Comment:
See https://www.gnu.org/software/gawk/manual/html_node/Persistent-Memory.html. Given that this feature is experimental, maybe it should just be disabled? If we're keeping it, we should disable PIE only on systems supporting persistent malloc which, according to that link, are "64-bit systems supporting the mmap() and munmap() system calls." Which systems are those?

Re: [PR REVIEW] gawk: update to 5.2.1.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/40968#discussion_r1042917117

Comment:
Please disable it.

Re: [PR REVIEW] gawk: update to 5.2.1.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/40968#discussion_r1042918332

Comment:
`mmap(2)` and `munmap(2)` are POSIX, Linux supports them.

Re: [PR PATCH] [Updated] gawk: update to 5.2.1.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages gawk-5.2.1
https://github.com/void-linux/void-packages/pull/40968

gawk: update to 5.2.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40968.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gawk-5.2.1-40968.patch --]
[-- Type: text/x-diff, Size: 1083 bytes --]

From b4b5547b17b8bcfb65cbf3084ddcfe0ae6a953cb Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 8 Dec 2022 00:20:59 +0000
Subject: [PATCH] gawk: update to 5.2.1.

---
 srcpkgs/gawk/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/gawk/template b/srcpkgs/gawk/template
index b5f624bebf45..1373b78baa8a 100644
--- a/srcpkgs/gawk/template
+++ b/srcpkgs/gawk/template
@@ -1,16 +1,16 @@
 # Template file for 'gawk'
 pkgname=gawk
-version=5.1.1
+version=5.2.1
 revision=1
 build_style=gnu-configure
-configure_args="--with-readline"
+configure_args="--with-readline --disable-pma"
 makedepends="readline-devel"
 short_desc="GNU awk utility"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://directory.fsf.org/wiki/Gawk"
 distfiles="${GNU_SITE}/${pkgname}/${pkgname}-${version}.tar.xz"
-checksum=d87629386e894bbea11a5e00515fc909dc9b7249529dad9e6a3a2c77085f7ea2
+checksum=673553b91f9e18cc5792ed51075df8d510c9040f550a6f74e09c9add243a7e4f
 lib32disabled=yes
 
 provides="awk-0_1"

Re: [PR REVIEW] gawk: update to 5.2.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40968#discussion_r1045410436

Comment:
```suggestion
distfiles="${GNU_SITE}/gawk/gawk-${version}.tar.xz"
```

Re: [PR PATCH] [Updated] gawk: update to 5.2.1.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages gawk-5.2.1
https://github.com/void-linux/void-packages/pull/40968

gawk: update to 5.2.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40968.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gawk-5.2.1-40968.patch --]
[-- Type: text/x-diff, Size: 1138 bytes --]

From a205c9343d857da0d5e01568e3ea4a6d1bd5603d Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 8 Dec 2022 00:20:59 +0000
Subject: [PATCH] gawk: update to 5.2.1.

---
 srcpkgs/gawk/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gawk/template b/srcpkgs/gawk/template
index b5f624bebf45..f203c4f337ad 100644
--- a/srcpkgs/gawk/template
+++ b/srcpkgs/gawk/template
@@ -1,16 +1,16 @@
 # Template file for 'gawk'
 pkgname=gawk
-version=5.1.1
+version=5.2.1
 revision=1
 build_style=gnu-configure
-configure_args="--with-readline"
+configure_args="--with-readline --disable-pma"
 makedepends="readline-devel"
 short_desc="GNU awk utility"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://directory.fsf.org/wiki/Gawk"
-distfiles="${GNU_SITE}/${pkgname}/${pkgname}-${version}.tar.xz"
-checksum=d87629386e894bbea11a5e00515fc909dc9b7249529dad9e6a3a2c77085f7ea2
+distfiles="${GNU_SITE}/gawk/gawk-${version}.tar.xz"
+checksum=673553b91f9e18cc5792ed51075df8d510c9040f550a6f74e09c9add243a7e4f
 lib32disabled=yes
 
 provides="awk-0_1"

Re: [PR PATCH] [Updated] gawk: update to 5.2.1.

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

There is an updated pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages gawk-5.2.1
https://github.com/void-linux/void-packages/pull/40968

gawk: update to 5.2.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/40968.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gawk-5.2.1-40968.patch --]
[-- Type: text/x-diff, Size: 2358 bytes --]

From a1fe8514ae8502395cead3e22f315067886dcac6 Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 8 Dec 2022 00:20:59 +0000
Subject: [PATCH 1/2] gawk: update to 5.2.1.

---
 srcpkgs/gawk/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gawk/template b/srcpkgs/gawk/template
index b5f624bebf45..f203c4f337ad 100644
--- a/srcpkgs/gawk/template
+++ b/srcpkgs/gawk/template
@@ -1,16 +1,16 @@
 # Template file for 'gawk'
 pkgname=gawk
-version=5.1.1
+version=5.2.1
 revision=1
 build_style=gnu-configure
-configure_args="--with-readline"
+configure_args="--with-readline --disable-pma"
 makedepends="readline-devel"
 short_desc="GNU awk utility"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://directory.fsf.org/wiki/Gawk"
-distfiles="${GNU_SITE}/${pkgname}/${pkgname}-${version}.tar.xz"
-checksum=d87629386e894bbea11a5e00515fc909dc9b7249529dad9e6a3a2c77085f7ea2
+distfiles="${GNU_SITE}/gawk/gawk-${version}.tar.xz"
+checksum=673553b91f9e18cc5792ed51075df8d510c9040f550a6f74e09c9add243a7e4f
 lib32disabled=yes
 
 provides="awk-0_1"

From ad5fdcb9015154c179f2ff1e5433790a4ff60bee Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Tue, 21 Feb 2023 08:53:50 +0100
Subject: [PATCH 2/2] chroot-gawk: update to 5.2.1.

---
 srcpkgs/chroot-gawk/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/chroot-gawk/template b/srcpkgs/chroot-gawk/template
index 1217a9d982fa..ed37b8840aa0 100644
--- a/srcpkgs/chroot-gawk/template
+++ b/srcpkgs/chroot-gawk/template
@@ -1,15 +1,16 @@
 # Template file for 'chroot-gawk'
 pkgname=chroot-gawk
-version=5.0.1
+version=5.2.1
 revision=1
 build_style=gnu-configure
-configure_args="--disable-nls --without-readline ac_cv_libsigsegv=/bin/false"
+configure_args="--disable-nls --without-readline ac_cv_libsigsegv=/bin/false
+ --disable-pma"
 short_desc="GNU awk utility -- for xbps-src use"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="GPL-3.0-or-later"
 homepage="https://directory.fsf.org/wiki/Gawk"
 distfiles="${GNU_SITE}/gawk/gawk-${version}.tar.xz"
-checksum=8e4e86f04ed789648b66f757329743a0d6dfb5294c3b91b756a474f1ce05a794
+checksum=673553b91f9e18cc5792ed51075df8d510c9040f550a6f74e09c9add243a7e4f
 repository=bootstrap
 
 bootstrap=yes

Re: gawk: update to 5.2.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/40968#issuecomment-1474540445

Comment:
let's hold off on this for now - q66 has found some issues with stack overflows in 5.2 even with pma disabled