Github messages for voidlinux
 help / color / mirror / Atom feed
From: sbromberger <sbromberger@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Update run
Date: Sat, 24 Dec 2022 18:58:14 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41272@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

There is a new pull request by sbromberger against master on the void-packages repository

https://github.com/sbromberger/void-packages patch-1
https://github.com/void-linux/void-packages/pull/41272

Update run
Remove `modprobe -q loop || exit 1` to enable docker to work within containers, where kernel modules may not exist/be loadable. The absence of the loop kmod does not appear to negatively impact docker running within a container.

Note: to run in containers, the rest of the script doesn't work either: adding `mount -t cgroup2 cgroup2 /sys/fs/cgroup/` to `/etc/rc.local` makes things work without issue. Modifying the systemd mountpoint check is too big a change to propose without extensive testing so I haven't included it as part of this PR.


#### Testing the changes
- I tested the changes in this PR: **YES***
Note: tested within a container only; I do not have access to void running on metal.

#### Local build testing
- I built this PR locally for my native architecture, `Linux boron 6.0.13_1 #1 SMP PREEMPT_DYNAMIC Fri Dec 16 02:05:26 UTC 2022 x86_64 GNU/Linux` (glibc)



A patch file from https://github.com/void-linux/void-packages/pull/41272.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-41272.patch --]
[-- Type: text/x-diff, Size: 910 bytes --]

From a448be038f4277983be022ecabe25b7757cc7aa5 Mon Sep 17 00:00:00 2001
From: Seth Bromberger <sbromberger@users.noreply.github.com>
Date: Sat, 24 Dec 2022 12:51:44 -0500
Subject: [PATCH] Update run

Remove `modprobe -q loop || exit 1` to enable docker to work within containers, where kernel modules may not exist. The absence of the loop kmod does not appear to negatively impact docker running within a container.
---
 srcpkgs/moby/files/docker/run | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/moby/files/docker/run b/srcpkgs/moby/files/docker/run
index ed42f5fa72f8..438fb1a917c0 100644
--- a/srcpkgs/moby/files/docker/run
+++ b/srcpkgs/moby/files/docker/run
@@ -1,6 +1,5 @@
 #!/bin/sh
 [ -r conf ] && . ./conf
-modprobe -q loop || exit 1
 mountpoint -q /sys/fs/cgroup/systemd || {
     mkdir -p /sys/fs/cgroup/systemd;
     mount -t cgroup -o none,name=systemd cgroup /sys/fs/cgroup/systemd;

             reply	other threads:[~2022-12-24 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-24 17:58 sbromberger [this message]
2022-12-24 18:45 ` [PR PATCH] [Closed]: Update sv run script for moby to remove loop modprobe check sbromberger
2022-12-24 18:45 ` sbromberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41272@inbox.vuxu.org \
    --to=sbromberger@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).