Github messages for voidlinux
 help / color / mirror / Atom feed
From: mhmdanas <mhmdanas@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] sway: don't set capabilities on binary.
Date: Fri, 30 Dec 2022 04:18:21 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41358@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages sway-dont-set-CAP_SYS_NICE
https://github.com/void-linux/void-packages/pull/41358

sway: don't set capabilities on binary.
Setting these capabilities on the Sway binary breaks loading custom keymaps in user directories.

Relevant:
- https://github.com/swaywm/sway/pull/7326 (this commit can be reverted when this PR is merged in a future Sway release)
- https://github.com/xkbcommon/libxkbcommon/pull/312

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41358.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sway-dont-set-CAP_SYS_NICE-41358.patch --]
[-- Type: text/x-diff, Size: 1248 bytes --]

From 3143aa9392c6c291dfa22d82dd4b0965c74be87e Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 29 Dec 2022 21:51:03 +0000
Subject: [PATCH] sway: don't set capabilities on binary.

Setting these capabilities on the Sway binary breaks loading custom
keymaps in user directories.

Relevant:
- https://github.com/swaywm/sway/pull/7326 (this commit can be reverted
  when this PR is merged in a future Sway release)
- https://github.com/xkbcommon/libxkbcommon/pull/312
---
 srcpkgs/sway/INSTALL  | 5 -----
 srcpkgs/sway/template | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)
 delete mode 100644 srcpkgs/sway/INSTALL

diff --git a/srcpkgs/sway/INSTALL b/srcpkgs/sway/INSTALL
deleted file mode 100644
index 0120d14908bc..000000000000
--- a/srcpkgs/sway/INSTALL
+++ /dev/null
@@ -1,5 +0,0 @@
-case "${ACTION}" in
-post)
-	setcap CAP_SYS_NICE=+ep usr/bin/sway
-	;;
-esac
diff --git a/srcpkgs/sway/template b/srcpkgs/sway/template
index db51ad2a359d..26f3254fedb3 100644
--- a/srcpkgs/sway/template
+++ b/srcpkgs/sway/template
@@ -1,7 +1,7 @@
 # Template file for 'sway'
 pkgname=sway
 version=1.8
-revision=1
+revision=2
 build_style=meson
 configure_args="-Dwerror=false -Db_ndebug=false"
 conf_files="/etc/sway/config"

             reply	other threads:[~2022-12-30  3:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30  3:18 mhmdanas [this message]
2022-12-30  9:31 ` ardadem
2022-12-30  9:56 ` paper42
2022-12-30 13:52 ` mhmdanas
2022-12-30 13:52 ` mhmdanas
2023-01-05  5:39 ` Seltyk
2023-01-05 14:49 ` mhmdanas
2023-01-05 17:48 ` mhmdanas
2023-01-05 23:48 ` [PR PATCH] [Updated] " mhmdanas
2023-01-05 23:53 ` sway: fix custom user keymaps mhmdanas
2023-01-12 10:05 ` ardadem
2023-01-12 15:53 ` mhmdanas
2023-01-12 16:13 ` paper42
2023-01-12 16:40 ` [PR PATCH] [Updated] " mhmdanas
2023-01-12 21:08 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41358@inbox.vuxu.org \
    --to=mhmdanas@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).