Github messages for voidlinux
 help / color / mirror / Atom feed
From: kruceter <kruceter@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] mame: fix build
Date: Wed, 18 Jan 2023 00:00:39 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41706@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]

There is a new pull request by kruceter against master on the void-packages repository

https://github.com/kruceter/void-packages mame-fix
https://github.com/void-linux/void-packages/pull/41706

mame: fix build
`libXinerama-devel` was the missing dependency (see https://vasilek.cz/logs/rebuild3/bad/mame.txt).

```
Compiling generated/mame/mame/drivlist.cpp...
Linking mame...
/usr/bin/ld: cannot find -lXinerama
collect2: error: ld returned 1 exit status
make[2]: *** [mame.make:269: ../../../../../mame] Error 1
make[1]: *** [Makefile:1144: mame] Error 2
make: *** [makefile:1387: linux_x64] Error 2
=> ERROR: mame-0229_1: do_build: 'make OVERRIDE_CC="$CC" OVERRIDE_CXX="$CXX" OVERRIDE_LD="$CXX" ${makejobs} ${_options}' exited with 2
=> ERROR:   in do_build() at srcpkgs/mame/template:94
```

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/41706.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mame-fix-41706.patch --]
[-- Type: text/x-diff, Size: 963 bytes --]

From aa23bc043014a890fc429802132da7ff59a9e62b Mon Sep 17 00:00:00 2001
From: Krul Ceter <kruceter@proton.me>
Date: Wed, 18 Jan 2023 01:51:12 +0300
Subject: [PATCH] mame: fix build

libXinerama-devel was the missing dependency.
---
 srcpkgs/mame/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/mame/template b/srcpkgs/mame/template
index 93c5d5f74880..e31944b09656 100644
--- a/srcpkgs/mame/template
+++ b/srcpkgs/mame/template
@@ -5,7 +5,7 @@ revision=1
 hostmakedepends="pkg-config python3 qt5-host-tools tar xz which"
 makedepends="SDL2_ttf-devel fontconfig-devel glm libgomp-devel libjpeg-turbo-devel
  lua-devel libutf8proc-devel libuv-devel portaudio-devel portmidi-devel
- pugixml-devel rapidjson $(vopt_if qt 'qt5-devel')"
+ pugixml-devel libXinerama-devel rapidjson $(vopt_if qt 'qt5-devel')"
 depends="liberation-fonts-ttf"
 short_desc="Multiple Arcade Machine Emulator"
 maintainer="Orphaned <orphan@voidlinux.org>"

             reply	other threads:[~2023-01-17 23:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 23:00 kruceter [this message]
2023-01-19  2:39 ` [PR PATCH] [Closed]: " kruceter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41706@inbox.vuxu.org \
    --to=kruceter@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).