[PR PATCH] gscreenshot: update to 3.2.1.

[PR PATCH] gscreenshot: update to 3.2.1.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gscreenshot
https://github.com/void-linux/void-packages/pull/41905

gscreenshot: update to 3.2.1.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

I think scrot shouldn't be a hard dependencny here since it has full [wayland compatibility](https://github.com/thenaterhood/gscreenshot#for-full-functionality-on-wayland-the-recommended-packages-are)

A patch file from https://github.com/void-linux/void-packages/pull/41905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gscreenshot-41905.patch --]
[-- Type: text/x-diff, Size: 1623 bytes --]

From 7dffc6d32ef4848355d1ca30cb5cfa6e3994a0c3 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 28 Jan 2023 01:19:46 +0530
Subject: [PATCH] gscreenshot: update to 3.2.1.

---
 srcpkgs/gscreenshot/template | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/gscreenshot/template b/srcpkgs/gscreenshot/template
index 008172670ed4..4b5056da9875 100644
--- a/srcpkgs/gscreenshot/template
+++ b/srcpkgs/gscreenshot/template
@@ -1,15 +1,18 @@
 # Template file for 'gscreenshot'
 pkgname=gscreenshot
-version=2.17.1
-revision=2
+version=3.2.1
+revision=1
 build_style=python3-module
-hostmakedepends="python3-setuptools gettext"
+hostmakedepends="python3-setuptools gettext go-md2man"
 depends="gtk+3 python3-setuptools python3-Pillow python3-gobject scrot"
-short_desc="GUI front-end for the scrot program"
+checkdepends="${depends} python3-mock python3-pytest"
+short_desc="GUI for multiple screenshot backends including scrot, PIL, and grim"
 maintainer="Rui Flora <rui.flora@gmail.com>"
-license="GPL-2.0-or-later"
+license="GPL-2.0-only"
 homepage="https://github.com/thenaterhood/gscreenshot"
-distfiles="https://github.com/thenaterhood/gscreenshot/archive/v${version}.tar.gz"
-checksum=f0cdf81e9ab483e11c04ed27141ac37dd6f24415968bc5f4c874e7b17ca5958d
-# doesn't ship any tests
-make_check=no
+distfiles="https://github.com/thenaterhood/gscreenshot/archive/refs/tags/v${version}.tar.gz"
+checksum=a98ecbe501f4d49824238af6fbb09fa71b5bbe6af32cfcf60b6cbe814b3e3250
+
+do_check() {
+	(cd src && PYTHONPATH="$(cd build/lib* && pwd)" python3 -m pytest ../test)
+}

Re: [PR PATCH] [Updated] gscreenshot: update to 3.2.1.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gscreenshot
https://github.com/void-linux/void-packages/pull/41905

gscreenshot: update to 3.2.1.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

I think scrot shouldn't be a hard dependencny here since it has full [wayland compatibility](https://github.com/thenaterhood/gscreenshot#for-full-functionality-on-wayland-the-recommended-packages-are)

A patch file from https://github.com/void-linux/void-packages/pull/41905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gscreenshot-41905.patch --]
[-- Type: text/x-diff, Size: 1623 bytes --]

From bbfb76001fdf88204681fa604ac3ba5a78d57927 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 28 Jan 2023 01:19:46 +0530
Subject: [PATCH] gscreenshot: update to 3.3.0.

---
 srcpkgs/gscreenshot/template | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/gscreenshot/template b/srcpkgs/gscreenshot/template
index 008172670ed4..39d47e4c3cdc 100644
--- a/srcpkgs/gscreenshot/template
+++ b/srcpkgs/gscreenshot/template
@@ -1,15 +1,18 @@
 # Template file for 'gscreenshot'
 pkgname=gscreenshot
-version=2.17.1
-revision=2
+version=3.3.0
+revision=1
 build_style=python3-module
-hostmakedepends="python3-setuptools gettext"
+hostmakedepends="python3-setuptools gettext go-md2man"
 depends="gtk+3 python3-setuptools python3-Pillow python3-gobject scrot"
-short_desc="GUI front-end for the scrot program"
+checkdepends="${depends} python3-mock python3-pytest"
+short_desc="GUI for multiple screenshot backends including scrot, PIL, and grim"
 maintainer="Rui Flora <rui.flora@gmail.com>"
-license="GPL-2.0-or-later"
+license="GPL-2.0-only"
 homepage="https://github.com/thenaterhood/gscreenshot"
-distfiles="https://github.com/thenaterhood/gscreenshot/archive/v${version}.tar.gz"
-checksum=f0cdf81e9ab483e11c04ed27141ac37dd6f24415968bc5f4c874e7b17ca5958d
-# doesn't ship any tests
-make_check=no
+distfiles="https://github.com/thenaterhood/gscreenshot/archive/refs/tags/v${version}.tar.gz"
+checksum=f05e695676cda97483c6cdbebaba9a708b5791e544e977016a772325a1d37231
+
+do_check() {
+	(cd src && PYTHONPATH="$(cd build/lib* && pwd)" python3 -m pytest ../test)
+}

Re: [PR REVIEW] gscreenshot: update to 3.3.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41905#discussion_r1096595924

Comment:
could you ask about this upstream?

Re: gscreenshot: update to 3.3.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/41905#issuecomment-1416868864

Comment:
> I think scrot shouldn't be a hard dependencny here since it has full [wayland compatibility](https://github.com/thenaterhood/gscreenshot#for-full-functionality-on-wayland-the-recommended-packages-are)

I think we can remove it

Re: [PR REVIEW] gscreenshot: update to 3.3.0.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/41905#discussion_r1096753932

Comment:
https://github.com/thenaterhood/gscreenshot/issues/166

Re: [PR PATCH] [Updated] gscreenshot: update to 3.3.0.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages gscreenshot
https://github.com/void-linux/void-packages/pull/41905

gscreenshot: update to 3.3.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

I think scrot shouldn't be a hard dependencny here since it has full [wayland compatibility](https://github.com/thenaterhood/gscreenshot#for-full-functionality-on-wayland-the-recommended-packages-are)

A patch file from https://github.com/void-linux/void-packages/pull/41905.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gscreenshot-41905.patch --]
[-- Type: text/x-diff, Size: 1822 bytes --]

From 60e539e6d0efaf37ca71bce1cd1a7ed061288a25 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 28 Jan 2023 01:19:46 +0530
Subject: [PATCH] gscreenshot: update to 3.3.0.

---
 srcpkgs/gscreenshot/template | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/srcpkgs/gscreenshot/template b/srcpkgs/gscreenshot/template
index 008172670ed4..a9af8ac0d8ee 100644
--- a/srcpkgs/gscreenshot/template
+++ b/srcpkgs/gscreenshot/template
@@ -1,15 +1,20 @@
 # Template file for 'gscreenshot'
 pkgname=gscreenshot
-version=2.17.1
-revision=2
+version=3.3.0
+revision=1
 build_style=python3-module
-hostmakedepends="python3-setuptools gettext"
-depends="gtk+3 python3-setuptools python3-Pillow python3-gobject scrot"
-short_desc="GUI front-end for the scrot program"
+hostmakedepends="python3-setuptools gettext go-md2man"
+# refer to https://github.com/thenaterhood/gscreenshot#installation
+# for optional dependencies across system configurations
+depends="gtk+3 python3-setuptools python3-Pillow python3-gobject"
+checkdepends="${depends} python3-mock python3-pytest"
+short_desc="GUI for multiple screenshot backends including scrot, PIL, and grim"
 maintainer="Rui Flora <rui.flora@gmail.com>"
-license="GPL-2.0-or-later"
+license="GPL-2.0-only"
 homepage="https://github.com/thenaterhood/gscreenshot"
-distfiles="https://github.com/thenaterhood/gscreenshot/archive/v${version}.tar.gz"
-checksum=f0cdf81e9ab483e11c04ed27141ac37dd6f24415968bc5f4c874e7b17ca5958d
-# doesn't ship any tests
-make_check=no
+distfiles="https://github.com/thenaterhood/gscreenshot/archive/refs/tags/v${version}.tar.gz"
+checksum=f05e695676cda97483c6cdbebaba9a708b5791e544e977016a772325a1d37231
+
+do_check() {
+	(cd src && PYTHONPATH="$(cd build/lib* && pwd)" python3 -m pytest ../test)
+}

Re: [PR PATCH] [Merged]: gscreenshot: update to 3.3.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

There's a merged pull request on the void-packages repository

gscreenshot: update to 3.3.0.
https://github.com/void-linux/void-packages/pull/41905

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

I think scrot shouldn't be a hard dependencny here since it has full [wayland compatibility](https://github.com/thenaterhood/gscreenshot#for-full-functionality-on-wayland-the-recommended-packages-are)