Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable
@ 2023-02-05 12:53 tranzystorek-io
  2023-02-05 14:13 ` sgn
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: tranzystorek-io @ 2023-02-05 12:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

There is a new pull request by tranzystorek-io against master on the void-packages repository

https://github.com/tranzystorek-io/void-packages rust-target
https://github.com/void-linux/void-packages/pull/42093

common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable
<!-- Uncomment relevant sections and delete options which are not applicable -->

Found when preparing an update for Rust

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42093.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-target-42093.patch --]
[-- Type: text/x-diff, Size: 944 bytes --]

From a492b89ee98a5c30f79f8850735675b58de0e90e Mon Sep 17 00:00:00 2001
From: Marcin Puc <tranzystorek.io@protonmail.com>
Date: Sun, 5 Feb 2023 13:50:33 +0100
Subject: [PATCH] common/environment/setup/sourcepkg.sh: preserve RUST_TARGET
 variable

---
 common/environment/setup/sourcepkg.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/environment/setup/sourcepkg.sh b/common/environment/setup/sourcepkg.sh
index 4e3b4e98ba43..9d8b7f419f58 100644
--- a/common/environment/setup/sourcepkg.sh
+++ b/common/environment/setup/sourcepkg.sh
@@ -5,7 +5,7 @@
 for var in $(awk 'BEGIN{for (i in ENVIRON) {print i}}' </dev/null); do
 	# Those variables in chroot.sh will be kept
 	case "$var" in
-	XBPS_* | IN_CHROOT | CHROOT_READY | SOURCE_DATE_EPOCH)
+	XBPS_* | IN_CHROOT | CHROOT_READY | SOURCE_DATE_EPOCH | RUST_TARGET)
 		# xbps-src specific
 		;;
 	SOURCEFORGE_SITE | NONGNU_SITE | XORG_SITE | DEBIAN_SITE | GNOME_SITE)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable
  2023-02-05 12:53 [PR PATCH] common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable tranzystorek-io
@ 2023-02-05 14:13 ` sgn
  2023-02-05 14:19 ` [PR PATCH] [Closed]: " sgn
  2023-02-05 14:22 ` sgn
  2 siblings, 0 replies; 4+ messages in thread
From: sgn @ 2023-02-05 14:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/42093#issuecomment-1417950661

Comment:
Why? `RUST_TARGET` should be set in its profile, no?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable
  2023-02-05 12:53 [PR PATCH] common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable tranzystorek-io
  2023-02-05 14:13 ` sgn
@ 2023-02-05 14:19 ` sgn
  2023-02-05 14:22 ` sgn
  2 siblings, 0 replies; 4+ messages in thread
From: sgn @ 2023-02-05 14:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

There's a closed pull request on the void-packages repository

common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable
https://github.com/void-linux/void-packages/pull/42093

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

Found when preparing an update for Rust

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable
  2023-02-05 12:53 [PR PATCH] common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable tranzystorek-io
  2023-02-05 14:13 ` sgn
  2023-02-05 14:19 ` [PR PATCH] [Closed]: " sgn
@ 2023-02-05 14:22 ` sgn
  2 siblings, 0 replies; 4+ messages in thread
From: sgn @ 2023-02-05 14:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/42093#issuecomment-1417960869

Comment:
`RUST_TARGET` is set by `common/xbps-src/shutils/common.sh`, together with `CFLAGS`, keep it will break all assumption.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-02-05 14:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-05 12:53 [PR PATCH] common/environment/setup/sourcepkg.sh: preserve RUST_TARGET variable tranzystorek-io
2023-02-05 14:13 ` sgn
2023-02-05 14:19 ` [PR PATCH] [Closed]: " sgn
2023-02-05 14:22 ` sgn

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).