Github messages for voidlinux
 help / color / mirror / Atom feed
From: steinex <steinex@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] redis: restrict /etc/redis permissions
Date: Thu, 23 Feb 2023 11:56:20 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42408@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

There is a new pull request by steinex against master on the void-packages repository

https://github.com/steinex/void-packages redis
https://github.com/void-linux/void-packages/pull/42408

redis: restrict /etc/redis permissions
It's not a good idea to have /etc/redis/redis.conf world-readable since it may contain sensitive informations like passwords.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/42408.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-redis-42408.patch --]
[-- Type: text/x-diff, Size: 1069 bytes --]

From 58ee38e14e69a27551709248d95c12021fb24ee2 Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Thu, 23 Feb 2023 11:54:11 +0100
Subject: [PATCH] redis: restrict /etc/redis permissions

It's not a good idea to have /etc/redis/redis.conf world-readable since
it may contain sensitive informations like passwords.
---
 srcpkgs/redis/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/redis/template b/srcpkgs/redis/template
index 0cd5302a434c..1d6890e2d00d 100644
--- a/srcpkgs/redis/template
+++ b/srcpkgs/redis/template
@@ -1,7 +1,7 @@
 # Template file for 'redis'
 pkgname=redis
 version=7.0.8
-revision=1
+revision=2
 build_style=gnu-makefile
 make_build_args="V=1"
 make_check_target="test"
@@ -18,7 +18,9 @@ system_accounts="redis"
 redis_homedir="/var/lib/redis"
 conf_files="/etc/redis/redis.conf"
 
-make_dirs="/var/lib/redis 0700 redis redis"
+make_dirs="
+	/var/lib/redis 0700 redis redis
+	/etc/redis 0700 redis redis"
 
 if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
 	make_build_args+=" MALLOC=libc"

             reply	other threads:[~2023-02-23 10:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 10:56 steinex [this message]
2023-03-06  9:06 ` [PR PATCH] [Updated] " steinex
2023-03-06  9:09 ` steinex
2023-03-06  9:52 ` [PR PATCH] [Updated] " steinex
2023-03-12 16:48 ` [PR PATCH] [Merged]: " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42408@inbox.vuxu.org \
    --to=steinex@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).