Github messages for voidlinux
 help / color / mirror / Atom feed
From: gmbeard <gmbeard@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] eggdrop: Remove useless vsed
Date: Sat, 18 Mar 2023 15:17:11 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42837@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

There is a new pull request by gmbeard against master on the void-packages repository

https://github.com/gmbeard/void-packages fix/eggdrop-useless-vsed
https://github.com/void-linux/void-packages/pull/42837

eggdrop: Remove useless vsed
<!-- Uncomment relevant sections and delete options which are not applicable -->

Addresses part of tracking issue #42441
- [x] eggdrop

#### Testing the changes
- I tested the changes in this PR: **briefly**

Running the binary both before and after this change gives the following error:

    $ eggdrop
    LANG: No lang files found for section core.

    Eggdrop v1.9.4 (C) 1997 Robey Pointer (C) 2010-2022 Eggheads
    --- Loading eggdrop v1.9.4 (Sat Mar 18 2023)
    * MSG534

I don't use *eggdrop* so I'm not sure how to test this further. Happy to take advice on this and retest if needed.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86\_64-glibc


A patch file from https://github.com/void-linux/void-packages/pull/42837.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/eggdrop-useless-vsed-42837.patch --]
[-- Type: text/x-diff, Size: 773 bytes --]

From fe269eec35f293ce3dc9ad3247a445a4b997937a Mon Sep 17 00:00:00 2001
From: Greg Beard <gmbeard@googlemail.com>
Date: Sat, 18 Mar 2023 14:01:27 +0000
Subject: [PATCH] eggdrop: Remove useless vsed

`vsed` for `language/` in `eggdrop.conf` doesn't modify anything
---
 srcpkgs/eggdrop/template | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/srcpkgs/eggdrop/template b/srcpkgs/eggdrop/template
index 4e356ec0add2..f5f5a504030f 100644
--- a/srcpkgs/eggdrop/template
+++ b/srcpkgs/eggdrop/template
@@ -33,6 +33,9 @@ do_install() {
 	for _asset in language scripts help; do
 		vmkdir "${_share}/${_asset}/"
 		vcopy "ed_staging/${_asset}/*" "${_share}/${_asset}"
+	done
+
+	for _asset in scripts help; do
 		vsed -e "s|${_asset}/|/${_share}/&|" -i eggdrop.conf
 	done
 

             reply	other threads:[~2023-03-18 14:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-18 14:17 gmbeard [this message]
2023-03-20  4:31 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42837@inbox.vuxu.org \
    --to=gmbeard@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).