Github messages for voidlinux
 help / color / mirror / Atom feed
From: ismaell <ismaell@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] rpm: Remove obsolete dependency on error.h
Date: Thu, 23 Mar 2023 03:14:00 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42940@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

There is a new pull request by ismaell against master on the void-packages repository

https://github.com/ismaell/void-packages rpm-no-error.h
https://github.com/void-linux/void-packages/pull/42940

rpm: Remove obsolete dependency on error.h
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-musl`)


A patch file from https://github.com/void-linux/void-packages/pull/42940.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rpm-no-error.h-42940.patch --]
[-- Type: text/x-diff, Size: 1118 bytes --]

From 0548742ea18f9ec29823b7de39ab43b6a73d0277 Mon Sep 17 00:00:00 2001
From: Ismael Luceno <ismael@iodev.co.uk>
Date: Thu, 23 Mar 2023 03:05:08 +0100
Subject: [PATCH] rpm: doesn't depends on error.h anymore

Closes: https://github.com/void-linux/void-packages/issues/36668
---
 srcpkgs/rpm/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/rpm/template b/srcpkgs/rpm/template
index 3f2b3915daa0..02b06b60b86a 100644
--- a/srcpkgs/rpm/template
+++ b/srcpkgs/rpm/template
@@ -1,7 +1,7 @@
 # Template file for 'rpm'
 pkgname=rpm
 version=4.17.1
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="--with-cap --with-acl
  --enable-python PYTHON=python3 --sharedstatedir=/var/lib"
@@ -22,9 +22,8 @@ CFLAGS="-I${XBPS_CROSS_BASE}/${py3_inc}"
 
 case "$XBPS_TARGET_MACHINE" in
 	# rpm uses _nl_msg_cat_cntr, so it needs the glibc gettext impl
-	# it uses <error.h> header, provided by legacy-compat
 	*-musl)
-	makedepends+=" gettext-devel musl-legacy-compat"
+	makedepends+=" gettext-devel"
 	CFLAGS+=" -I${XBPS_CROSS_BASE}/usr/include/gettext"
 	LDFLAGS="-lintl"
 	;;

             reply	other threads:[~2023-03-23  2:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23  2:14 ismaell [this message]
2023-03-23  2:18 ` sgn
2023-03-23 20:57 ` [PR PATCH] [Updated] " ismaell
2023-03-23 21:01 ` ismaell
2023-03-23 21:02 ` ismaell
2023-03-23 21:03 ` [PR PATCH] [Closed]: " ismaell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-42940@inbox.vuxu.org \
    --to=ismaell@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).