Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] atop: Remove ineffective vsed
@ 2023-03-26 12:39 gmbeard
  2023-03-26 12:46 ` [PR PATCH] [Closed]: " gmbeard
  2023-03-26 12:47 ` gmbeard
  0 siblings, 2 replies; 3+ messages in thread
From: gmbeard @ 2023-03-26 12:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]

There is a new pull request by gmbeard against master on the void-packages repository

https://github.com/gmbeard/void-packages fix/atop-ineffective-vsed
https://github.com/void-linux/void-packages/pull/43027

atop: Remove ineffective vsed
<!-- Uncomment relevant sections and delete options which are not applicable -->

Addresses part of tracking issue #42441
- [x] atop

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86\_64-glibc
- I built this PR locally for these architectures:
  - i686
  - aarch64


A patch file from https://github.com/void-linux/void-packages/pull/43027.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/atop-ineffective-vsed-43027.patch --]
[-- Type: text/x-diff, Size: 770 bytes --]

From 787578436ca106d73e0b5c62a1f5ac204a53c5fd Mon Sep 17 00:00:00 2001
From: Greg Beard <gmbeard@googlemail.com>
Date: Sun, 26 Mar 2023 13:35:41 +0100
Subject: [PATCH] atop: Remove ineffective vsed

---
 srcpkgs/atop/template | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/srcpkgs/atop/template b/srcpkgs/atop/template
index 376f8369d511..55a37a2bb40e 100644
--- a/srcpkgs/atop/template
+++ b/srcpkgs/atop/template
@@ -15,9 +15,7 @@ checksum=ca48d2f17e071deead5e6e9cc9e388bf6a3270d695e61976b3794d4d927b5c4e
 make_dirs="/var/log/atop 755 root root"
 
 pre_install() {
-	vsed -e '/chown/d' \
-		-e 's/04711/0755/' \
-		-e 's,sbin,bin,g' \
+	vsed -e 's,sbin,bin,g' \
 		-e '/$(DEFPATH)/d' -i Makefile
 	vsed -e 's,bin/sh,bin/bash,' -i atop.daily
 }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: atop: Remove ineffective vsed
  2023-03-26 12:39 [PR PATCH] atop: Remove ineffective vsed gmbeard
@ 2023-03-26 12:46 ` gmbeard
  2023-03-26 12:47 ` gmbeard
  1 sibling, 0 replies; 3+ messages in thread
From: gmbeard @ 2023-03-26 12:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

There's a closed pull request on the void-packages repository

atop: Remove ineffective vsed
https://github.com/void-linux/void-packages/pull/43027

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

Addresses part of tracking issue #42441
- [x] atop

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86\_64-glibc
- I built this PR locally for these architectures:
  - i686
  - aarch64


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: atop: Remove ineffective vsed
  2023-03-26 12:39 [PR PATCH] atop: Remove ineffective vsed gmbeard
  2023-03-26 12:46 ` [PR PATCH] [Closed]: " gmbeard
@ 2023-03-26 12:47 ` gmbeard
  1 sibling, 0 replies; 3+ messages in thread
From: gmbeard @ 2023-03-26 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by gmbeard on void-packages repository

https://github.com/void-linux/void-packages/pull/43027#issuecomment-1484086554

Comment:
This has already been fixed in #42949. Closing

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-26 12:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-26 12:39 [PR PATCH] atop: Remove ineffective vsed gmbeard
2023-03-26 12:46 ` [PR PATCH] [Closed]: " gmbeard
2023-03-26 12:47 ` gmbeard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).