From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] citations: fix build
Date: Thu, 30 Mar 2023 20:28:41 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43119@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]
There is a new pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages citations-fix-build
https://github.com/void-linux/void-packages/pull/43119
citations: fix build
#### Testing the changes
- I tested the changes in this PR: **briefly**
Citations 0.5.1 has a specific commit hash for nom-bibtex in it's Cargo.lock, but nom-bibtex doesn't have that commit in it's master which causes cargo to fail. I solved it by updating the commit to an equivalent commit which is in master, but it has a different hash probably because it's based on nom-bibtex 0.4.0 instead of 0.3.0.
cc @A6GibKm I am not sure if you are aware of this
```
[24/27] Generating src/cargo-build with a custom command
Updating crates.io index
Updating git repository `https://github.com/A6GibKm/nom-bibtex.git`
error: failed to get `nom-bibtex` as a dependency of package `cratebibtex v0.1.0 (/builddir/citations-0.5.1/cratebibtex)`
... which satisfies path dependency `cratebibtex` (locked to 0.1.0) of package `citations v0.5.1 (/builddir/citations-0.5.1)`
Caused by:
failed to load source for dependency `nom-bibtex`
Caused by:
Unable to update https://github.com/A6GibKm/nom-bibtex.git#3e20b1f6
Caused by:
object not found - no match for id (3e20b1f6a1f8709bf61836f171b8d90cb84cd8b3); class=Odb (9); code=NotFound (-3)
[26/27] Generating data/org.gnome.World.Citations.metainfo.xml with a custom command
FAILED: src/citations
/usr/bin/env CARGO_HOME=/builddir/citations-0.5.1/build/cargo-home /usr/bin/cargo build --manifest-path /builddir/citations-0.5.1/Cargo.toml --target-dir /builddir/citations-0.5.1/build/src --release && cp src/release/citations src/citations
ninja: build stopped: subcommand failed.
```
A patch file from https://github.com/void-linux/void-packages/pull/43119.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-citations-fix-build-43119.patch --]
[-- Type: text/x-diff, Size: 842 bytes --]
From baff07a73e611ff4e6713ad65f43ea5d515a07d3 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Thu, 30 Mar 2023 20:20:23 +0200
Subject: [PATCH] citations: fix build
---
srcpkgs/citations/template | 2 ++
1 file changed, 2 insertions(+)
diff --git a/srcpkgs/citations/template b/srcpkgs/citations/template
index 5dbdc7c9fa62..bb82deae2c81 100644
--- a/srcpkgs/citations/template
+++ b/srcpkgs/citations/template
@@ -20,6 +20,8 @@ pre_build() {
if [ "${CROSS_BUILD}" ]; then
vsed -i build/build.ninja -e 's, && cp src/release/citations src/citations,,'
fi
+ # nom-bibtex was probably force pushed, the old git hash doesn't exist anymore
+ cargo update --package nom-bibtex --precise da0eda527c58e281acf41336512cc8627370cff9
}
# Take the cross-build folder into account when copying the file for the install
next reply other threads:[~2023-03-30 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 18:28 paper42 [this message]
2023-03-30 19:03 ` abenson
2023-03-30 19:16 ` A6GibKm
2023-03-30 20:19 ` paper42
2023-03-30 21:00 ` A6GibKm
2023-03-30 21:25 ` [PR PATCH] [Closed]: " paper42
2023-03-30 21:25 ` paper42
2023-04-04 12:15 ` A6GibKm
2023-04-04 12:16 ` A6GibKm
2023-04-04 12:16 ` A6GibKm
2023-04-04 17:45 ` paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43119@inbox.vuxu.org \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).