Github messages for voidlinux
 help / color / mirror / Atom feed
From: mhmdanas <mhmdanas@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] common/travis: make check-install use new rootdir.
Date: Thu, 06 Apr 2023 20:22:18 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43304@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages ci-install-to-new-rootdir
https://github.com/void-linux/void-packages/pull/43304

common/travis: make check-install use new rootdir.
The CI has `base-chroot` installed, but sometimes this script would try to install `base-system,` causing conflicts. This PR fixes that issue by using a brand-new rootdir.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

How should I test this?

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43304.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ci-install-to-new-rootdir-43304.patch --]
[-- Type: text/x-diff, Size: 1492 bytes --]

From ea99d9d518ec2c8ec08a11eacc59b792e5cb177c Mon Sep 17 00:00:00 2001
From: mhmdanas <triallax@tutanota.com>
Date: Thu, 6 Apr 2023 19:06:26 +0100
Subject: [PATCH] common/travis: make check-install use new rootdir.

The CI has `base-chroot` installed, but sometimes this script would try
to install `base-system,` causing conflicts. This commit fixes that
issue by using a brand-new rootdir.
---
 common/travis/check-install.sh | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/common/travis/check-install.sh b/common/travis/check-install.sh
index 943a6bc6211c..5ecea84e640b 100755
--- a/common/travis/check-install.sh
+++ b/common/travis/check-install.sh
@@ -4,22 +4,19 @@
 
 export XBPS_TARGET_ARCH="$2" XBPS_DISTDIR=/hostrepo
 
-if [ "$1" != "$XBPS_TARGET_ARCH" ]; then
-	triplet="$(/hostrepo/xbps-src -a "$XBPS_TARGET_ARCH" show-var XBPS_CROSS_TRIPLET)"
-	ROOTDIR="-r /usr/$triplet"
-fi
-
 ADDREPO="--repository=$HOME/hostdir/binpkgs/bootstrap
  --repository=$HOME/hostdir/binpkgs
  --repository=$HOME/hostdir/binpkgs/nonfree"
 
+mkdir /check-install
+
 while read -r pkg; do
 	for subpkg in $(xsubpkg $pkg); do
 		/bin/echo -e "\x1b[32mTrying to install dependants of $subpkg:\x1b[0m"
 		for dep in $(xbps-query $ADDREPO -RX "$subpkg"); do
 			xbps-install \
-				$ROOTDIR $ADDREPO \
-				-Sny \
+				$ADDREPO \
+				-Sny -r /check-install \
 				"$subpkg" "$(xbps-uhelper getpkgname "$dep")"
 			ret="$?"
 			if [ "$ret" -eq 8 ] || [ "$ret" -eq 11 ]; then

             reply	other threads:[~2023-04-06 18:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 18:22 mhmdanas [this message]
2023-04-06 18:25 ` classabbyamp
2023-04-06 18:25 ` classabbyamp
2023-04-06 18:45 ` [PR PATCH] [Updated] " mhmdanas
2023-04-06 19:02 ` mhmdanas
2023-04-06 19:36 ` mhmdanas
2023-04-06 22:59 ` [PR PATCH] [Updated] " mhmdanas
2023-04-06 23:13 ` mhmdanas
2023-04-06 23:20 ` mhmdanas
2023-04-06 23:30 ` mhmdanas
2023-04-07 15:28 ` mhmdanas
2023-04-07 15:35 ` mhmdanas
2023-04-11 20:16 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43304@inbox.vuxu.org \
    --to=mhmdanas@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).