From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] shutils/build_dependencies.sh: print "with" before build style/helper names
Date: Fri, 07 Apr 2023 14:01:05 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43320@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]
There is a new pull request by 0x5c against master on the void-packages repository
https://github.com/0x5c/void-packages fix/build-with-style
https://github.com/void-linux/void-packages/pull/43320
shutils/build_dependencies.sh: print "with" before build style/helper names
Messages like "building [rust] for <platform>" could lead to mild panic as they might be read as "building <large toolchain> on your laptop".
Simply adding "with" before the style/helpers should solve that.
It works for build_style, build_helper, both, and none.
```
=> ircdog-0.4.0_2: building with [go] for x86_64...
=> firefox-111.0.1_1: building with [rust] for x86_64...
=> riff-2.23.2_1: building with [cargo] [rust] for x86_64...
=> discord-0.0.26_1: building for x86_64...
```
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/43320.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/build-with-style-43320.patch --]
[-- Type: text/x-diff, Size: 1455 bytes --]
From d9f67d4f9158dd8fc79bd80c40667c5a176c7906 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Fri, 7 Apr 2023 07:40:04 -0400
Subject: [PATCH] shutils/build_dependencies.sh: print "with" before build
style/helper names
Messages like "building [rust] for <platform>" could lead to mild panic as they
might be read as "building <large toolchain> on your laptop".
Simply adding "with" before the style/helpers should solve that.
It works for build_style, build_helper, both, and none.
=> ircdog-0.4.0_2: building with [go] for x86_64...
=> firefox-111.0.1_1: building with [rust] for x86_64...
=> riff-2.23.2_1: building with [cargo] [rust] for x86_64...
=> discord-0.0.26_1: building for x86_64...
---
common/xbps-src/shutils/build_dependencies.sh | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 1d19de54ae80..20f61528d14c 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -138,7 +138,12 @@ install_pkg_deps() {
[ -z "$pkgname" ] && return 2
[ -z "$XBPS_CHECK_PKGS" ] && unset checkdepends
- [[ $build_style ]] && style=" [$build_style]"
+
+ if [[ $build_style ]] || [[ $build_helper ]]; then
+ style=" with"
+ fi
+
+ [[ $build_style ]] && style+=" [$build_style]"
for s in $build_helper; do
style+=" [$s]"
next reply other threads:[~2023-04-07 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 12:01 0x5c [this message]
2023-04-13 3:49 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43320@inbox.vuxu.org \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).