Github messages for voidlinux
 help / color / mirror / Atom feed
From: z411 <z411@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Backport pipewire segfault fix for Mumble 1.4.x
Date: Fri, 05 May 2023 09:19:40 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43756@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is a new pull request by z411 against master on the void-packages repository

https://github.com/z411/void-packages mumble-fix
https://github.com/void-linux/void-packages/pull/43756

Backport pipewire segfault fix for Mumble 1.4.x
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Description
Currently due to a libpipewire change the Mumble client segfaults when trying to change any setting. This backported patch fixes the issue (small change).

#### Testing the changes
- I tested the changes in this PR: YES

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_68-glibc


A patch file from https://github.com/void-linux/void-packages/pull/43756.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mumble-fix-43756.patch --]
[-- Type: text/x-diff, Size: 1524 bytes --]

From 33d493f785b82e73f92754e3970bc8fd728de6ce Mon Sep 17 00:00:00 2001
From: z411 <z411@omaera.org>
Date: Fri, 5 May 2023 03:13:27 -0400
Subject: [PATCH] Backport pipewire segfault fix for Mumble 1.4.x

---
 srcpkgs/mumble/patches/pipewire-fix.patch | 22 ++++++++++++++++++++++
 srcpkgs/mumble/template                   |  2 +-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/mumble/patches/pipewire-fix.patch

diff --git a/srcpkgs/mumble/patches/pipewire-fix.patch b/srcpkgs/mumble/patches/pipewire-fix.patch
new file mode 100644
index 000000000000..bcc2f11fe8e3
--- /dev/null
+++ b/srcpkgs/mumble/patches/pipewire-fix.patch
@@ -0,0 +1,22 @@
+diff --git a/src/mumble/PipeWire.cpp b/src/mumble/PipeWire.cpp
+index 91924e4fb..c206ab5bb 100644
+--- a/src/mumble/PipeWire.cpp
++++ b/src/mumble/PipeWire.cpp
+@@ -213,13 +213,14 @@ PipeWireEngine::~PipeWireEngine() {
+ 		return;
+ 	}
+ 
++	if (m_stream) {
++		pws->pw_stream_destroy(m_stream);
++	}
++
+ 	if (m_thread) {
+ 		pws->pw_thread_loop_destroy(m_thread);
+ 	}
+ 
+-	if (m_stream) {
+-		pws->pw_stream_destroy(m_stream);
+-	}
+ 
+ 	if (m_loop) {
+ 		pws->pw_loop_destroy(m_loop);
diff --git a/srcpkgs/mumble/template b/srcpkgs/mumble/template
index acb6af454e0f..35c2728c74ce 100644
--- a/srcpkgs/mumble/template
+++ b/srcpkgs/mumble/template
@@ -1,7 +1,7 @@
 # Template file for 'mumble'
 pkgname=mumble
 version=1.4.287
-revision=2
+revision=3
 build_style=cmake
 make_cmd=make
 configure_args="-Doverlay-xcompile=OFF -Dbundled-opus=OFF

             reply	other threads:[~2023-05-05  7:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  7:19 z411 [this message]
2023-05-05  7:22 ` [PR REVIEW] " classabbyamp
2023-05-05  7:23 ` z411
2023-05-05  7:37 ` [PR PATCH] [Updated] mumble: backport fix for segfault with pipewire z411
2023-05-05  7:37 ` [PR REVIEW] " z411
2023-05-05  7:37 ` z411
2023-05-05 21:01 ` z411
2023-05-06 14:09 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43756@inbox.vuxu.org \
    --to=z411@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).