From: the-eater <the-eater@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] mtr: fix libcap dependency not linking
Date: Tue, 16 May 2023 10:10:54 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43897@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
There is a new pull request by the-eater against master on the void-packages repository
https://github.com/the-eater/neo-void-packages pkg/mtr/fix-cap
https://github.com/void-linux/void-packages/pull/43897
mtr: fix libcap dependency not linking
#### Testing the changes
- I tested the changes in this PR: **briefly**
A patch file from https://github.com/void-linux/void-packages/pull/43897.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/mtr/fix-cap-43897.patch --]
[-- Type: text/x-diff, Size: 1930 bytes --]
From c3775617e64a542a897d93be9de02fc00993a10e Mon Sep 17 00:00:00 2001
From: eater <=@eater.me>
Date: Tue, 16 May 2023 10:03:39 +0200
Subject: [PATCH] mtr: fix libcap dependency not linking
---
srcpkgs/mtr/patches/libcap-fix.patch | 25 +++++++++++++++++++++++++
srcpkgs/mtr/template | 2 +-
2 files changed, 26 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/mtr/patches/libcap-fix.patch
diff --git a/srcpkgs/mtr/patches/libcap-fix.patch b/srcpkgs/mtr/patches/libcap-fix.patch
new file mode 100644
index 000000000000..e564f38e409e
--- /dev/null
+++ b/srcpkgs/mtr/patches/libcap-fix.patch
@@ -0,0 +1,25 @@
+Upstream fix: https://github.com/traviscross/mtr/pull/472
+
+Makes sure `libcap` gets linked and dropping of capabilities is enabled:w
+
+diff --git a/configure.ac b/configure.ac
+index 3175d56b..286ede60 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -127,9 +127,13 @@ AS_IF([test "x$with_ncurses" = "xyes"],
+ ])
+ AM_CONDITIONAL([WITH_CURSES], [test "x$with_ncurses" = xyes])
+
+-AC_CHECK_LIB([cap], [cap_set_proc], [have_cap="yes"],
+- AS_IF([test "$host_os" = linux-gnu],
+- AC_MSG_WARN([Capabilities support is strongly recommended for increased security. See SECURITY for more information.])))
++have_cap="yes"
++AC_CHECK_LIB([cap], [cap_set_proc], [], [
++ have_cap="no"
++ AS_IF([test "$host_os" = linux-gnu], [
++ AC_MSG_WARN([Capabilities support is strongly recommended for increased security. See SECURITY for more information.])
++ ])
++])
+
+ # Enable ipinfo
+ AC_ARG_WITH([ipinfo],
diff --git a/srcpkgs/mtr/template b/srcpkgs/mtr/template
index 5f159dfc025b..3bb62dbe3cc0 100644
--- a/srcpkgs/mtr/template
+++ b/srcpkgs/mtr/template
@@ -1,7 +1,7 @@
# Template file for 'mtr'
pkgname=mtr
version=0.95
-revision=1
+revision=2
build_style="gnu-configure"
hostmakedepends="automake pkg-config gtk+3-devel"
makedepends="ncurses-devel gtk+3-devel libcap-devel"
next reply other threads:[~2023-05-16 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 8:10 the-eater [this message]
2023-05-16 16:03 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43897@inbox.vuxu.org \
--to=the-eater@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).