From: ifreund <ifreund@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] zig: target baseline cpu
Date: Tue, 16 May 2023 14:09:13 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43900@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
There is a new pull request by ifreund against master on the void-packages repository
https://github.com/ifreund/void-packages zig-mcpu-fix
https://github.com/void-linux/void-packages/pull/43900
zig: target baseline cpu
Since zig 0.10.1 the cmake build system will produce a binary with the equivalent of -march=native by default. To produce a binary portable across cpu versions we must target the baseline cpu.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/43900.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zig-mcpu-fix-43900.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]
From ecc0b8edd9b5b5e337afd680a8f8631f9cb0bfae Mon Sep 17 00:00:00 2001
From: Isaac Freund <mail@isaacfreund.com>
Date: Tue, 16 May 2023 14:01:45 +0200
Subject: [PATCH] zig: target baseline cpu
Since zig 0.10.1 the cmake build system will produce a binary with the
equivalent of -march=native by default. To produce a binary portable
across cpu versions we must target the baseline cpu.
---
srcpkgs/zig/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/zig/template b/srcpkgs/zig/template
index 9807f7ab206b..55b31e5573c4 100644
--- a/srcpkgs/zig/template
+++ b/srcpkgs/zig/template
@@ -1,9 +1,10 @@
# Template file for 'zig'
pkgname=zig
version=0.10.1
-revision=1
+revision=2
archs="x86_64* aarch64*"
build_style=cmake
+configure_args="-DZIG_TARGET_MCPU=baseline"
make_cmd=make
# we add xml2, zstd, zlib and ncurses
# because our lld is static-only and requires those to work
next reply other threads:[~2023-05-16 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 12:09 ifreund [this message]
2023-05-16 13:48 ` [PR PATCH] [Merged]: " abenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43900@inbox.vuxu.org \
--to=ifreund@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).