From: Zapeth <Zapeth@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] imhex: use gtk file picker by default
Date: Sat, 15 Jul 2023 16:43:35 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45054@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
There is a new pull request by Zapeth against master on the void-packages repository
https://github.com/Zapeth/void-packages imhex-fix-filepicker
https://github.com/void-linux/void-packages/pull/45054
imhex: use gtk file picker by default
Some xdg-desktop-portal environments dont support a file picker (eg wlroots based ones), so use gtk file picker by default.
See also https://github.com/WerWolv/ImHex/issues/882#issuecomment-1382268291
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO**
A patch file from https://github.com/void-linux/void-packages/pull/45054.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-imhex-fix-filepicker-45054.patch --]
[-- Type: text/x-diff, Size: 1422 bytes --]
From a33cb5854a1feedf0bb1963d3c669d5df7bf9ed5 Mon Sep 17 00:00:00 2001
From: Zapeth <Zapeth@users.noreply.github.com>
Date: Sat, 15 Jul 2023 14:31:04 +0000
Subject: [PATCH] imhex: use gtk file picker by default
Some xdg-desktop-portal environments dont support a file picker (eg wlroots based ones), so use gtk file picker by default.
See also https://github.com/WerWolv/ImHex/issues/882#issuecomment-1382268291
---
srcpkgs/imhex/template | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/imhex/template b/srcpkgs/imhex/template
index 3f7f4750389e..d25585caf271 100644
--- a/srcpkgs/imhex/template
+++ b/srcpkgs/imhex/template
@@ -1,14 +1,15 @@
# Template file for 'imhex'
pkgname=imhex
version=1.30.1
-revision=1
+revision=2
build_wrksrc="ImHex"
build_style=cmake
build_helper=qemu
# XXX: when capstone v5 is out, -DUSE_SYSTEM_CAPSTONE=ON
configure_args="-DIMHEX_OFFLINE_BUILD=ON -DIMHEX_STRIP_RELEASE=OFF
-DUSE_SYSTEM_CURL=ON -DUSE_SYSTEM_FMT=ON -DUSE_SYSTEM_LLVM=ON
- -DUSE_SYSTEM_YARA=ON -DUSE_SYSTEM_NLOHMANN_JSON=ON -DIMHEX_DISABLE_UPDATE_CHECK=ON"
+ -DUSE_SYSTEM_YARA=ON -DUSE_SYSTEM_NLOHMANN_JSON=ON -DIMHEX_DISABLE_UPDATE_CHECK=ON
+ -DIMHEX_USE_GTK_FILE_PICKER=ON"
hostmakedepends="pkg-config clang-tools-extra"
makedepends="libcurl-devel fmt-devel llvm jansson-devel yara-devel json-c++
freetype-devel glfw-devel gtk+3-devel python3-devel file-devel mbedtls-devel
next reply other threads:[~2023-07-15 14:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-15 14:43 Zapeth [this message]
2023-07-15 21:09 ` classabbyamp
2023-07-15 23:00 ` Zapeth
2023-07-17 4:26 ` classabbyamp
2023-07-17 5:35 ` classabbyamp
2023-07-17 5:36 ` classabbyamp
2023-07-17 6:38 ` classabbyamp
2023-07-17 6:38 ` [PR PATCH] [Closed]: " classabbyamp
2023-07-17 20:28 ` Zapeth
2023-07-17 20:28 ` Zapeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45054@inbox.vuxu.org \
--to=zapeth@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).