Github messages for voidlinux
 help / color / mirror / Atom feed
From: Duncaen <Duncaen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] xbps-src: add default build option description
Date: Sun, 13 Aug 2023 17:01:57 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45580@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

There is a new pull request by Duncaen against master on the void-packages repository

https://github.com/Duncaen/void-packages default-buildopt-description
https://github.com/void-linux/void-packages/pull/45580

xbps-src: add default build option description
Most descriptions already just use this format anyways.

[ci skip]


A patch file from https://github.com/void-linux/void-packages/pull/45580.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-default-buildopt-description-45580.patch --]
[-- Type: text/x-diff, Size: 1174 bytes --]

From a075bbec7a220ae7441e86d019b7bb77e60d7495 Mon Sep 17 00:00:00 2001
From: Duncaen <duncaen@voidlinux.org>
Date: Sun, 13 Aug 2023 16:59:46 +0200
Subject: [PATCH] xbps-src: add default build option description

Most descriptions already just use this format anyways.
---
 common/xbps-src/shutils/show.sh | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/xbps-src/shutils/show.sh b/common/xbps-src/shutils/show.sh
index 6ae0f4e6d7df2..606396d2b4b1a 100644
--- a/common/xbps-src/shutils/show.sh
+++ b/common/xbps-src/shutils/show.sh
@@ -129,15 +129,16 @@ show_pkg_makedepends() {
 }
 
 show_pkg_build_options() {
-    local f opt desc
+    local f
 
     [ -z "$PKG_BUILD_OPTIONS" ] && return 0
 
     source $XBPS_COMMONDIR/options.description
     msg_normal "$pkgver: the following build options are set:\n"
     for f in ${PKG_BUILD_OPTIONS}; do
-        opt="${f#\~}"
-        eval desc="\${desc_option_${opt}}"
+        local opt="${f#\~}"
+        local descref="desc_option_${opt}"
+        local desc="${!descref-Enable support for $opt}"
         if [[ ${f:0:1} == '~' ]]; then
             echo "   $opt: $desc (OFF)"
         else

             reply	other threads:[~2023-08-13 15:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-13 15:01 Duncaen [this message]
2023-08-13 15:09 ` [PR REVIEW] " classabbyamp
2023-08-13 15:43 ` Duncaen
2023-08-13 15:44 ` classabbyamp
2023-08-13 15:45 ` classabbyamp
2023-11-12  1:47 ` github-actions
2023-11-13  0:36 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45580@inbox.vuxu.org \
    --to=duncaen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).