Github messages for voidlinux
 help / color / mirror / Atom feed
From: Bnyro <Bnyro@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Manual.md: make section concerning quoting version and pkgname clearer
Date: Mon, 14 Aug 2023 13:39:31 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45603@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages dont-quote-pkgname-and-version
https://github.com/void-linux/void-packages/pull/45603

Manual.md: make section concerning quoting version and pkgname clearer
The current description might be a bit difficult to understand for new contributors due to some grammatical things that could result in it to be understood in the wrong way.

`[...] which make it necessary to quote them` somewhat could be interpreted that you actually should quote them.
The rest are just minor grammar changes.

A patch file from https://github.com/void-linux/void-packages/pull/45603.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dont-quote-pkgname-and-version-45603.patch --]
[-- Type: text/x-diff, Size: 1052 bytes --]

From 733879600207983af8a285874ca0670ed245d072 Mon Sep 17 00:00:00 2001
From: Bnyro <82752168+Bnyro@users.noreply.github.com>
Date: Mon, 14 Aug 2023 13:33:29 +0200
Subject: [PATCH] Manual.md: make section concerning quoting version and
 pkgname clearer

---
 Manual.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Manual.md b/Manual.md
index 5a183e6c3d183..b3deacc6d344e 100644
--- a/Manual.md
+++ b/Manual.md
@@ -441,8 +441,8 @@ the generated `binary packages` have been modified.
 - `version` A string with the package version. Must not contain dashes or underscore
 and at least one digit is required. Shell's variable substitution usage is not allowed.
 
-Neither `pkgname` or `version` should contain special characters which make it
-necessary to quote them, so they shouldn't be quoted in the template.
+Neither `pkgname` nor `version` should contain special characters that would make it
+necessary to quote them, hence they should not be quoted in the template.
 
 <a id="optional_vars"></a>
 #### Optional variables

             reply	other threads:[~2023-08-14 11:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 11:39 Bnyro [this message]
2023-08-16 18:58 ` Chocimier
2023-08-19 17:53 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45603@inbox.vuxu.org \
    --to=bnyro@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).