* Re: [PR REVIEW] sunwait: revert 0.20041208_2
2023-09-10 19:54 [PR PATCH] sunwait: revert 0.20041208_2 Calandracas606
@ 2023-09-10 19:55 ` classabbyamp
2023-09-10 19:56 ` [PR PATCH] [Updated] " Calandracas606
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-09-10 19:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/46007#discussion_r1320852418
Comment:
should be added not replaced
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] sunwait: revert 0.20041208_2
2023-09-10 19:54 [PR PATCH] sunwait: revert 0.20041208_2 Calandracas606
2023-09-10 19:55 ` [PR REVIEW] " classabbyamp
@ 2023-09-10 19:56 ` Calandracas606
2023-09-10 19:57 ` [PR REVIEW] " Calandracas606
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Calandracas606 @ 2023-09-10 19:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
There is an updated pull request by Calandracas606 against master on the void-packages repository
https://github.com/Calandracas606/void-packages sunwait-revert-0.20041208_2
https://github.com/void-linux/void-packages/pull/46007
sunwait: revert 0.20041208_2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc, aarch64-musl
A patch file from https://github.com/void-linux/void-packages/pull/46007.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sunwait-revert-0.20041208_2-46007.patch --]
[-- Type: text/x-diff, Size: 721 bytes --]
From c204b8b681d81842c951593d992f434a5b094c8f Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielpedromartinez@duck.com>
Date: Sun, 10 Sep 2023 15:49:19 -0400
Subject: [PATCH] sunwait: revert 0.20041208_2
---
srcpkgs/sunwait/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/sunwait/template b/srcpkgs/sunwait/template
index 162a3da535fc4..42e034363c63f 100644
--- a/srcpkgs/sunwait/template
+++ b/srcpkgs/sunwait/template
@@ -1,8 +1,9 @@
# Template file for 'sunwait'
pkgname=sunwait
reverts="0.20041208_1"
+reverts="0.20041208_2"
version=0.9.1
-revision=1
+revision=2
build_style=gnu-makefile
make_use_env=yes
short_desc="Small C program calculating sunrise and sunset"
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] sunwait: revert 0.20041208_2
2023-09-10 19:54 [PR PATCH] sunwait: revert 0.20041208_2 Calandracas606
2023-09-10 19:55 ` [PR REVIEW] " classabbyamp
2023-09-10 19:56 ` [PR PATCH] [Updated] " Calandracas606
@ 2023-09-10 19:57 ` Calandracas606
2023-09-10 19:57 ` classabbyamp
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Calandracas606 @ 2023-09-10 19:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
New review comment by Calandracas606 on void-packages repository
https://github.com/void-linux/void-packages/pull/46007#discussion_r1320852610
Comment:
fixed
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR REVIEW] sunwait: revert 0.20041208_2
2023-09-10 19:54 [PR PATCH] sunwait: revert 0.20041208_2 Calandracas606
` (2 preceding siblings ...)
2023-09-10 19:57 ` [PR REVIEW] " Calandracas606
@ 2023-09-10 19:57 ` classabbyamp
2023-09-10 19:59 ` [PR PATCH] [Updated] " Calandracas606
2023-09-10 20:02 ` [PR PATCH] [Merged]: " classabbyamp
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-09-10 19:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/46007#discussion_r1320852676
Comment:
in the same variable, space separated: `reverts="0.20041208_1 0.20041208_2"`
having 2 lines would just overwrite the first with the second
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Updated] sunwait: revert 0.20041208_2
2023-09-10 19:54 [PR PATCH] sunwait: revert 0.20041208_2 Calandracas606
` (3 preceding siblings ...)
2023-09-10 19:57 ` classabbyamp
@ 2023-09-10 19:59 ` Calandracas606
2023-09-10 20:02 ` [PR PATCH] [Merged]: " classabbyamp
5 siblings, 0 replies; 7+ messages in thread
From: Calandracas606 @ 2023-09-10 19:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
There is an updated pull request by Calandracas606 against master on the void-packages repository
https://github.com/Calandracas606/void-packages sunwait-revert-0.20041208_2
https://github.com/void-linux/void-packages/pull/46007
sunwait: revert 0.20041208_2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc, aarch64-musl
A patch file from https://github.com/void-linux/void-packages/pull/46007.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sunwait-revert-0.20041208_2-46007.patch --]
[-- Type: text/x-diff, Size: 736 bytes --]
From e0dc8dc4eda9d505d6cfd5646679e002f21067e8 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielpedromartinez@duck.com>
Date: Sun, 10 Sep 2023 15:49:19 -0400
Subject: [PATCH] sunwait: revert 0.20041208_2
---
srcpkgs/sunwait/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/sunwait/template b/srcpkgs/sunwait/template
index 162a3da535fc4..9dbec63b569c0 100644
--- a/srcpkgs/sunwait/template
+++ b/srcpkgs/sunwait/template
@@ -1,8 +1,8 @@
# Template file for 'sunwait'
pkgname=sunwait
-reverts="0.20041208_1"
+reverts="0.20041208_1 0.20041208_2"
version=0.9.1
-revision=1
+revision=2
build_style=gnu-makefile
make_use_env=yes
short_desc="Small C program calculating sunrise and sunset"
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PR PATCH] [Merged]: sunwait: revert 0.20041208_2
2023-09-10 19:54 [PR PATCH] sunwait: revert 0.20041208_2 Calandracas606
` (4 preceding siblings ...)
2023-09-10 19:59 ` [PR PATCH] [Updated] " Calandracas606
@ 2023-09-10 20:02 ` classabbyamp
5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-09-10 20:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
There's a merged pull request on the void-packages repository
sunwait: revert 0.20041208_2
https://github.com/void-linux/void-packages/pull/46007
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc, aarch64-musl
^ permalink raw reply [flat|nested] 7+ messages in thread