From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] SDL2: fix sigill on some i686
Date: Sat, 16 Sep 2023 16:07:23 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46084@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
There is a new pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages sdl2-sse3
https://github.com/void-linux/void-packages/pull/46084
SDL2: fix sigill on some i686
@devlocalhost please test
fixes #44829
#### Testing the changes
- I tested the changes in this PR: **NO** (but `-msse3` is no longer added to `EXTRA_CFLAGS` on i686)
A patch file from https://github.com/void-linux/void-packages/pull/46084.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sdl2-sse3-46084.patch --]
[-- Type: text/x-diff, Size: 1157 bytes --]
From c73e2dc84d5560237437f14daf1c17e0fb47bb8a Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Sat, 16 Sep 2023 10:05:45 -0400
Subject: [PATCH] SDL2: fix sigill on some i686
fixes #44829
---
srcpkgs/SDL2/template | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/SDL2/template b/srcpkgs/SDL2/template
index db2413108c23d..397ec7f1f61f1 100644
--- a/srcpkgs/SDL2/template
+++ b/srcpkgs/SDL2/template
@@ -1,7 +1,7 @@
# Template file for 'SDL2'
pkgname=SDL2
version=2.28.2
-revision=1
+revision=2
build_style=cmake
configure_args="-DSDL_ALSA=ON -DSDL_ESD=OFF -DSDL_RPATH=OFF
-DSDL_CLOCK_GETTIME=ON -DSDL_PULSEAUDIO_SHARED=OFF
@@ -32,9 +32,11 @@ case "$XBPS_TARGET_MACHINE" in
*) build_options_default+=" pipewire";;
esac
-# SDL_cpuinfo includes altivec.h, which breaks C++ programs with vector keyword
case "$XBPS_TARGET_MACHINE" in
+ # SDL_cpuinfo includes altivec.h, which breaks C++ programs with vector keyword
ppc*) configure_args+=" -DSDL_ALTIVEC=OFF";;
+ # SDL detects SSE3 on i686, which is above our support target
+ i686*) configure_args+=" -DSDL_SSE3=OFF";;
*) ;;
esac
next reply other threads:[~2023-09-16 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 14:07 classabbyamp [this message]
2023-09-16 14:57 ` devlocalhost
2023-09-16 15:00 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46084@inbox.vuxu.org \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).