* Re: [PR REVIEW] wrappers/cross-cc: drop -isystem /usr/include, too
2023-10-12 12:43 [PR PATCH] wrappers/cross-cc: drop -isystem /usr/include, too sgn
@ 2023-10-12 12:57 ` Johnnynator
2023-10-13 4:51 ` [PR PATCH] [Updated] " sgn
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Johnnynator @ 2023-10-12 12:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/46635#discussion_r1356775577
Comment:
This changes all `-isystem` to `-I`, which changes the search order that might be used for headers.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] wrappers/cross-cc: drop -isystem /usr/include, too
2023-10-12 12:43 [PR PATCH] wrappers/cross-cc: drop -isystem /usr/include, too sgn
2023-10-12 12:57 ` [PR REVIEW] " Johnnynator
@ 2023-10-13 4:51 ` sgn
2023-10-13 5:41 ` SpidFightFR
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2023-10-13 4:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
There is an updated pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages cross-cc-isystem
https://github.com/void-linux/void-packages/pull/46635
wrappers/cross-cc: drop -isystem /usr/include, too
<!-- Uncomment relevant sections and delete options which are not applicable -->
For #46246
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/46635.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cross-cc-isystem-46635.patch --]
[-- Type: text/x-diff, Size: 1538 bytes --]
From efc4b2d61a1b41fce27f667ac31042a092ac36ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Thu, 12 Oct 2023 19:42:10 +0700
Subject: [PATCH] wrappers/cross-cc: drop -isystem /usr/include, too
---
common/wrappers/cross-cc | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/common/wrappers/cross-cc b/common/wrappers/cross-cc
index 0e08bc91d0fc2..ab5e01ad5655a 100644
--- a/common/wrappers/cross-cc
+++ b/common/wrappers/cross-cc
@@ -8,11 +8,11 @@ ARGS=("$@")
i=0
while [ $i -lt ${#ARGS[@]} ]; do
arg="${ARGS[$i]}"
- if [ "$incpath" ]; then
+ if [ -n "$incpath" ]; then
if [ "$arg" = "/usr/include" ]; then
- echo "[cc-wrapper] ignoring -I $arg"
+ echo "[cc-wrapper] ignoring ${incpath} $arg"
else
- MYARGS+=("-I${arg}")
+ MYARGS+=("${incpath}${arg}")
fi
unset incpath
elif [ "$libpath" ]; then
@@ -23,13 +23,13 @@ while [ $i -lt ${#ARGS[@]} ]; do
MYARGS+=("-L${arg}")
fi
unset libpath
- elif [ "$arg" = "-I" ]; then
- incpath=1
+ elif [ "$arg" = "-I" -o "$arg" = "-isystem" ]; then
+ incpath="$arg"
elif [ "$arg" = "-L" ]; then
libpath=1
- elif [ "$arg" = "-I/usr/include" -o "$arg" = "-L/usr/lib" \
+ elif [ "$arg" = "-I/usr/include" -o "$arg" = "-isystem/usr/include" \
-o "$arg" = "-L/usr/lib32" -o "$arg" = "-L/usr/lib64" \
- -o "$arg" = "-L/lib" ]; then
+ -o "$arg" = "-L/usr/lib" -o "$arg" = "-L/lib" ]; then
echo "[cc-wrapper] ignoring $arg"
else
MYARGS+=("${arg}")
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: wrappers/cross-cc: drop -isystem /usr/include, too
2023-10-12 12:43 [PR PATCH] wrappers/cross-cc: drop -isystem /usr/include, too sgn
2023-10-12 12:57 ` [PR REVIEW] " Johnnynator
2023-10-13 4:51 ` [PR PATCH] [Updated] " sgn
@ 2023-10-13 5:41 ` SpidFightFR
2023-10-13 16:03 ` classabbyamp
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: SpidFightFR @ 2023-10-13 5:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New comment by SpidFightFR on void-packages repository
https://github.com/void-linux/void-packages/pull/46635#issuecomment-1760904851
Comment:
+up (to enable notifications 😅)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: wrappers/cross-cc: drop -isystem /usr/include, too
2023-10-12 12:43 [PR PATCH] wrappers/cross-cc: drop -isystem /usr/include, too sgn
` (2 preceding siblings ...)
2023-10-13 5:41 ` SpidFightFR
@ 2023-10-13 16:03 ` classabbyamp
2023-10-13 16:51 ` SpidFightFR
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-10-13 16:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/46635#issuecomment-1761754723
Comment:
> +up (to enable notifications 😅)
there's a subscibe button in the sidebar
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: wrappers/cross-cc: drop -isystem /usr/include, too
2023-10-12 12:43 [PR PATCH] wrappers/cross-cc: drop -isystem /usr/include, too sgn
` (3 preceding siblings ...)
2023-10-13 16:03 ` classabbyamp
@ 2023-10-13 16:51 ` SpidFightFR
2023-10-13 16:55 ` classabbyamp
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: SpidFightFR @ 2023-10-13 16:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New comment by SpidFightFR on void-packages repository
https://github.com/void-linux/void-packages/pull/46635#issuecomment-1761816711
Comment:
Oh... :sweat_smile:
thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: wrappers/cross-cc: drop -isystem /usr/include, too
2023-10-12 12:43 [PR PATCH] wrappers/cross-cc: drop -isystem /usr/include, too sgn
` (4 preceding siblings ...)
2023-10-13 16:51 ` SpidFightFR
@ 2023-10-13 16:55 ` classabbyamp
2023-10-13 16:55 ` classabbyamp
2023-10-14 5:39 ` [PR PATCH] [Merged]: " sgn
7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-10-13 16:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New comment by SpidFightFR on void-packages repository
https://github.com/void-linux/void-packages/pull/46635#issuecomment-1760904851
Comment:
+up (to enable notifications 😅)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: wrappers/cross-cc: drop -isystem /usr/include, too
2023-10-12 12:43 [PR PATCH] wrappers/cross-cc: drop -isystem /usr/include, too sgn
` (5 preceding siblings ...)
2023-10-13 16:55 ` classabbyamp
@ 2023-10-13 16:55 ` classabbyamp
2023-10-14 5:39 ` [PR PATCH] [Merged]: " sgn
7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-10-13 16:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/46635#issuecomment-1761754723
Comment:
> +up (to enable notifications 😅)
there's a subscibe button in the sidebar
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: wrappers/cross-cc: drop -isystem /usr/include, too
2023-10-12 12:43 [PR PATCH] wrappers/cross-cc: drop -isystem /usr/include, too sgn
` (6 preceding siblings ...)
2023-10-13 16:55 ` classabbyamp
@ 2023-10-14 5:39 ` sgn
7 siblings, 0 replies; 9+ messages in thread
From: sgn @ 2023-10-14 5:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
There's a merged pull request on the void-packages repository
wrappers/cross-cc: drop -isystem /usr/include, too
https://github.com/void-linux/void-packages/pull/46635
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
For #46246
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 9+ messages in thread