From: hrzlgnm <hrzlgnm@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] guake: backport fix for double click opens new tab from 3.8.5
Date: Sun, 05 Nov 2023 15:00:53 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47072@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
There is a new pull request by hrzlgnm against master on the void-packages repository
https://github.com/hrzlgnm/void-packages guake-double-click-fix-backport
https://github.com/void-linux/void-packages/pull/47072
guake: backport fix for double click opens new tab from 3.8.5
The issue has been fixed in upstream with 3.8.5
See upstream changes for more details :
* https://github.com/Guake/guake/pull/1721/files
* https://github.com/Guake/guake/pull/2010/files
#### Testing the changes
- I tested the changes in this PR: YES
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-libc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
A patch file from https://github.com/void-linux/void-packages/pull/47072.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-guake-double-click-fix-backport-47072.patch --]
[-- Type: text/x-diff, Size: 2470 bytes --]
From a0696b2d92ec5e92a44dd2f599a67a4324fb71d0 Mon Sep 17 00:00:00 2001
From: hrzlgnm <hrzlgnm@users.noreply.github.com>
Date: Sun, 5 Nov 2023 14:32:14 +0100
Subject: [PATCH] guake: backport fix for double click opens new tab from 3.8.5
The issue has been fixed in upstream with 3.8.5
See upstream changes for more details :
* https://github.com/Guake/guake/pull/1721/files
* https://github.com/Guake/guake/pull/2010/files
---
.../0001-Fix-double-click-opens-new-tab.patch | 30 +++++++++++++++++++
srcpkgs/guake/template | 2 +-
2 files changed, 31 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/guake/patches/0001-Fix-double-click-opens-new-tab.patch
diff --git a/srcpkgs/guake/patches/0001-Fix-double-click-opens-new-tab.patch b/srcpkgs/guake/patches/0001-Fix-double-click-opens-new-tab.patch
new file mode 100644
index 0000000000000..cab2d2e346acd
--- /dev/null
+++ b/srcpkgs/guake/patches/0001-Fix-double-click-opens-new-tab.patch
@@ -0,0 +1,30 @@
+From 9e6cd487b5acc66c4a7d36df4bb1e202f93990a0 Mon Sep 17 00:00:00 2001
+From: hrzlgnm <hrzlgnm@users.noreply.github.com>
+Date: Sun, 5 Nov 2023 14:37:31 +0100
+Subject: [PATCH] Fix double click opens new tab
+
+---
+ guake/notebook.py | 7 ++++++-
+ 1 file changed, 6 insertions(+), 1 deletion(-)
+
+diff --git a/guake/notebook.py b/guake/notebook.py
+index eb1fd5e..447588f 100644
+--- a/guake/notebook.py
++++ b/guake/notebook.py
+@@ -115,7 +115,12 @@ class TerminalNotebook(Gtk.Notebook):
+ # Gtk 3.18 fallback ("'Menu' object has no attribute 'popup_at_pointer'")
+ menu.popup(None, None, None, None, event.button, event.time)
+
+- elif event.type == Gdk.EventType.DOUBLE_BUTTON_PRESS and event.button == 1:
++ elif (
++ event.type == Gdk.EventType.DOUBLE_BUTTON_PRESS
++ and event.button == 1
++ and event.window.get_height() < 60
++ ):
++ # event.window.get_height() reports the height of the clicked frame
+ self.new_page_with_focus()
+
+ return False
+--
+2.42.0
+
diff --git a/srcpkgs/guake/template b/srcpkgs/guake/template
index 53a6a2c5ff45e..86fdbcc1218fb 100644
--- a/srcpkgs/guake/template
+++ b/srcpkgs/guake/template
@@ -1,7 +1,7 @@
# Template file for 'guake'
pkgname=guake
version=3.7.0
-revision=4
+revision=5
build_style=python3-module
hostmakedepends="gettext python3-setuptools python3-pbr"
makedepends="python3-devel python3-pbr"
next reply other threads:[~2023-11-05 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 14:00 hrzlgnm [this message]
2023-11-05 14:11 ` hrzlgnm
2023-11-05 15:20 ` [PR PATCH] [Closed]: " hrzlgnm
2023-11-05 15:45 ` hrzlgnm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47072@inbox.vuxu.org \
--to=hrzlgnm@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).