Github messages for voidlinux
 help / color / mirror / Atom feed
From: TakodaNotDakota <TakodaNotDakota@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] Add libedit option
Date: Sun, 26 Nov 2023 02:11:40 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47408@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 700 bytes --]

There is a new pull request by TakodaNotDakota against master on the void-packages repository

https://github.com/TakodaNotDakota/void-packages dash
https://github.com/void-linux/void-packages/pull/47408

Add libedit option
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-musl

This change allows dash to be compiled with libedit support, which gives it vi-like and emacs-like line editing.
This change DOES NOT set it to compile with that automatically, it only adds the xbps-src build option.

A patch file from https://github.com/void-linux/void-packages/pull/47408.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dash-47408.patch --]
[-- Type: text/x-diff, Size: 1058 bytes --]

From b748c685ee9172a58ab675def9f1aabc949d3e21 Mon Sep 17 00:00:00 2001
From: Takoda <150498532+TakodaNotDakota@users.noreply.github.com>
Date: Sat, 25 Nov 2023 19:07:19 -0600
Subject: [PATCH] Add libedit option

---
 srcpkgs/dash/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dash/template b/srcpkgs/dash/template
index 7ab7edeacd5f3..abd4e122e1876 100644
--- a/srcpkgs/dash/template
+++ b/srcpkgs/dash/template
@@ -3,8 +3,8 @@ pkgname=dash
 version=0.5.12
 revision=1
 build_style=gnu-configure
-configure_args="$(vopt_enable static)"
-hostmakedepends="bison"
+configure_args="$(vopt_enable static) $(vopt_with libedit)"
+hostmakedepends="bison $(vopt_if libedit libedit-devel)"
 short_desc="POSIX-compliant Unix shell, much smaller than GNU bash"
 maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
@@ -17,7 +17,7 @@ alternatives="
  sh:sh:/usr/bin/dash
  sh:sh.1:/usr/share/man/man1/dash.1"
 
-build_options="static"
+build_options="static libedit"
 
 post_install() {
 	 vlicense COPYING

             reply	other threads:[~2023-11-26  1:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-26  1:11 TakodaNotDakota [this message]
2023-11-26  2:48 ` [PR PATCH] [Updated] dash: " TakodaNotDakota
2023-11-26  2:49 ` TakodaNotDakota
2023-11-26 12:19 ` [PR REVIEW] " mhmdanas
2023-11-26 14:31 ` [PR PATCH] [Updated] dash: add " TakodaNotDakota
2023-12-04 13:12 ` sgn
2023-12-04 13:54 ` [PR PATCH] [Closed]: " ahesford
2023-12-04 13:54 ` ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47408@inbox.vuxu.org \
    --to=takodanotdakota@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).