Github messages for voidlinux
 help / color / mirror / Atom feed
From: Johnnynator <Johnnynator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] build-helper/rust.sh: prevent stripping by cargo
Date: Tue, 28 Nov 2023 11:57:03 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47460@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages rust-dbg
https://github.com/void-linux/void-packages/pull/47460

build-helper/rust.sh: prevent stripping by cargo
Some rust pacakges (e.g. eza and bat) do set strip = true
in their release profile which removes the debug symbols
before xbps-src can split them.

closes #47459


A patch file from https://github.com/void-linux/void-packages/pull/47460.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-dbg-47460.patch --]
[-- Type: text/x-diff, Size: 842 bytes --]

From 02db441c7d520c4d9f7221def57eacde69190a4e Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Tue, 28 Nov 2023 11:54:54 +0100
Subject: [PATCH] build-helper/rust.sh: prevent stripping by cargo

Some rust pacakges (e.g. eza and bat) do set strip = true
in their release profile which removes the debug symbols
before xbps-src can split them.

closes #47459
---
 common/build-helper/rust.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/build-helper/rust.sh b/common/build-helper/rust.sh
index f13ef7aa39568..460aad6a12e12 100644
--- a/common/build-helper/rust.sh
+++ b/common/build-helper/rust.sh
@@ -30,6 +30,9 @@ else
 	unset CARGO_BUILD_TARGET
 fi
 
+# prevent cargo stripping debug symbols
+export CARGO_PROFILE_RELEASE_STRIP=false
+
 # For cross-compiling rust -sys crates
 export PKG_CONFIG_ALLOW_CROSS=1
 

             reply	other threads:[~2023-11-28 10:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 10:57 Johnnynator [this message]
2023-11-28 11:23 ` [PR PATCH] [Merged]: " Johnnynator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47460@inbox.vuxu.org \
    --to=johnnynator@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).