Github messages for voidlinux
 help / color / mirror / Atom feed
From: Aicaya <Aicaya@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] libedit: fix badly-generated man pages
Date: Mon, 25 Dec 2023 02:43:08 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47901@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

There is a new pull request by Aicaya against master on the void-packages repository

https://github.com/Aicaya/void-packages libedit
https://github.com/void-linux/void-packages/pull/47901

libedit: fix badly-generated man pages
If nroff isn't detected by the build script, it will attempt to convert the mdoc macros into classic man macros.  Unfortunately, this results in the syntax being broken to the point where the man pages are pretty much useless.  Adding groff as a make dependency fixes this.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/47901.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libedit-47901.patch --]
[-- Type: text/x-diff, Size: 1032 bytes --]

From e1b689244dc505f84dedd3b9d1de5418bcc2bc32 Mon Sep 17 00:00:00 2001
From: Aicaya Maro <aicaya@posteo.net>
Date: Sun, 24 Dec 2023 21:25:20 -0400
Subject: [PATCH] libedit: fix badly-generated man pages

If nroff isn't detected by the build script, it will attempt to convert
the mdoc macros into classic man macros.  Unfortunately, this results in
the syntax being broken to the point where the man pages are pretty much
useless.  Adding groff as a make dependency fixes this.
---
 srcpkgs/libedit/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/libedit/template b/srcpkgs/libedit/template
index 96f4b0cf54e6d..ceb1c68276e7d 100644
--- a/srcpkgs/libedit/template
+++ b/srcpkgs/libedit/template
@@ -1,8 +1,9 @@
 # Template file for 'libedit'
 pkgname=libedit
 version=20230828.3.1
-revision=1
+revision=2
 build_style=gnu-configure
+hostmakedepends="groff"
 makedepends="ncurses-devel"
 short_desc="Port of the NetBSD Command Line Editor Library"
 maintainer="Orphaned <orphan@voidlinux.org>"

             reply	other threads:[~2023-12-25  1:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-25  1:43 Aicaya [this message]
2023-12-25  5:45 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47901@inbox.vuxu.org \
    --to=aicaya@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).