Github messages for voidlinux
 help / color / mirror / Atom feed
From: oreo639 <oreo639@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] file-roller: fix for inconsistencies between p7zip and 7zip
Date: Fri, 29 Dec 2023 16:25:26 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47978@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

There is a new pull request by oreo639 against master on the void-packages repository

https://github.com/oreo639/void-packages file-roller
https://github.com/void-linux/void-packages/pull/47978

file-roller: fix for inconsistencies between p7zip and 7zip
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

This fixes so that 'follow symlinks' works when enabled, and does not follow symlinks when the option is disabled.
Currently it follows symlinks when the option is disabled and errors when the option is enabled.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47978.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-file-roller-47978.patch --]
[-- Type: text/x-diff, Size: 2165 bytes --]

From e294ae04f0b721674e678586f280e6da3d8cbb0a Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Fri, 29 Dec 2023 07:23:29 -0800
Subject: [PATCH] file-roller: fix for inconsistencies between p7zip and 7zip

---
 .../patches/fix-symlink-handling-7zip.patch   | 22 +++++++++++++++++++
 srcpkgs/file-roller/template                  |  2 +-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/file-roller/patches/fix-symlink-handling-7zip.patch

diff --git a/srcpkgs/file-roller/patches/fix-symlink-handling-7zip.patch b/srcpkgs/file-roller/patches/fix-symlink-handling-7zip.patch
new file mode 100644
index 0000000000000..6fb0baeb9ff0d
--- /dev/null
+++ b/srcpkgs/file-roller/patches/fix-symlink-handling-7zip.patch
@@ -0,0 +1,22 @@
+file-roller assumes p7zip and assumes that 'follow_links' is disabled by default.
+This is true in p7zip but not 7zip. 7zip does not have a -l flag, and instead provides,
+the -snl and -snh flags for disabling 'follow_links'.
+
+This fixes compressing 7z files with 'follow_links' enabled and compressing files with
+broken symlinks with 'follow_links' disabled.
+--- a/src/fr-command-7z.c.orig
++++ b/src/fr-command-7z.c
+@@ -325,8 +325,11 @@ fr_command_7z_add (FrCommand  *command,
+ 	fr_process_add_arg (command->process, "-bd");
+ 	fr_process_add_arg (command->process, "-bb1");
+ 	fr_process_add_arg (command->process, "-y");
+-	if (follow_links)
+-		fr_process_add_arg (command->process, "-l");
++	if (! follow_links)
++        {
++		fr_process_add_arg (command->process, "-snh");
++		fr_process_add_arg (command->process, "-snl");
++        }
+ 	add_password_arg (command, archive->password, FALSE);
+ 	if ((archive->password != NULL)
+ 	    && (*archive->password != 0)
diff --git a/srcpkgs/file-roller/template b/srcpkgs/file-roller/template
index 826a05a773a0a..75430bcb40702 100644
--- a/srcpkgs/file-roller/template
+++ b/srcpkgs/file-roller/template
@@ -1,7 +1,7 @@
 # Template file for 'file-roller'
 pkgname=file-roller
 version=43.0
-revision=1
+revision=2
 build_style=meson
 hostmakedepends="gettext glib-devel itstool pkg-config desktop-file-utils
  gtk-update-icon-cache"

             reply	other threads:[~2023-12-29 15:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-29 15:25 oreo639 [this message]
2023-12-29 15:41 ` [PR PATCH] [Updated] " oreo639
2023-12-29 15:46 ` oreo639
2024-01-06 23:25 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47978@inbox.vuxu.org \
    --to=oreo639@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).