From: lemmi <lemmi@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] cdrdao: fix for whipper
Date: Wed, 31 Jan 2024 03:08:42 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48452@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
There is a new pull request by lemmi against master on the void-packages repository
https://github.com/lemmi/void-packages cdrdao
https://github.com/void-linux/void-packages/pull/48452
cdrdao: fix for whipper
From this PR: https://github.com/cdrdao/cdrdao/pull/21
More distributions seem to ship this patch.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/48452.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cdrdao-48452.patch --]
[-- Type: text/x-diff, Size: 2032 bytes --]
From bd528ef25afa76eba966365c40c908c299be0d55 Mon Sep 17 00:00:00 2001
From: lemmi <lemmi@nerd2nerd.org>
Date: Wed, 31 Jan 2024 03:06:10 +0100
Subject: [PATCH] cdrdao: fix for whipper
From this PR: https://github.com/cdrdao/cdrdao/pull/21
More distributions seem to ship this patch.
---
.../fix-uninitialized-toc-file-name.patch | 23 +++++++++++++++++++
srcpkgs/cdrdao/template | 2 +-
2 files changed, 24 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/cdrdao/patches/fix-uninitialized-toc-file-name.patch
diff --git a/srcpkgs/cdrdao/patches/fix-uninitialized-toc-file-name.patch b/srcpkgs/cdrdao/patches/fix-uninitialized-toc-file-name.patch
new file mode 100644
index 0000000000000..63e8fc9d10adf
--- /dev/null
+++ b/srcpkgs/cdrdao/patches/fix-uninitialized-toc-file-name.patch
@@ -0,0 +1,23 @@
+From 251a40ab42305c412674c7c2d391374d91e91c95 Mon Sep 17 00:00:00 2001
+From: Ole Bertram <git@bertr.am>
+Date: Thu, 23 Mar 2023 17:08:48 +0100
+Subject: [PATCH] Fix uninitialized TOC data file name
+
+This caused spurious garbled TOC files and/or segfaults when not using
+the `--datafile` option.
+---
+ dao/main.cc | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/dao/main.cc b/dao/main.cc
+index 8bf4590..d09fc69 100644
+--- a/dao/main.cc
++++ b/dao/main.cc
+@@ -219,6 +219,7 @@ DaoCommandLine::DaoCommandLine() :
+ fullBurn(false), withCddb(false), taoSource(false), keepImage(false), overburn(false),
+ writeSpeedControl(false), keep(false), printQuery(false), no_utf8(false)
+ {
++ dataFilename = NULL;
+ readingSpeed = -1;
+ writingSpeed = -1;
+ command = UNKNOWN;
diff --git a/srcpkgs/cdrdao/template b/srcpkgs/cdrdao/template
index 384bdb2e9ffb4..b49ecda5acd6a 100644
--- a/srcpkgs/cdrdao/template
+++ b/srcpkgs/cdrdao/template
@@ -1,7 +1,7 @@
# Template file for 'cdrdao'
pkgname=cdrdao
version=1.2.5
-revision=1
+revision=2
build_style=gnu-configure
hostmakedepends="pkg-config"
makedepends="lame-devel libao-devel libmad-devel libvorbis-devel"
next reply other threads:[~2024-01-31 2:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 2:08 lemmi [this message]
2024-01-31 14:11 ` [PR PATCH] [Merged]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48452@inbox.vuxu.org \
--to=lemmi@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).