From: lipidity <lipidity@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] foliate: add missing libadwaita dependency
Date: Thu, 29 Feb 2024 11:40:34 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49000@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
There is a new pull request by lipidity against master on the void-packages repository
https://github.com/lipidity/void-packages patch-1
https://github.com/void-linux/void-packages/pull/49000
foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch with the following error:
```
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28 @gi://Adw?version=1:3:25
```
#### Testing the changes
- I tested the changes in this PR: **briefly** (foliate stopped crashing after I installed libadwaita)
A patch file from https://github.com/void-linux/void-packages/pull/49000.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-49000.patch --]
[-- Type: text/x-diff, Size: 1151 bytes --]
From a242fa8fcd27c7a064452ae4dd7e275b296fe565 Mon Sep 17 00:00:00 2001
From: Ankur Kothari <ankur@lipidity.com>
Date: Thu, 29 Feb 2024 21:36:10 +1100
Subject: [PATCH] foliate: add missing libadwaita dependency
When libadwaita is not installed, foliate crashes on launch with the following error:
JS ERROR: Error: Requiring Adw, version 1: Typelib file for namespace 'Adw', version '1' not found
require@resource:///org/gnome/gjs/modules/esm/gi.js:16:28
@gi://Adw?version=1:3:25
---
srcpkgs/foliate/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/foliate/template b/srcpkgs/foliate/template
index f841cad354740..f1ef7b61cebae 100644
--- a/srcpkgs/foliate/template
+++ b/srcpkgs/foliate/template
@@ -6,7 +6,7 @@ build_style=meson
hostmakedepends="pkg-config gettext glib-devel
gtk4-update-icon-cache desktop-file-utils"
makedepends="gjs-devel gtk4-devel libadwaita-devel libwebkitgtk60-devel"
-depends="libwebkitgtk60 gjs"
+depends="libwebkitgtk60 gjs libadwaita"
checkdepends="desktop-file-utils appstream-glib"
short_desc="Simple and modern GTK eBook reader"
maintainer="Orphaned <orphan@voidlinux.org>"
next reply other threads:[~2024-02-29 10:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 10:40 lipidity [this message]
2024-02-29 10:42 ` sgn
2024-02-29 10:49 ` [PR PATCH] [Updated] " lipidity
2024-02-29 10:53 ` oreo639
2024-02-29 10:53 ` [PR PATCH] [Updated] " lipidity
2024-02-29 11:03 ` [PR PATCH] [Merged]: " oreo639
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49000@inbox.vuxu.org \
--to=lipidity@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).