Github messages for voidlinux
 help / color / mirror / Atom feed
From: Eloitor <Eloitor@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] [WIP] Fix autofirma with firefox
Date: Thu, 29 Feb 2024 15:42:56 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49005@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

There is a new pull request by Eloitor against master on the void-packages repository

https://github.com/Eloitor/void-packages autofirma
https://github.com/void-linux/void-packages/pull/49005

[WIP] Fix autofirma with firefox
#### Testing the changes
- I tested the changes in this PR: **NO**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

I received a bug report for using autofirma from firefox. Basically, somehow autofirma generates a file `/usr/lib64/firefox/defaults/pref/AutoFirma.js` which searches the file `/usr/bin/AutoFirma` which is not the name of the binary provided in the void package.

Maybe we should provide this file in the package instead of letting autofirma generate it? IDK.
I will ask for more testing of this PR (I don't know how to reproduce it) and I'll let you know when this is ready.

A patch file from https://github.com/void-linux/void-packages/pull/49005.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-49005.patch --]
[-- Type: text/x-diff, Size: 1187 bytes --]

From cca49111d5c0c1caf3a9a96abaddb097fd4cad19 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Thu, 29 Feb 2024 16:36:39 +0100
Subject: [PATCH] Fix autofirma with firefox

---
 srcpkgs/autofirma/template | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/autofirma/template b/srcpkgs/autofirma/template
index 2d87e27fb67811..bd076a43d9dbcc 100644
--- a/srcpkgs/autofirma/template
+++ b/srcpkgs/autofirma/template
@@ -1,7 +1,7 @@
 # Template file for 'autofirma'
 pkgname=autofirma
 version=1.8.2
-revision=1
+revision=2
 _jmulticard_version=1.8
 hostmakedepends="apache-maven openjdk11"
 depends="virtual?java-environment"
@@ -17,6 +17,12 @@ checksum="40ebcd1200129ca08c21176a5fbd64c04ce0ac6bd932c4b213d4b7213f851a0d
 # maven-surefire-plugin needed
 make_check=no
 
+do_patch() {
+	cd "clienteafirma-${version}"
+	sed -i 's|/usr/bin/AutoFirma|/usr/bin/autofirma|g' afirma-simple/src/main/resources/linux/AutoFirma.js
+	sed -i 's|/usr/bin/AutoFirma|/usr/bin/autofirma|g' afirma-simple/src/main/resources/help/Spanish.lproj/pgs/LineaComandos.html
+}
+
 do_build() {
 	. /etc/profile.d/jdk.sh
 	cd "jmulticard-${_jmulticard_version}"

             reply	other threads:[~2024-02-29 14:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 14:42 Eloitor [this message]
2024-02-29 18:03 ` [PR PATCH] [Updated] " Eloitor
2024-04-24  9:05 ` Eloitor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49005@inbox.vuxu.org \
    --to=eloitor@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).