From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [ISSUE] [RFC] unvendor desktop files, icons, and similar files from the srcpkgs tree
Date: Thu, 07 Mar 2024 04:19:30 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49164@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
New issue by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/49164
Description:
there are a number of packages that include void-created `.desktop` files, icons, and sometimes even other things like manual pages in `srcpkgs/<pkg>/files/`, when files like this should come from upstream or not at all. In a quick survey I did in the past, some of the vendored desktop files even have upstream-provided ones available! (in those cases, the desktop files we have are often outdated or different from upstream)
A rough count finds:
- 91 `.desktop` files (a few should stay, like pipewire's)
- 43 PNG, 2 xpm, and 2 SVG icons
IMO, most, if not all, of these should be removed and either replaced with an existing upstream one or contributed upstream. I'd be interested in working on that if it is desired.
It would also be nice to add some kind of lint for the future to prevent these from slipping in again, as I see it often in new package PRs.
@void-linux/pkg-committers thoughts?
next reply other threads:[~2024-03-07 3:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 3:19 classabbyamp [this message]
2024-06-06 14:05 ` classabbyamp
2024-06-06 14:06 ` classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49164@inbox.vuxu.org \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).