Github messages for voidlinux
 help / color / mirror / Atom feed
From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] common/xbps-src/shutils/update_check.sh: fix rx for gitlab
Date: Sat, 23 Mar 2024 11:48:14 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49475@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages fix-gl-update-check
https://github.com/void-linux/void-packages/pull/49475

common/xbps-src/shutils/update_check.sh: fix rx for gitlab
If you `View Source` on `https://gitlab.com/timvisee/prs/-/tags` or any other GitLab packages the archive links end with `&quot` instead of `"` - breaking `update-check` for multiple packages.

A patch file from https://github.com/void-linux/void-packages/pull/49475.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-gl-update-check-49475.patch --]
[-- Type: text/x-diff, Size: 1052 bytes --]

From fa07fa3f2f6fbd963356b1566013ee5cade91964 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 23 Mar 2024 16:13:09 +0530
Subject: [PATCH] common/xbps-src/shutils/update_check.sh: fix rx for gitlab

---
 common/xbps-src/shutils/update_check.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index 8bae017bbe4225..b7de9fd6cee5db 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -138,7 +138,7 @@ update_check() {
                     *) pkgurlname="$(printf %s "$url" | cut -d / -f 1-5)";;
                 esac
                 url="$pkgurlname/-/tags"
-                rx='/archive/[^/]+/\Q'"$pkgname"'\E-v?\K[\d.]+(?=\.tar\.gz")';;
+                rx='/archive/[^/]+/\Q'"$pkgname"'\E-v?\K[\d.]+(?=\.tar\.gz)';;
             *bitbucket.org*)
                 pkgurlname="$(printf %s "$url" | cut -d/ -f4,5)"
                 url="https://bitbucket.org/$pkgurlname/downloads"

             reply	other threads:[~2024-03-23 10:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-23 10:48 icp1994 [this message]
2024-03-23 11:42 ` [PR PATCH] [Closed]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49475@inbox.vuxu.org \
    --to=icp1994@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).