From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] qt5: use a sane default platform
Date: Fri, 12 Apr 2024 08:10:45 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49810@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
There is a new pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages qt5-platform
https://github.com/void-linux/void-packages/pull/49810
qt5: use a sane default platform
on `arm*`/`aarch64*`, qt5 defaults to the `eglfs` QPA platform, which is designed for embedded devices. because this is probably a less-common use-case on Void, it's more sane to default to `xcb`, like `x86_64*` does.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/49810.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qt5-platform-49810.patch --]
[-- Type: text/x-diff, Size: 1416 bytes --]
From c7bae0ae39cd14c8f50773275b08b101b47a4040 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Fri, 12 Apr 2024 02:08:14 -0400
Subject: [PATCH] qt5: use a sane default platform
on arm*/aarch64*, qt5 defaults to the eglfs QPA platform, which is
designed for embedded devices. because this is probably a less-common
use-case on Void, it's more sane to default to xcb, like x86_64* does.
---
srcpkgs/qt5/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/qt5/template b/srcpkgs/qt5/template
index 3efb7e42d5fd3f..0f8203e899c63f 100644
--- a/srcpkgs/qt5/template
+++ b/srcpkgs/qt5/template
@@ -3,9 +3,9 @@
# revbump libqtxdg after bumping patch version
pkgname=qt5
version=5.15.11+20231124
+revision=3
# commit 4765fa1df7a837db9c1f89c4da0dd76b74bb5fab
# base repo: https://invent.kde.org/qt/qt/qt5
-revision=2
build_style=meta
hostmakedepends="cmake clang17 flex perl glib-devel pkg-config
python3 re2c ruby which"
@@ -159,6 +159,9 @@ _create_config() {
echo "QMAKE_CFLAGS = ${CFLAGS}" >> ${qmake_conf}
echo "QMAKE_CXXFLAGS = ${CXXFLAGS}" >> ${qmake_conf}
echo >> ${qmake_conf}
+ # use a sane default platform (prevent defaulting to eglfs)
+ echo "QT_QPA_DEFAULT_PLATFORM = xcb" >> ${qmake_conf}
+ echo >> ${qmake_conf}
case "$XBPS_TARGET_MACHINE" in
arm*)
echo "include(../common/linux_arm_device_post.conf)" >> ${qmake_conf} ;;
next reply other threads:[~2024-04-12 6:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 6:10 classabbyamp [this message]
2024-04-14 15:11 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-49810@inbox.vuxu.org \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).